haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ERC: flag duplicated local labels with no pins as floating 

See https://gitlab.com/kicad/code/kicad/-/issues/9593
This commit is contained in:
Jon Evans 2021-11-27 22:34:11 -05:00
parent 65af3a8568
commit d7f5917fb0
1 changed files with 31 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
eeschema/connection_graph.cpp
View File

@ -2769,6 +2769,24 @@ bool CONNECTION_GRAPH::ercCheckLabels( const CONNECTION_SUBGRAPH* aSubgraph )
bool hasOtherConnections = false; bool hasOtherConnections = false;
int pinCount = 0; int pinCount = 0;
auto hasPins =
[]( const CONNECTION_SUBGRAPH* aSubgraph )
{
for( const SCH_ITEM* item : aSubgraph->m_items )
{
switch( item->Type() )
{
case SCH_PIN_T:
case SCH_SHEET_PIN_T:
return true;
default: break;
}
}
return false;
};
for( auto item : aSubgraph->m_items ) for( auto item : aSubgraph->m_items )
{ {
switch( item->Type() ) switch( item->Type() )
@ -2850,7 +2868,19 @@ bool CONNECTION_GRAPH::ercCheckLabels( const CONNECTION_SUBGRAPH* aSubgraph )
auto it = m_local_label_cache.find( pair ); auto it = m_local_label_cache.find( pair );
if( it != m_local_label_cache.end() && it->second.size() > 1 ) if( it != m_local_label_cache.end() && it->second.size() > 1 )
hasOtherConnections = true; {
for( const CONNECTION_SUBGRAPH* neighbor : it->second )
{
if( neighbor == aSubgraph )
continue;
if( hasPins( neighbor ) )
{
hasOtherConnections = true;
break;
}
}
}
} }
if( !hasOtherConnections && settings.IsTestEnabled( errCode ) ) if( !hasOtherConnections && settings.IsTestEnabled( errCode ) )