haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Allow no-connects on standalone hierarchical pins/ports 

Fixes https://gitlab.com/kicad/code/kicad/-/issues/16397
This commit is contained in:
Jon Evans 2023-12-22 19:08:14 -05:00
parent 7470ec80e4
commit dad842d3f0
1 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
eeschema/connection_graph.cpp
View File

@ -3244,7 +3244,6 @@ bool CONNECTION_GRAPH::ercCheckBusToBusEntryConflicts( const CONNECTION_SUBGRAPH
}
// TODO(JE) Check sheet pins here too?
bool CONNECTION_GRAPH::ercCheckNoConnects( const CONNECTION_SUBGRAPH* aSubgraph )
{
ERC_SETTINGS& settings = m_schematic->ErcSettings();
@ -3314,6 +3313,23 @@ bool CONNECTION_GRAPH::ercCheckNoConnects( const CONNECTION_SUBGRAPH* aSubgraph
if( aSubgraph->m_no_connect != nullptr )
{
// Special case: If the subgraph being checked consists of only a hier port/pin and
// a no-connect, we don't issue a "no-connect connected" warning just because
// connections exist on the sheet on the other side of the link.
VECTOR2I noConnectPos = aSubgraph->m_no_connect->GetPosition();
for( SCH_SHEET_PIN* hierPin : aSubgraph->m_hier_pins )
{
if( hierPin->GetPosition() == noConnectPos )
return true;
}
for( SCH_HIERLABEL* hierLabel : aSubgraph->m_hier_ports )
{
if( hierLabel->GetPosition() == noConnectPos )
return true;
}
if( unique_pins.size() > 1 && settings.IsTestEnabled( ERCE_NOCONNECT_CONNECTED ) )
{
std::shared_ptr<ERC_ITEM> ercItem = ERC_ITEM::Create( ERCE_NOCONNECT_CONNECTED );