haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ERC warn if hierarchical labels have no matching sheet pin 

Fixes https://gitlab.com/kicad/code/kicad/-/issues/7511
This commit is contained in:
Jon Evans 2021-02-13 10:24:22 -05:00
parent 7015f4cf75
commit dbd749c07a
1 changed files with 22 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
eeschema/connection_graph.cpp
View File

@ -2818,6 +2818,7 @@ int CONNECTION_GRAPH::ercCheckHierSheets()
SCH_SHEET* parentSheet = static_cast<SCH_SHEET*>( item );
std::map<wxString, SCH_SHEET_PIN*> pins;
std::map<wxString, SCH_HIERLABEL*> labels;
for( SCH_SHEET_PIN* pin : parentSheet->GetPins() )
{
@ -2840,6 +2841,10 @@ int CONNECTION_GRAPH::ercCheckHierSheets()
if( subItem->Type() == SCH_HIER_LABEL_T )
{
SCH_HIERLABEL* label = static_cast<SCH_HIERLABEL*>( subItem );
if( !pins.count( label->GetText() ) )
labels[label->GetText()] = label;
pins.erase( label->GetText() );
}
}
@ -2860,6 +2865,23 @@ int CONNECTION_GRAPH::ercCheckHierSheets()
errors++;
}
for( const std::pair<const wxString, SCH_HIERLABEL*>& unmatched : labels )
{
wxString msg = wxString::Format( _( "Hierarchical label %s has no matching "
"sheet pin outside the sheet" ),
UnescapeString( unmatched.first ) );
std::shared_ptr<ERC_ITEM> ercItem = ERC_ITEM::Create( ERCE_HIERACHICAL_LABEL );
ercItem->SetItems( unmatched.second );
ercItem->SetErrorMessage( msg );
ercItem->SetIsSheetSpecific();
SCH_MARKER* marker = new SCH_MARKER( ercItem, unmatched.second->GetPosition() );
parentSheet->GetScreen()->Append( marker );
errors++;
}
}
}