haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

A bit more commenting for the guessSelectionCandidates logic.

This commit is contained in:
Jeff Young 2017-12-21 11:51:47 +00:00 committed by Maciej Suminski
parent 158bc0619d
commit dbf39e6333
1 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
pcbnew/tools/selection_tool.cpp
View File

@ -1763,6 +1763,8 @@ void SELECTION_TOOL::guessSelectionCandidates( GENERAL_COLLECTOR& aCollector ) c
std::set<BOARD_ITEM*> rejected; std::set<BOARD_ITEM*> rejected;
std::set<BOARD_ITEM*> forced; std::set<BOARD_ITEM*> forced;
// footprints which are below this percentage of the largest footprint will be considered
// for selection; all others will not
constexpr double footprintAreaRatio = 0.2; constexpr double footprintAreaRatio = 0.2;
// footprints containing pads with pad-to-footprint area ratio smaller than this will be dropped // footprints containing pads with pad-to-footprint area ratio smaller than this will be dropped
constexpr double modulePadMinCoverRatio = 0.45; constexpr double modulePadMinCoverRatio = 0.45;
@ -1886,14 +1888,14 @@ void SELECTION_TOOL::guessSelectionCandidates( GENERAL_COLLECTOR& aCollector ) c
if( forced.count( mod ) ) if( forced.count( mod ) )
continue; continue;
double normalizedArea = calcRatio( calcArea( mod ), maxArea );
if( normalizedArea > footprintAreaRatio
// filter out components larger than the viewport // filter out components larger than the viewport
|| mod->ViewBBox().Contains( viewport ) ) if( mod->ViewBBox().Contains( viewport ) )
{ rejected.insert( mod );
// if a module is much less than the area of the largest module
// then it should be considered for selection; reject all other
// modules
else if( calcRatio( calcArea( mod ), maxArea ) > footprintAreaRatio )
rejected.insert( mod ); rejected.insert( mod );
}
} }
} }
} }