haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

EDA_ITEM::SwapData() must not swap the parent pointer. 

The image's parent pointer might have gone out of scope.
This commit is contained in:
Jeff Young 2024-02-09 20:03:15 +00:00
parent 53896105c0
commit dc48af3e5c
1 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
eeschema/sch_marker.cpp
View File

@ -69,6 +69,20 @@ EDA_ITEM* SCH_MARKER::Clone() const
void SCH_MARKER::SwapData( SCH_ITEM* aItem )
{
SCH_ITEM::SwapFlags( aItem );
SCH_MARKER* item = static_cast<SCH_MARKER*>( aItem );
std::swap( m_isLegacyMarker, item->m_isLegacyMarker );
std::swap( m_Pos, item->m_Pos );
std::swap( m_markerType, item->m_markerType );
std::swap( m_excluded, item->m_excluded );
std::swap( m_rcItem, item->m_rcItem );
std::swap( m_scalingFactor, item->m_scalingFactor );
std::swap( m_shapeBoundingBox, item->m_shapeBoundingBox );
std::swap( *((SCH_MARKER*) this), *((SCH_MARKER*) aItem ) );
}