Revert "Revert "Set DoubleBuffering to reduce flicker""

This reverts commit c18cab6154.

3d-viewer/3d_viewer/3d_menubar.cpp

@@ -319,7 +319,6 @@ void EDA_3D_VIEWER::CreateMenuBar()
     menuBar->Append( viewMenu, _( "&View" ) );
     menuBar->Append( prefsMenu, _( "&Preferences" ) );
     AddStandardHelpMenu( menuBar );
-    menuBar->SetDoubleBuffered( true );
 
     SetMenuBar( menuBar );
 }

cvpcb/menubar.cpp

@@ -103,7 +103,6 @@ void CVPCB_MAINFRAME::ReCreateMenuBar()
     menuBar->Append( editMenu, _( "&Edit" ) );
     menuBar->Append( prefsMenu, _( "&Preferences" ) );
     AddStandardHelpMenu( menuBar );
-    menuBar->SetDoubleBuffered( true );
 
     SetMenuBar( menuBar );
     delete oldMenuBar;

eeschema/libedit/menubar_libedit.cpp

@@ -229,7 +229,6 @@ void LIB_EDIT_FRAME::ReCreateMenuBar()
     menuBar->Append( inspectMenu, _( "&Inspect" ) );
     menuBar->Append( prefsMenu, _( "P&references" ) );
     AddStandardHelpMenu( menuBar );
-    menuBar->SetDoubleBuffered( true );
 
     SetMenuBar( menuBar );
     delete oldMenuBar;

eeschema/menubar.cpp

@@ -343,7 +343,6 @@ void SCH_EDIT_FRAME::ReCreateMenuBar()
     menuBar->Append( toolsMenu, _( "&Tools" ) );
     menuBar->Append( prefsMenu, _( "P&references" ) );
     AddStandardHelpMenu( menuBar );
-    menuBar->SetDoubleBuffered( true );
 
     SetMenuBar( menuBar );
     delete oldMenuBar;

eeschema/sch_draw_panel.cpp

@@ -197,6 +197,8 @@ void SCH_DRAW_PANEL::OnShow()
         if( frame )
             frame->ActivateGalCanvas();
     }
+
+    m_parent->SetDoubleBuffered( true );
 }
 
 

eeschema/sch_preview_panel.cpp

@@ -87,6 +87,8 @@ SCH_PREVIEW_PANEL::~SCH_PREVIEW_PANEL()
 
 void SCH_PREVIEW_PANEL::OnShow()
 {
+    m_parent->SetDoubleBuffered( true );
+
     //m_view->RecacheAllItems();
 }
 

eeschema/toolbars_lib_view.cpp

@@ -138,7 +138,6 @@ void LIB_VIEW_FRAME::ReCreateMenuBar()
     menuBar->Append( fileMenu, _( "&File" ) );
     menuBar->Append( viewMenu, _( "&View" ) );
     AddStandardHelpMenu( menuBar );
-    menuBar->SetDoubleBuffered( true );
 
     SetMenuBar( menuBar );
     delete oldMenuBar;

gerbview/gerbview_draw_panel_gal.cpp

@@ -100,6 +100,7 @@ void GERBVIEW_DRAW_PANEL_GAL::OnShow()
 
     if( frame )
     {
+        m_parent->SetDoubleBuffered( true );
         SetTopLayer( frame->GetActiveLayer() );
         auto& displ_opts = frame->GetDisplayOptions();
         static_cast<KIGFX::GERBVIEW_RENDER_SETTINGS*>(

gerbview/menubar.cpp

@@ -266,7 +266,6 @@ void GERBVIEW_FRAME::ReCreateMenuBar()
     menuBar->Append( toolsMenu, _( "&Tools" ) );
     menuBar->Append( preferencesMenu, _( "&Preferences" ) );
     AddStandardHelpMenu( menuBar );
-    menuBar->SetDoubleBuffered( true );
 
     // Associate the menu bar with the frame, if no previous menubar
     SetMenuBar( menuBar );

kicad/menubar.cpp

@@ -162,7 +162,6 @@ void KICAD_MANAGER_FRAME::ReCreateMenuBar()
     menuBar->Append( toolsMenu, _( "&Tools" ) );
     menuBar->Append( prefsMenu, _( "&Preferences" ) );
     AddStandardHelpMenu( menuBar );
-    menuBar->SetDoubleBuffered( true );
 
     SetMenuBar( menuBar );
     delete oldMenuBar;

pagelayout_editor/menubar.cpp

@@ -189,7 +189,6 @@ void PL_EDITOR_FRAME::ReCreateMenuBar()
     menuBar->Append( inspectorMenu, _( "&Inspect" ) );
     menuBar->Append( preferencesMenu, _( "P&references" ) );
     AddStandardHelpMenu( menuBar );
-    menuBar->SetDoubleBuffered( true );
 
     SetMenuBar( menuBar );
     delete oldMenuBar;

pcbnew/menubar_footprint_editor.cpp

@@ -306,7 +306,6 @@ void FOOTPRINT_EDIT_FRAME::ReCreateMenuBar()
     menuBar->Append( toolsMenu, _( "&Tools" ) );
     menuBar->Append( prefsMenu, _( "P&references" ) );
     AddStandardHelpMenu( menuBar );
-    menuBar->SetDoubleBuffered( true );
 
     SetMenuBar( menuBar );
     delete oldMenuBar;

pcbnew/menubar_pcb_editor.cpp

@@ -555,7 +555,6 @@ void PCB_EDIT_FRAME::ReCreateMenuBar()
     menuBar->Append( toolsMenu, _( "&Tools" ) );
     menuBar->Append( prefsMenu, _( "P&references" ) );
     AddStandardHelpMenu( menuBar );
-    menuBar->SetDoubleBuffered( true );
 
     SetMenuBar( menuBar );
     delete oldMenuBar;

pcbnew/pcb_draw_panel_gal.cpp

@@ -416,6 +416,7 @@ void PCB_DRAW_PANEL_GAL::OnShow()
 
     if( frame )
     {
+        m_parent->SetDoubleBuffered( true );
         SetTopLayer( frame->GetActiveLayer() );
         KIGFX::PAINTER* painter = m_view->GetPainter();
         auto settings = static_cast<KIGFX::PCB_RENDER_SETTINGS*>( painter->GetSettings() );

pcbnew/toolbars_footprint_viewer.cpp

@@ -189,7 +189,6 @@ void FOOTPRINT_VIEWER_FRAME::ReCreateMenuBar()
     menuBar->Append( fileMenu, _( "&File" ) );
     menuBar->Append( viewMenu, _( "&View" ) );
     AddStandardHelpMenu( menuBar );
-    menuBar->SetDoubleBuffered( true );
 
     SetMenuBar( menuBar );
     delete oldMenuBar;