Some cleanup

eeschema/component_references_lister.cpp

@@ -516,7 +516,7 @@ void SCH_REFERENCE_LIST::Annotate( bool aUseSheetNum, int aSheetIntervalId, int
     }
 
     // Remove aAdditionalRefs references
-    for( int i = originalSize; i < ( aAdditionalRefs.GetCount() + originalSize ); i++ )
+    for( size_t i = originalSize; i < ( aAdditionalRefs.GetCount() + originalSize ); i++ )
         RemoveItem( originalSize );
 
     wxASSERT( originalSize == GetCount() ); // Make sure we didn't make a mistake

eeschema/sch_reference_list.h

@@ -223,7 +223,7 @@ public:
         flatList.clear();
     }
 
-    unsigned GetCount() const { return flatList.size(); }
+    size_t GetCount() const { return flatList.size(); }
 
     SCH_REFERENCE& GetItem( int aIdx ) { return flatList[aIdx]; }
     const SCH_REFERENCE& GetItem( int aIdx ) const { return flatList[aIdx]; }

pcbnew/board_design_settings.cpp

@@ -589,7 +589,7 @@ BOARD_DESIGN_SETTINGS::BOARD_DESIGN_SETTINGS( JSON_SETTINGS* aParent, const std:
             {
                 m_ZoneFillVersion = aVal ? 6 : 5;
             },
-            6 ) );
+            true ) );
 
     m_params.emplace_back( new PARAM<bool>( "zones_allow_external_fillets",
             &m_ZoneKeepExternalFillets, false ) );

pcbnew/router/pns_line.cpp

@@ -230,10 +230,8 @@ bool LINE::Walkaround( const SHAPE_LINE_CHAIN& aObstacle, SHAPE_LINE_CHAIN& aPat
     }
 
     // insert all intersections found into the new hull/path SLCs
-    for( auto ip : ips )
+    for( auto& ip : ips )
     {
-        bool isNewP, isNewH;
-
         if( pnew.Find( ip.p ) < 0 )
         {
             pnew.Split(ip.p);