haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Prevent crashes when pasting symbols 

When pasting a symbol that originates in a non-standard library, the
symbol may _only_ have an instance in the sheet and so adding it to the
sheet updates the instance data and needs to be refreshed before
annotating
This commit is contained in:
Seth Hillbrand 2022-11-21 13:28:51 -08:00
parent 106508f266
commit e3cc0a5bc7
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
eeschema/tools/sch_editor_control.cpp
View File

@ -2086,6 +2086,27 @@ int SCH_EDITOR_CONTROL::Paste( const TOOL_EVENT& aEvent )
if( pasteMode == PASTE_MODE::UNIQUE_ANNOTATIONS || pasteMode == PASTE_MODE::RESPECT_OPTIONS ) if( pasteMode == PASTE_MODE::UNIQUE_ANNOTATIONS || pasteMode == PASTE_MODE::RESPECT_OPTIONS )
{ {
pastedSymbols.clear();
// The symbol references may be changed by adding them to the schematic
// if they only exist on the schematic (e.g. from non-standard libraries), so
// recreate the pastedSymbols reference list here with the current data
for( unsigned i = 0; i < loadedItems.size(); ++i )
{
if( SCH_SYMBOL* symbol = dyn_cast<SCH_SYMBOL*>( loadedItems[i] ) )
{
for( SCH_SHEET_PATH& instance : pasteInstances )
{
// Ignore pseudo-symbols (e.g. power symbols)
if( symbol->GetRef( &instance )[0] != wxT( '#' ) )
{
SCH_REFERENCE schReference( symbol, symbol->GetLibSymbolRef().get(), instance );
pastedSymbols[instance].AddItem( schReference );
}
}
}
}
for( SCH_SHEET_PATH& instance : pasteInstances ) for( SCH_SHEET_PATH& instance : pasteInstances )
{ {
pastedSymbols[instance].SortByReferenceOnly(); pastedSymbols[instance].SortByReferenceOnly();