haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Show non-driven error on single-pin nets 

Better to have both the single-pin error message and the non-driven
error message when an input pin is not connected than miss error
messages when the pin is connected to a blank net

Fixes https://gitlab.com/kicad/code/kicad/issues/10430
This commit is contained in:
Seth Hillbrand 2022-04-06 16:51:44 -07:00
parent a700531aba
commit e740db61f5
2 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
eeschema/dialogs/dialog_erc.cpp
View File

@ -396,7 +396,7 @@ void DIALOG_ERC::testErc()
|| settings.IsTestEnabled( ERCE_POWERPIN_NOT_DRIVEN ) || settings.IsTestEnabled( ERCE_POWERPIN_NOT_DRIVEN )
|| settings.IsTestEnabled( ERCE_PIN_NOT_DRIVEN ) ) || settings.IsTestEnabled( ERCE_PIN_NOT_DRIVEN ) )
{ {
tester.TestPinToPin(); tester.TestPinToPin();
} }
// Test similar labels (i;e. labels which are identical when // Test similar labels (i;e. labels which are identical when

4
eeschema/erc.cpp
View File

@ -452,10 +452,6 @@ int ERC_TESTER::TestPinToPin()
} }
} }
// Single-pin nets are handled elsewhere
if( pins.size() < 2 )
continue;
std::set<std::pair<SCH_PIN*, SCH_PIN*>> tested; std::set<std::pair<SCH_PIN*, SCH_PIN*>> tested;
SCH_PIN* needsDriver = nullptr; SCH_PIN* needsDriver = nullptr;