haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Minor compil and Coverity warnings fixes.

This commit is contained in:
jean-pierre charras 2023-01-02 10:12:16 +01:00
parent c1ea90abc6
commit e8114dc49a
8 changed files with 14 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
common/eseries.cpp
View File

@ -115,7 +115,7 @@ int E_SERIES::buildSeriesData( const double aList[] )
for( ; ; )
{
double curr_r;
double curr_r = LAST_VALUE;
for( int ii = 0; ; ii++ )
{

5
common/jobs/job_export_sch_pdf.h
View File

@ -30,7 +30,10 @@ public:
JOB_EXPORT_SCH_PDF( bool aIsCli ) :
JOB( "pdf", aIsCli ),
m_filename(),
m_outputFile()
m_outputFile(),
m_blackAndWhite( false ),
m_useBackgroundColor( false ),
m_plotDrawingSheet( false )
{
}

5
common/jobs/job_export_sch_svg.h
View File

@ -30,7 +30,10 @@ public:
JOB_EXPORT_SCH_SVG( bool aIsCli ) :
JOB( "svg", aIsCli ),
m_filename(),
m_outputDirectory()
m_outputDirectory(),
m_blackAndWhite( false ),
m_useBackgroundColor( false ),
m_plotDrawingSheet( false )
{
}

1
eeschema/sch_plotter.h
View File

@ -95,6 +95,7 @@ struct SCH_PLOT_SETTINGS
SCH_PLOT_SETTINGS() :
m_plotAll( true ),
m_plotDrawingSheet( true ),
m_blackAndWhite( false ),
m_pageSizeSelect( 0 ),
m_useBackgroundColor( true ),
m_HPGLPenSize( 1.0 ),

6
eeschema/sim/sim_model.cpp
View File

@ -540,7 +540,7 @@ std::unique_ptr<SIM_MODEL> SIM_MODEL::Create( const std::vector<T>& aFields,
{
model->ReadDataFields( &aFields, aPins );
}
catch( const IO_ERROR& e )
catch( const IO_ERROR& parse_err )
{
// Just because we can't parse it doesn't mean that a SPICE interpreter can't. Fall
// back to a raw spice code model.
@ -557,10 +557,10 @@ std::unique_ptr<SIM_MODEL> SIM_MODEL::Create( const std::vector<T>& aFields,
model->createPins( aPins );
model->m_serializer->ParsePins( GetFieldValue( &aFields, PINS_FIELD ) );
}
catch( const IO_ERROR& e )
catch( const IO_ERROR& err )
{
// We own the pin syntax, so if we can't parse it then there's an error, full stop.
DisplayErrorMessage( nullptr, e.What() );
DisplayErrorMessage( nullptr, err.What() );
}
}

2
pcbnew/pcb_edit_frame.cpp
View File

@ -1351,7 +1351,7 @@ void PCB_EDIT_FRAME::SetActiveLayer( PCB_LAYER_ID aLayer )
}
else if( item->Type() == PCB_TRACE_T || item->Type() == PCB_ARC_T )
{
PCB_TRACK* track = dynamic_cast<PCB_TRACK*>( item );
PCB_TRACK* track = static_cast<PCB_TRACK*>( item );
// Clearances could be layer-dependent so redraw them when the active layer
// is changed

1
pcbnew/pcbnew_jobs_handler.cpp
View File

@ -661,7 +661,6 @@ int PCBNEW_JOBS_HANDLER::JobExportFpSvg( JOB* aJob )
return CLI::EXIT_CODES::ERR_UNKNOWN;
}
FOOTPRINT* symbol = nullptr;
if( !svgJob->m_outputDirectory.IsEmpty() && !wxDir::Exists( svgJob->m_outputDirectory ) )
{
wxFileName::Mkdir( svgJob->m_outputDirectory );

3
pcbnew/tools/pcb_point_editor.cpp
View File

@ -832,9 +832,6 @@ void PCB_POINT_EDITOR::editArcCenterKeepEndpoints( PCB_SHAPE* aArc, const VECTOR
SEG legal( m - perp, m + perp );
OPT_VECTOR2I hIntersect = legal.IntersectLines( SEG( aCenter, aCenter + VECTOR2( 1, 0 ) ) );
OPT_VECTOR2I vIntersect = legal.IntersectLines( SEG( aCenter, aCenter + VECTOR2( 0, 1 ) ) );
const SEG testSegments[] = { SEG( aCenter, aCenter + VECTOR2( 1, 0 ) ),
SEG( aCenter, aCenter + VECTOR2( 0, 1 ) ) };