Banish ignore.h to core

common/dialog_shim.cpp

@@ -23,7 +23,7 @@
  */
 
 #include <dialog_shim.h>
-#include <ignore.h>
+#include <core/ignore.h>
 #include <kiway_player.h>
 #include <kiway.h>
 #include <pgm_base.h>

common/kiway.cpp

@@ -24,7 +24,7 @@
 
 #include <cstring>
 
-#include <ignore.h>
+#include <core/ignore.h>
 #include <macros.h>
 #include <kiway.h>
 #include <kiway_player.h>
@@ -445,7 +445,8 @@ KIWAY_PLAYER* KIWAY::Player( FRAME_T aFrameType, bool doCreate, wxTopLevelWindow
         }
         catch( const std::exception& e )
         {
-            wxLogError( e.what() );
+            const char* ptr = e.what();
+            wxLogError( ptr );
             wxLogError( _( "Error loading editor." ) );
         }
         catch( ... )

common/kiway_holder.cpp

@@ -23,7 +23,7 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
  */
 
-#include <ignore.h>
+#include <core/ignore.h>
 #include <kiway.h>
 #include <kiway_holder.h>
 #include <project.h>

common/plotters/PDF_plotter.cpp

@@ -37,7 +37,7 @@
 #include <advanced_config.h>
 #include <eda_text.h> // for IsGotoPageHref
 #include <font/font.h>
-#include <ignore.h>
+#include <core/ignore.h>
 #include <macros.h>
 #include <trigo.h>
 #include <string_utils.h>

common/richio.cpp

@@ -26,7 +26,7 @@
 #include <cstdarg>
 #include <config.h> // HAVE_FGETC_NOLOCK
 
-#include <ignore.h>
+#include <core/ignore.h>
 #include <richio.h>
 #include <errno.h>
 

common/tool/tool_dispatcher.cpp

@@ -23,7 +23,7 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
  */
 
-#include <ignore.h>
+#include <core/ignore.h>
 #include <macros.h>
 #include <trace_helpers.h>
 #include <tool/tool_manager.h>

common/widgets/gal_options_panel.cpp

@@ -31,7 +31,7 @@
 #include <wx/statbox.h>
 #include <wx/statline.h>
 
-#include <ignore.h>
+#include <core/ignore.h>
 #include <widgets/gal_options_panel.h>
 #include <settings/app_settings.h>
 #include <eda_draw_frame.h>

eeschema/sch_edit_frame.cpp

@@ -34,7 +34,7 @@
 #include <executable_names.h>
 #include <gestfich.h>
 #include <dialogs/html_message_box.h>
-#include <ignore.h>
+#include <core/ignore.h>
 #include <invoke_sch_dialog.h>
 #include <string_utils.h>
 #include <kiface_base.h>

gerbview/rs274x.cpp

@@ -31,7 +31,7 @@
 
 #include <gerbview.h>
 #include <gerber_file_image.h>
-#include <ignore.h>
+#include <core/ignore.h>
 #include <macros.h>
 #include <X2_gerber_attributes.h>
 #include <gbr_metadata.h>

pcbnew/kicad_clipboard.cpp

@@ -27,7 +27,7 @@
 #include <wx/log.h>
 
 #include <board.h>
-#include <ignore.h>
+#include <core/ignore.h>
 #include <pad.h>
 #include <pcb_group.h>
 #include <pcb_shape.h>

pcbnew/load_select_footprint.cpp

@@ -38,7 +38,7 @@ using namespace std::placeholders;
 #include <footprint_tree_pane.h>
 #include <footprint_viewer_frame.h>
 #include <fp_lib_table.h>
-#include <ignore.h>
+#include <core/ignore.h>
 #include <io_mgr.h>
 #include <string_utils.h>
 #include <kiway.h>

pcbnew/pcb_textbox.cpp

@@ -35,7 +35,7 @@
 #include <callback_gal.h>
 #include <convert_basic_shapes_to_polygon.h>
 #include <macros.h>
-#include <ignore.h>
+#include <core/ignore.h>
 
 
 PCB_TEXTBOX::PCB_TEXTBOX( BOARD_ITEM* parent ) :

pcbnew/plugins/kicad/pcb_parser.cpp

@@ -48,7 +48,7 @@
 #include <footprint.h>
 #include <geometry/shape_line_chain.h>
 #include <font/font.h>
-#include <ignore.h>
+#include <core/ignore.h>
 #include <netclass.h>
 #include <plugins/kicad/pcb_plugin.h>
 #include <pcb_plot_params_parser.h>

pcbnew/plugins/legacy/legacy_plugin.cpp

@@ -75,7 +75,7 @@
 #include <board.h>
 #include <board_design_settings.h>
 #include <footprint.h>
-#include <ignore.h>
+#include <core/ignore.h>
 #include <pad.h>
 #include <pcb_track.h>
 #include <pcb_text.h>

pcbnew/python/scripting/pcbnew_scripting_helpers.cpp

@@ -40,7 +40,7 @@
 #include <drc/drc_engine.h>
 #include <drc/drc_item.h>
 #include <fp_lib_table.h>
-#include <ignore.h>
+#include <core/ignore.h>
 #include <io_mgr.h>
 #include <string_utils.h>
 #include <macros.h>

plugins/3d/vrml/CMakeLists.txt

@@ -65,7 +65,7 @@ add_library( s3d_plugin_vrml MODULE
         x3d/x3d_transform.cpp
         )
 
-target_link_libraries( s3d_plugin_vrml kicad_3dsg ${OPENGL_LIBRARIES} ${wxWidgets_LIBRARIES} ZLIB::ZLIB )
+target_link_libraries( s3d_plugin_vrml kicad_3dsg core ${OPENGL_LIBRARIES} ${wxWidgets_LIBRARIES} ZLIB::ZLIB )
 
 target_include_directories( s3d_plugin_vrml PRIVATE
     $<TARGET_PROPERTY:gzip-hpp,INTERFACE_INCLUDE_DIRECTORIES>

qa/tools/pcbnew_tools/tools/polygon_triangulation/polygon_triangulation.cpp

@@ -32,7 +32,7 @@
 #include <qa_utils/utility_registry.h>
 
 #include <board.h>
-#include <ignore.h>
+#include <core/ignore.h>
 #include <zone.h>
 #include <profile.h>
 

qa/unittests/eeschema/test_eagle_plugin.cpp

@@ -24,7 +24,7 @@
 
 #include <qa_utils/wx_utils/unit_test_utils.h>
 
-#include <ignore.h>
+#include <core/ignore.h>
 #include <kiway.h>
 #include <sch_io_mgr.h>
 

qa/unittests/eeschema/test_sch_rtree.cpp

@@ -27,7 +27,7 @@
  */
 
 #include <base_units.h>
-#include <ignore.h>
+#include <core/ignore.h>
 #include <sch_junction.h>
 #include <sch_no_connect.h>
 #include <qa_utils/uuid_test_utils.h>