haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Symbol checker: fix incorrect test for duplicate pins. 

Fixes #11660
https://gitlab.com/kicad/code/kicad/issues/11660
This commit is contained in:
jean-pierre charras 2022-05-23 11:20:12 +02:00
parent ea29c66608
commit eae5e9f00e
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
eeschema/symbol_checker.cpp
View File

@ -70,9 +70,17 @@ void CheckLibSymbol( LIB_SYMBOL* aSymbol, std::vector<wxString>& aMessages,
LIB_PIN* pin = pinList[ii - 1];
LIB_PIN* next = pinList[ii];
if( pin->GetNumber() != next->GetNumber() || pin->GetConvert() != next->GetConvert() )
if( pin->GetNumber() != next->GetNumber() )
continue;
// Pins are not duplicated only if they are in different convert bodies
// (but GetConvert() == 0 means commun to all convert bodies)
if( pin->GetConvert() != 0 && next->GetConvert() != 0 )
{
if( pin->GetConvert() != next->GetConvert() )
continue;
}
wxString pinName;
wxString nextName;