haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Altium PCB import: remove more invalid polygons.

This commit is contained in:
Alex Shvartzkop 2023-07-21 08:00:24 +05:00
parent f29bacbccd
commit eb6cd4cc5d
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
pcbnew/plugins/altium/altium_pcb.cpp
View File

@ -1689,11 +1689,12 @@ void ALTIUM_PCB::ParsePolygons6Data( const ALTIUM_COMPOUND_FILE& aAltiumPcbF
SHAPE_LINE_CHAIN linechain; SHAPE_LINE_CHAIN linechain;
HelperShapeLineChainFromAltiumVertices( linechain, elem.vertices ); HelperShapeLineChainFromAltiumVertices( linechain, elem.vertices );
if( linechain.PointCount() < 2 ) if( linechain.PointCount() < 3 )
{ {
// We have found multiple Altium files with polygon records containing nothing but two // We have found multiple Altium files with polygon records containing nothing but two
// coincident vertices. These polygons do not appear when opening the file in Altium. // coincident vertices. These polygons do not appear when opening the file in Altium.
// https://gitlab.com/kicad/code/kicad/-/issues/8183 // https://gitlab.com/kicad/code/kicad/-/issues/8183
// Also, polygons with less than 3 points are not supported in KiCad.
// //
// wxLogError( _( "Polygon has only %d point extracted from %ld vertices. At least 2 " // wxLogError( _( "Polygon has only %d point extracted from %ld vertices. At least 2 "
// "points are required." ), // "points are required." ),
@ -1889,11 +1890,12 @@ void ALTIUM_PCB::ConvertShapeBasedRegions6ToBoardItem( const AREGION6& aElem )
SHAPE_LINE_CHAIN linechain; SHAPE_LINE_CHAIN linechain;
HelperShapeLineChainFromAltiumVertices( linechain, aElem.outline ); HelperShapeLineChainFromAltiumVertices( linechain, aElem.outline );
if( linechain.PointCount() < 2 ) if( linechain.PointCount() < 3 )
{ {
// We have found multiple Altium files with polygon records containing nothing but // We have found multiple Altium files with polygon records containing nothing but
// two coincident vertices. These polygons do not appear when opening the file in // two coincident vertices. These polygons do not appear when opening the file in
// Altium. https://gitlab.com/kicad/code/kicad/-/issues/8183 // Altium. https://gitlab.com/kicad/code/kicad/-/issues/8183
// Also, polygons with less than 3 points are not supported in KiCad.
return; return;
} }
@ -1937,11 +1939,12 @@ void ALTIUM_PCB::ConvertShapeBasedRegions6ToFootprintItem( FOOTPRINT* aFoot
SHAPE_LINE_CHAIN linechain; SHAPE_LINE_CHAIN linechain;
HelperShapeLineChainFromAltiumVertices( linechain, aElem.outline ); HelperShapeLineChainFromAltiumVertices( linechain, aElem.outline );
if( linechain.PointCount() < 2 ) if( linechain.PointCount() < 3 )
{ {
// We have found multiple Altium files with polygon records containing nothing but // We have found multiple Altium files with polygon records containing nothing but
// two coincident vertices. These polygons do not appear when opening the file in // two coincident vertices. These polygons do not appear when opening the file in
// Altium. https://gitlab.com/kicad/code/kicad/-/issues/8183 // Altium. https://gitlab.com/kicad/code/kicad/-/issues/8183
// Also, polygons with less than 3 points are not supported in KiCad.
return; return;
} }
@ -1981,11 +1984,12 @@ void ALTIUM_PCB::ConvertShapeBasedRegions6ToBoardItemOnLayer( const AREGION6& aE
SHAPE_LINE_CHAIN linechain; SHAPE_LINE_CHAIN linechain;
HelperShapeLineChainFromAltiumVertices( linechain, aElem.outline ); HelperShapeLineChainFromAltiumVertices( linechain, aElem.outline );
if( linechain.PointCount() < 2 ) if( linechain.PointCount() < 3 )
{ {
// We have found multiple Altium files with polygon records containing nothing // We have found multiple Altium files with polygon records containing nothing
// but two coincident vertices. These polygons do not appear when opening the // but two coincident vertices. These polygons do not appear when opening the
// file in Altium. https://gitlab.com/kicad/code/kicad/-/issues/8183 // file in Altium. https://gitlab.com/kicad/code/kicad/-/issues/8183
// Also, polygons with less than 3 points are not supported in KiCad.
return; return;
} }
@ -2007,11 +2011,12 @@ void ALTIUM_PCB::ConvertShapeBasedRegions6ToFootprintItemOnLayer( FOOTPRINT*
SHAPE_LINE_CHAIN linechain; SHAPE_LINE_CHAIN linechain;
HelperShapeLineChainFromAltiumVertices( linechain, aElem.outline ); HelperShapeLineChainFromAltiumVertices( linechain, aElem.outline );
if( linechain.PointCount() < 2 ) if( linechain.PointCount() < 3 )
{ {
// We have found multiple Altium files with polygon records containing nothing // We have found multiple Altium files with polygon records containing nothing
// but two coincident vertices. These polygons do not appear when opening the // but two coincident vertices. These polygons do not appear when opening the
// file in Altium. https://gitlab.com/kicad/code/kicad/-/issues/8183 // file in Altium. https://gitlab.com/kicad/code/kicad/-/issues/8183
// Also, polygons with less than 3 points are not supported in KiCad.
return; return;
} }