haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

eemodern: fixed use-after-free in SCH_DRAWING_TOOLS::DrawSheet().

This commit is contained in:
Tomasz Włostowski 2019-05-23 00:28:51 +02:00
parent ac435ecd68
commit ecb81426a4
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
eeschema/tools/sch_drawing_tools.cpp
View File

@ -855,7 +855,6 @@ int SCH_DRAWING_TOOLS::DrawSheet( const TOOL_EVENT& aEvent )
sheet->SetScreen( NULL ); sheet->SetScreen( NULL );
sizeSheet( sheet, cursorPos ); sizeSheet( sheet, cursorPos );
m_selectionTool->AddItemToSel( sheet );
m_view->ClearPreview(); m_view->ClearPreview();
m_view->AddToPreview( sheet->Clone() ); m_view->AddToPreview( sheet->Clone() );
} }
@ -866,9 +865,14 @@ int SCH_DRAWING_TOOLS::DrawSheet( const TOOL_EVENT& aEvent )
m_view->ClearPreview(); m_view->ClearPreview();
if( m_frame->EditSheet( (SCH_SHEET*)sheet, g_CurrentSheet, nullptr ) ) if( m_frame->EditSheet( (SCH_SHEET*)sheet, g_CurrentSheet, nullptr ) )
{
m_frame->AddItemToScreenAndUndoList( sheet ); m_frame->AddItemToScreenAndUndoList( sheet );
else m_selectionTool->AddItemToSel( sheet );
}
else
{
delete sheet; delete sheet;
}
sheet = nullptr; sheet = nullptr;
} }