haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix -Wcatch-value in sexpr.cpp 

This is fixed by catching bty const-ref, rather than by value.

Also a few trailing space deletions.
This commit is contained in:
John Beard 2018-07-19 17:15:36 +01:00 committed by Wayne Stambaugh
parent e3cf2705de
commit f0c571769c
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
utils/kicad2step/sexpr/sexpr.cpp
View File

@ -43,7 +43,7 @@ namespace SEXPR
return &static_cast< SEXPR_LIST const * >(this)->m_children; return &static_cast< SEXPR_LIST const * >(this)->m_children;
} }
SEXPR* SEXPR::GetChild( size_t aIndex ) const SEXPR* SEXPR::GetChild( size_t aIndex ) const
{ {
if( m_type != SEXPR_TYPE::SEXPR_TYPE_LIST ) if( m_type != SEXPR_TYPE::SEXPR_TYPE_LIST )
@ -208,12 +208,12 @@ namespace SEXPR
m_children.clear(); m_children.clear();
} }
SEXPR_LIST& operator<< ( SEXPR_LIST& list, const ISEXPRABLE& obj ) SEXPR_LIST& operator<< ( SEXPR_LIST& list, const ISEXPRABLE& obj )
{ {
SEXPR* sobj = obj.SerializeSEXPR(); SEXPR* sobj = obj.SerializeSEXPR();
list.AddChild( sobj ); list.AddChild( sobj );
return list; return list;
} }
@ -252,7 +252,7 @@ namespace SEXPR
list.AddChild( obj ); list.AddChild( obj );
return list; return list;
} }
SEXPR_LIST& operator<< ( SEXPR_LIST& list, const _OUT_STRING setting ) SEXPR_LIST& operator<< ( SEXPR_LIST& list, const _OUT_STRING setting )
{ {
SEXPR *res; SEXPR *res;
@ -469,7 +469,7 @@ namespace SEXPR
throw std::invalid_argument( "unsupported argument type, this shouldn't have happened" ); throw std::invalid_argument( "unsupported argument type, this shouldn't have happened" );
} }
} }
catch( INVALID_TYPE_EXCEPTION ) catch( const INVALID_TYPE_EXCEPTION& )
{ {
return i; return i;
} }