haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix ENV_VAR_NAME_VALIDATOR typing characters backwards 

Fixes: lp:1798869
* https://bugs.launchpad.net/kicad/+bug/1798869
This commit is contained in:
Maciej Suminski 2018-10-22 15:03:55 +02:00
parent 7bba7a884a
commit f1b2855e80
2 changed files with 47 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
common/validators.cpp
View File

@ -168,15 +168,53 @@ void ENV_VAR_NAME_VALIDATOR::OnChar( wxKeyEvent& aEvent )
else if( wxIsalpha( c ) ) else if( wxIsalpha( c ) )
{ {
// Capitals only. // Capitals only.
// Note: changing the keyCode and/or uniChar in the event and passing it on
if( wxIslower( c ) )
{
// You may wonder why this scope is so twisted, so make yourself comfortable and read:
// 1. Changing the keyCode and/or uniChar in the event and passing it on
// doesn't work. Some platforms look at the original copy as long as the event // doesn't work. Some platforms look at the original copy as long as the event
// isn't vetoed. Insert the capitalized character by hand. // isn't vetoed.
wxString s( c, 1 ); // 2. Inserting characters by hand does not move the cursor, meaning either you insert
s = s.Capitalize(); // text backwards (lp:#1798869) or always append, no matter where is the cursor.
GetTextEntry()->WriteText( s ); // wxTextEntry::{Get/Set}InsertionPoint() do not work at all here.
// 3. There is wxTextEntry::ForceUpper(), but it is not yet available in common
// wxWidgets packages.
//
// So here we are, with a command event handler that converts
// the text to upper case upon every change.
wxTextCtrl* textCtrl = dynamic_cast<wxTextCtrl*>( GetTextEntry() );
if( textCtrl )
{
textCtrl->Connect( textCtrl->GetId(), wxEVT_COMMAND_TEXT_UPDATED,
(wxObjectEventFunction) &ENV_VAR_NAME_VALIDATOR::OnTextChanged );
}
}
aEvent.Skip();
} }
else else
{ {
wxBell(); wxBell();
} }
} }
void ENV_VAR_NAME_VALIDATOR::OnTextChanged( wxCommandEvent& event )
{
wxTextCtrl* textCtrl = dynamic_cast<wxTextCtrl*>( event.GetEventObject() );
if( textCtrl )
{
if( !textCtrl->IsModified() )
return;
long insertionPoint = textCtrl->GetInsertionPoint();
textCtrl->ChangeValue( textCtrl->GetValue().Upper() );
textCtrl->SetInsertionPoint( insertionPoint );
textCtrl->Disconnect( textCtrl->GetId(), wxEVT_COMMAND_TEXT_UPDATED );
}
event.Skip();
}

4
include/validators.h
View File

@ -107,7 +107,9 @@ public:
return new ENV_VAR_NAME_VALIDATOR( *this ); return new ENV_VAR_NAME_VALIDATOR( *this );
} }
void OnChar(wxKeyEvent& event); void OnChar( wxKeyEvent& event );
void OnTextChanged( wxCommandEvent& event );
}; };
#endif // #ifndef VALIDATORS_H #endif // #ifndef VALIDATORS_H