Eeschema: created a header for list operations

eeschema/block.cpp

@@ -47,21 +47,11 @@
 #include <sch_component.h>
 #include <sch_sheet.h>
 #include <sch_sheet_path.h>
-
+#include <list_operations.h>
-// Imported functions:
-extern void SetSchItemParent( SCH_ITEM* Struct, SCH_SCREEN* Screen );
-extern void MoveItemsInList( PICKED_ITEMS_LIST& aItemsList, const wxPoint aMoveVector );
-extern void RotateListOfItems( PICKED_ITEMS_LIST& aItemsList, wxPoint& Center );
-extern void MirrorX( PICKED_ITEMS_LIST& aItemsList, wxPoint& aMirrorPoint );
-extern void MirrorY( PICKED_ITEMS_LIST& aItemsList, wxPoint& Center );
-extern void DuplicateItemsInList( SCH_SCREEN*        screen,
-                                  PICKED_ITEMS_LIST& aItemsList,
-                                  const wxPoint      aMoveVector );
 
 static void DrawMovingBlockOutlines( EDA_DRAW_PANEL* aPanel, wxDC* aDC,
                                      const wxPoint& aPosition, bool aErase );
 
-
 int SCH_EDIT_FRAME::BlockCommand( EDA_KEY key )
 {
     int cmd = BLOCK_IDLE;

eeschema/list_operations.h

@@ -0,0 +1,73 @@
+/*
+ * This program source code file is part of KiCad, a free EDA CAD application.
+ *
+ * Copyright (C) 2017 KiCad Developers, see CHANGELOG.TXT for contributors.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation; either version 2
+ * of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, you may find one here:
+ * http://www.gnu.org/licenses/old-licenses/gpl-2.0.html
+ * or you may search the http://www.gnu.org website for the version 2 license,
+ * or you may write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
+ */
+
+#ifndef LIST_OPERATIONS_H
+#define LIST_OPERATIONS_H
+
+class wxPoint;
+class EDA_DRAW_PANEL;
+class SCH_ITEM;
+class SCH_SCREEN;
+class PICKED_ITEMS_LIST;
+
+void SetSchItemParent( SCH_ITEM* Struct, SCH_SCREEN* Screen );
+void RotateListOfItems( PICKED_ITEMS_LIST& aItemsList, const wxPoint& rotationPoint );
+void MirrorY( PICKED_ITEMS_LIST& aItemsList, const wxPoint& aMirrorPoint );
+void MirrorX( PICKED_ITEMS_LIST& aItemsList, const wxPoint& aMirrorPoint );
+
+/**
+ * Function MoveItemsInList
+ *  Move a list of items to a given move vector
+ * @param aItemsList = list of picked items
+ * @param aMoveVector = the move vector value
+ */
+void MoveItemsInList( PICKED_ITEMS_LIST& aItemsList, const wxPoint& aMoveVector );
+
+/**
+ * Function DeleteItemsInList
+ * delete schematic items in aItemsList
+ * deleted items are put in undo list
+ */
+void DeleteItemsInList( EDA_DRAW_PANEL* panel, PICKED_ITEMS_LIST& aItemsList );
+
+/**
+ * Routine to copy a new entity of an object for each object in list and
+ * reposition it.
+ * Return the new created object list in aItemsList
+ */
+void DuplicateItemsInList( SCH_SCREEN* screen, PICKED_ITEMS_LIST& aItemsList,
+                           const wxPoint& aMoveVector );
+
+/**
+ * Routine to create a new copy of given struct.
+ * The new object is not put in draw list (not linked)
+ *
+ * @param aDrawStruct = the SCH_ITEM to duplicate
+ * @param aClone (default = false)
+ *     if true duplicate also some parameters that must be unique
+ *     (timestamp and sheet name)
+ *      aClone must be false. use true only is undo/redo duplications
+ */
+SCH_ITEM* DuplicateStruct( SCH_ITEM* aDrawStruct, bool aClone );
+
+#endif /* LIST_OPERATIONS_H */

eeschema/operations_on_items_lists.cpp

@@ -72,7 +72,7 @@ void SetSchItemParent( SCH_ITEM* Struct, SCH_SCREEN* Screen )
 }
 
 
-void RotateListOfItems( PICKED_ITEMS_LIST& aItemsList, wxPoint& rotationPoint )
+void RotateListOfItems( PICKED_ITEMS_LIST& aItemsList, const wxPoint& rotationPoint )
 {
     for( unsigned ii = 0; ii < aItemsList.GetCount(); ii++ )
     {
@@ -83,7 +83,7 @@ void RotateListOfItems( PICKED_ITEMS_LIST& aItemsList, wxPoint& rotationPoint )
 }
 
 
-void MirrorY( PICKED_ITEMS_LIST& aItemsList, wxPoint& aMirrorPoint )
+void MirrorY( PICKED_ITEMS_LIST& aItemsList, const wxPoint& aMirrorPoint )
 {
     for( unsigned ii = 0; ii < aItemsList.GetCount(); ii++ )
     {
@@ -94,7 +94,7 @@ void MirrorY( PICKED_ITEMS_LIST& aItemsList, wxPoint& aMirrorPoint )
 }
 
 
-void MirrorX( PICKED_ITEMS_LIST& aItemsList, wxPoint& aMirrorPoint )
+void MirrorX( PICKED_ITEMS_LIST& aItemsList, const wxPoint& aMirrorPoint )
 {
     for( unsigned ii = 0; ii < aItemsList.GetCount(); ii++ )
     {
@@ -105,13 +105,7 @@ void MirrorX( PICKED_ITEMS_LIST& aItemsList, wxPoint& aMirrorPoint )
 }
 
 
-/**
+void MoveItemsInList( PICKED_ITEMS_LIST& aItemsList, const wxPoint& aMoveVector )
- * Function MoveItemsInList
- *  Move a list of items to a given move vector
- * @param aItemsList = list of picked items
- * @param aMoveVector = the move vector value
- */
-void MoveItemsInList( PICKED_ITEMS_LIST& aItemsList, const wxPoint aMoveVector )
 {
     for( unsigned ii = 0; ii < aItemsList.GetCount(); ii++ )
     {
@@ -121,11 +115,6 @@ void MoveItemsInList( PICKED_ITEMS_LIST& aItemsList, const wxPoint aMoveVector )
 }
 
 
-/**
- * Function DeleteItemsInList
- * delete schematic items in aItemsList
- * deleted items are put in undo list
- */
 void DeleteItemsInList( EDA_DRAW_PANEL* panel, PICKED_ITEMS_LIST& aItemsList )
 {
     SCH_SCREEN*        screen = (SCH_SCREEN*) panel->GetScreen();
@@ -182,12 +171,8 @@ void SCH_EDIT_FRAME::DeleteItem( SCH_ITEM* aItem )
 }
 
 
-/* Routine to copy a new entity of an object for each object in list and
- * reposition it.
- * Return the new created object list in aItemsList
- */
 void DuplicateItemsInList( SCH_SCREEN* screen, PICKED_ITEMS_LIST& aItemsList,
-                           const wxPoint aMoveVector )
+                           const wxPoint& aMoveVector )
 {
     SCH_ITEM* newitem;
 
@@ -238,16 +223,6 @@ void DuplicateItemsInList( SCH_SCREEN* screen, PICKED_ITEMS_LIST& aItemsList,
 }
 
 
-/**
- * Function DuplicateStruct
- *  Routine to create a new copy of given struct.
- *  The new object is not put in draw list (not linked)
- * @param aDrawStruct = the SCH_ITEM to duplicate
- * @param aClone (default = false)
- *     if true duplicate also some parameters that must be unique
- *     (timestamp and sheet name)
- *      aClone must be false. use true only is undo/redo duplications
- */
 SCH_ITEM* DuplicateStruct( SCH_ITEM* aDrawStruct, bool aClone )
 {
     wxCHECK_MSG( aDrawStruct != NULL, NULL,