haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Quiet clang getting its knickers in a knot over case fallthroughs.

This commit is contained in:
Jeff Young 2022-11-13 23:01:48 +00:00
parent 9d8fdd8d53
commit f4944f0db3
1 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
pcbnew/exporters/step/exporter_step.cpp
View File

@ -3,7 +3,7 @@
* *
* Copyright (C) 2022 Mark Roszko <mark.roszko@gmail.com> * Copyright (C) 2022 Mark Roszko <mark.roszko@gmail.com>
* Copyright (C) 2016 Cirilo Bernardo <cirilo.bernardo@gmail.com> * Copyright (C) 2016 Cirilo Bernardo <cirilo.bernardo@gmail.com>
* Copyright (C) 2016-2021 KiCad Developers, see AUTHORS.txt for contributors. * Copyright (C) 2016-2022 KiCad Developers, see AUTHORS.txt for contributors.
* *
* This program is free software; you can redistribute it and/or * This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License * modify it under the terms of the GNU General Public License
@ -149,8 +149,7 @@ bool EXPORTER_STEP::composePCB( FOOTPRINT* aFootprint, VECTOR2D aOrigin )
{ {
// FindRow() can throw an exception // FindRow() can throw an exception
const FP_LIB_TABLE_ROW* fpRow = const FP_LIB_TABLE_ROW* fpRow =
m_board->GetProject()->PcbFootprintLibs()->FindRow( m_board->GetProject()->PcbFootprintLibs()->FindRow( libraryName, false );
libraryName, false );
if( fpRow ) if( fpRow )
footprintBasePath = fpRow->GetFullURI( true ); footprintBasePath = fpRow->GetFullURI( true );
@ -290,13 +289,18 @@ void EXPORTER_STEP::determinePcbThickness()
{ {
switch( item->GetType() ) switch( item->GetType() )
{ {
case BS_ITEM_TYPE_DIELECTRIC: thickness += item->GetThickness(); break; case BS_ITEM_TYPE_DIELECTRIC:
thickness += item->GetThickness();
break;
case BS_ITEM_TYPE_COPPER: case BS_ITEM_TYPE_COPPER:
if( item->IsEnabled() ) if( item->IsEnabled() )
thickness += item->GetThickness(); thickness += item->GetThickness();
default: break; break;
default:
break;
} }
} }
@ -317,6 +321,7 @@ bool EXPORTER_STEP::Export()
try try
{ {
ReportMessage( _( "Build STEP data\n" ) ); ReportMessage( _( "Build STEP data\n" ) );
if( !composePCB() ) if( !composePCB() )
{ {
ReportMessage( _( "\n** Error building STEP board model. Export aborted. **\n" ) ); ReportMessage( _( "\n** Error building STEP board model. Export aborted. **\n" ) );
@ -324,6 +329,7 @@ bool EXPORTER_STEP::Export()
} }
ReportMessage( _( "Writing STEP file\n" ) ); ReportMessage( _( "Writing STEP file\n" ) );
if( !m_pcbModel->WriteSTEP( m_outputFile ) ) if( !m_pcbModel->WriteSTEP( m_outputFile ) )
{ {
ReportMessage( _( "\n** Error writing STEP file. **\n" ) ); ReportMessage( _( "\n** Error writing STEP file. **\n" ) );