Minor code cleanup, step2: remove more useless include.

fix also a minor compil warning

common/common.cpp

@@ -23,7 +23,6 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
  */
 
-#include <fctsys.h>
 #include <eda_base_frame.h>
 #include <project.h>
 #include <common.h>
@@ -39,8 +38,6 @@
 #include <boost/uuid/uuid_io.hpp>
 #include <boost/functional/hash.hpp>
 
-using KIGFX::COLOR4D;
-
 
 // Create only once, as seeding is *very* expensive
 static boost::uuids::random_generator randomGenerator;

common/plugins/cadstar/cadstar_archive_parser.h

@@ -29,7 +29,7 @@
 #include <dsnlexer.h>
 #include <macros.h>
 #include <vector>
-#include <wx/wx.h>
+#include <wx/log.h>
 #include <wx/xml/xml.h>
 #include <xnode.h>
 

eeschema/dialogs/dialog_plot_schematic.h

@@ -27,7 +27,6 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
  */
 
-#include <fctsys.h>
 #include <plotter.h>
 #include <sch_screen.h>
 #include <sch_edit_frame.h>

include/common.h

@@ -41,7 +41,6 @@
 #include <wx/dir.h>
 
 #include <richio.h>
-#include <gal/color4d.h>
 
 #include <atomic>
 #include <limits>

include/eda_base_frame.h

@@ -41,8 +41,6 @@
 #include <wx/aui/aui.h>
 #include <wx/docview.h>
 #include <wx/event.h>
-#include <fctsys.h>
-#include <common.h>
 #include <layers_id_colors_and_visibility.h>
 #include <frame_type.h>
 #include <hotkeys_basic.h>

include/tool/tools_holder.h

@@ -25,8 +25,6 @@
 #define  TOOL_HOLDER_H
 
 #include <vector>
-#include <fctsys.h>
-#include <common.h>
 #include <tool/action_manager.h>
 #include <tool/selection.h>
 #include <tool/tool_action.h>

pcbnew/board_stackup_manager/stackup_predefined_prms.h

@@ -31,6 +31,9 @@
 
 
 #include <wx/string.h>
+#include <wx/arrstr.h>
+#include <wx/colour.h>
+
 #include <layers_id_colors_and_visibility.h>
 #include <i18n_utility.h>       // For _HKI definition
 

pcbnew/drc/drc_test_provider_matched_length.cpp

@@ -109,7 +109,8 @@ void test::DRC_TEST_PROVIDER_MATCHED_LENGTH::checkLengthViolations(
     {
         bool minViolation = false;
         bool maxViolation = false;
-        int  minLen, maxLen;
+        int  minLen = 0;
+        int  maxLen = 0;
 
         if( aConstraint.GetValue().HasMin() && ent.total < aConstraint.GetValue().Min() )
         {

pcbnew/netlist_reader/netlist_reader.h

@@ -32,7 +32,6 @@
 
 #include <boost/ptr_container/ptr_vector.hpp>
 
-#include <fctsys.h>
 #include <macros.h>
 #include <lib_id.h>
 

qa/pcbnew/test_libeval_compiler.cpp

@@ -21,6 +21,8 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
  */
 
+#include <wx/wx.h>
+
 #include <unit_test_utils/unit_test_utils.h>
 
 #include <layers_id_colors_and_visibility.h>