haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

CADSTAR PCB: Fix loading of thermal relief gap in zones 

We were loading as solid fill when the relief gap was exactly the
same as the minimum width.

Also we can do better than just load as solid fill when it is smaller:
we can instead just use the minimum width and at least it still will
have thermal reliefs.
This commit is contained in:
Roberto Fernandez Bautista 2021-10-08 17:32:58 +01:00
parent c14bdf7fe0
commit fb588da875
1 changed files with 16 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
pcbnew/plugins/cadstar/cadstar_pcb_archive_loader.cpp
View File

@ -1879,24 +1879,29 @@ void CADSTAR_PCB_ARCHIVE_LOADER::loadTemplates()
// Cadstar supports having a spoke width thinner than the minimum thickness of the zone, but
// this is not permitted in KiCad. We load it as solid fill instead.
if( csTemplate.Pouring.ThermalReliefOnPads && reliefWidth > 0 && spokeWidth > minThickness )
if( csTemplate.Pouring.ThermalReliefOnPads && reliefWidth > 0 )
{
if( spokeWidth < minThickness )
{
wxLogWarning( wxString::Format(
_( "The CADSTAR template '%s' has thermal reliefs in the original design "
"but the spoke width (%.2f mm) is thinner than the minimum thickness of "
"the zone (%.2f mm). KiCad requires the minimum thickness of the zone "
"to be preserved. Therefore the minimum thickness has been applied as "
"the new spoke width and will be applied next time the zones are "
"filled." ),
csTemplate.Name, (double) getKiCadLength( spokeWidth ) / 1E6,
(double) getKiCadLength( minThickness ) / 1E6 ) );
spokeWidth = minThickness;
}
zone->SetThermalReliefGap( reliefWidth );
zone->SetThermalReliefSpokeWidth( spokeWidth );
zone->SetPadConnection( ZONE_CONNECTION::THERMAL );
}
else
{
if( csTemplate.Pouring.ThermalReliefOnPads && spokeWidth > minThickness )
{
wxLogWarning( wxString::Format(
_( "The CADSTAR template '%s' has thermal reliefs in the original design "
"but there is no KiCad equivalent to the original CADSTAR settings. "
"Solid fill has been applied instead. When the template is re-filled "
"the thermal reliefs will be removed." ),
csTemplate.Name ) );
}
zone->SetPadConnection( ZONE_CONNECTION::FULL );
}