haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Eeschema: fix resizing of pin table and edit symbol dialog 

These dialogs had logic to avoid a table re-adjustment unless
the width changed. This was done to avoid spurious resizing
calls under GTK+3. This was commit
13249b723b, fixing bug lp:1817810.

However, by only calling event.Skip() when the width changed,
redraws were inhibited when only the height changed.

Placing the Skip() outside the width-change check fixes this,
and does not re-introduce the lp:1817810 bug (it is the column
adjust call that causes that).

Fixes: lp:1826615
* https://bugs.launchpad.net/kicad/+bug/1826615

(cherry picked from commit eccadd92fb)
This commit is contained in:
John Beard 2019-04-27 13:50:21 +01:00
parent 20c8b094d6
commit fc933034db
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
eeschema/dialogs/dialog_edit_component_in_schematic.cpp
View File

@ -722,8 +722,10 @@ void DIALOG_EDIT_COMPONENT_IN_SCHEMATIC::OnSizeGrid( wxSizeEvent& event )
if( m_width != new_size )
{
AdjustGridColumns( new_size );
event.Skip();
}
// Always propagate for a grid repaint (needed if the height changes, as well as width)
event.Skip();
}

4
eeschema/dialogs/dialog_lib_edit_pin_table.cpp
View File

@ -628,8 +628,10 @@ void DIALOG_LIB_EDIT_PIN_TABLE::OnSize( wxSizeEvent& event )
if( m_initialized && m_width != new_size )
{
adjustGridColumns( new_size );
event.Skip();
}
// Always propagate for a grid repaint (needed if the height changes, as well as width)
event.Skip();
}