haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Do not call SafeYield on close 

wxSafeYield() is not "safe".  Pending actions may include deletion of
the currently active class.  This will cause crashes when exiting.  If
needed for specific behaviors, we should use wxSafeYieldFor( flag ) with
the appropriate events specified rather than a general yield which can
cause more problems

(cherry picked from commit 9864337914)
This commit is contained in:
Seth Hillbrand 2022-01-06 12:31:59 -08:00
parent 4f874057ab
commit fd9d923bb7
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
kicad/kicad_manager_frame.cpp
View File

@ -410,9 +410,6 @@ bool KICAD_MANAGER_FRAME::CloseProject( bool aSave )
if( !Kiway().PlayersClose( false ) ) if( !Kiway().PlayersClose( false ) )
return false; return false;
// Give a timeslice for the save-changes? dialog (and for the project to actually close)
wxSafeYield();
// Save the project file for the currently loaded project. // Save the project file for the currently loaded project.
if( m_active_project ) if( m_active_project )
{ {