haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ADDED: Allow stacked pins of the same type 

Removes the need for the "KiCad" workaround where stacked pins need
to be "Passive" type.  Pins that have the same parent symbol, name,
position and type are considered to be the same output and do not
trigger ERC errors

Fixes https://gitlab.com/kicad/code/kicad/issues/5367
This commit is contained in:
Seth Hillbrand 2022-07-30 13:10:14 -07:00
parent ee1d458af0
commit fe3a112396
1 changed files with 16 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
eeschema/erc.cpp
View File

@ -516,14 +516,25 @@ int ERC_TESTER::TestPinToPin()
if( testPin == refPin )
continue;
std::pair<SCH_PIN*, SCH_PIN*> pair1 = std::make_pair( refPin, testPin );
std::pair<SCH_PIN*, SCH_PIN*> pair2 = std::make_pair( testPin, refPin );
SCH_PIN* first_pin = refPin;
SCH_PIN* second_pin = testPin;
if( tested.count( pair1 ) || tested.count( pair2 ) )
if( first_pin > second_pin )
std::swap( first_pin, second_pin );
std::pair<SCH_PIN*, SCH_PIN*> pair = std::make_pair( first_pin, second_pin );
if( auto [ins_pin, inserted ] = tested.insert( pair ); !inserted )
continue;
tested.insert( pair1 );
tested.insert( pair2 );
// Multiple pins in the same symbol that share a type,
// name and position are considered
// "stacked" and shouldn't trigger ERC errors
if( refPin->GetParent() == testPin->GetParent() &&
refPin->GetPosition() == testPin->GetPosition() &&
refPin->GetName() == testPin->GetName() &&
refPin->GetType() == testPin->GetType() )
continue;
ELECTRICAL_PINTYPE testType = testPin->GetType();