haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Preserve the externally defined variables in the configure paths dialog 

Previously the variables that were defined externally weren't being
readded to the variable map, so they would not appear in the dialog
the next time.
This commit is contained in:
Ian McInerney 2020-08-12 00:25:58 +01:00
parent 47f7c616f8
commit fedc6519cd
1 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
common/dialogs/dialog_configure_paths.cpp
View File

@ -223,14 +223,17 @@ bool DIALOG_CONFIGURE_PATHS::TransferDataFromWindow()
for( int row = 0; row < m_EnvVars->GetNumberRows(); ++row ) for( int row = 0; row < m_EnvVars->GetNumberRows(); ++row )
{ {
wxString name = m_EnvVars->GetCellValue( row, TV_NAME_COL ); wxString name = m_EnvVars->GetCellValue( row, TV_NAME_COL );
wxString path = m_EnvVars->GetCellValue( row, TV_VALUE_COL ); wxString path = m_EnvVars->GetCellValue( row, TV_VALUE_COL );
wxString external = m_EnvVars->GetCellValue( row, TV_FLAG_COL ); wxString external = m_EnvVars->GetCellValue( row, TV_FLAG_COL );
ENV_VAR_ITEM var( path );
if( external.Length() ) if( external.Length() )
continue; {
// Don't check for consistency on external variables, just use them as-is
if( name.IsEmpty() ) var.SetDefinedExternally( true );
}
else if( name.IsEmpty() )
{ {
m_errorGrid = m_EnvVars; m_errorGrid = m_EnvVars;
m_errorRow = row; m_errorRow = row;
@ -247,7 +250,7 @@ bool DIALOG_CONFIGURE_PATHS::TransferDataFromWindow()
return false; return false;
} }
envVarMap[ name ] = ENV_VAR_ITEM( path ); envVarMap[ name ] = var;
} }
Pgm().SetLocalEnvVariables( envVarMap ); Pgm().SetLocalEnvVariables( envVarMap );