Fix Coverity "Big parameter passed by value" warnings.

Fixes Coverity CIDs:

- 175846
- 175841
- 175840
- 175837
- 175836
- 175834
- 102524
This commit is contained in:
Wayne Stambaugh 2018-06-04 12:30:00 -04:00
parent 63a952d239
commit ff1802d7a1
4 changed files with 12 additions and 11 deletions

View File

@ -2,7 +2,7 @@
* This program source code file is part of KiCad, a free EDA CAD application. * This program source code file is part of KiCad, a free EDA CAD application.
* *
* Copyright (C) 2012 Brian Sidebotham <brian.sidebotham@gmail.com> * Copyright (C) 2012 Brian Sidebotham <brian.sidebotham@gmail.com>
* Copyright (C) 1992-2012 KiCad Developers, see AUTHORS.txt for contributors. * Copyright (C) 1992-2018 KiCad Developers, see AUTHORS.txt for contributors.
* *
* This program is free software; you can redistribute it and/or * This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License * modify it under the terms of the GNU General Public License
@ -106,7 +106,7 @@ public:
private: private:
void SetHtml( wxFileName aFilename ) void SetHtml( const wxFileName& aFilename )
{ {
m_htmlWin->LoadPage( aFilename.GetFullPath() ); m_htmlWin->LoadPage( aFilename.GetFullPath() );
} }

View File

@ -1,7 +1,7 @@
/* /*
* This program source code file is part of KiCad, a free EDA CAD application. * This program source code file is part of KiCad, a free EDA CAD application.
* *
* Copyright (C) 2017 KiCad Developers, see AUTHORS.txt for contributors. * Copyright (C) 2017-2018 KiCad Developers, see AUTHORS.txt for contributors.
* @author Russell Oliver <roliver8143@gmail.com> * @author Russell Oliver <roliver8143@gmail.com>
* *
* This program is free software; you can redistribute it and/or * This program is free software; you can redistribute it and/or
@ -130,7 +130,7 @@ void KICAD_MANAGER_FRAME::OnImportEagleFiles( wxCommandEvent& event )
{ {
schframe = Kiway.Player( FRAME_SCH, true ); schframe = Kiway.Player( FRAME_SCH, true );
} }
catch( IO_ERROR err ) catch( const IO_ERROR& err )
{ {
wxMessageBox( _( "Eeschema failed to load:\n" ) + err.What(), wxMessageBox( _( "Eeschema failed to load:\n" ) + err.What(),
_( "KiCad Error" ), wxOK | wxICON_ERROR, this ); _( "KiCad Error" ), wxOK | wxICON_ERROR, this );
@ -139,7 +139,8 @@ void KICAD_MANAGER_FRAME::OnImportEagleFiles( wxCommandEvent& event )
} }
schframe->Kiway().ExpressMail( FRAME_SCH, MAIL_IMPORT_FILE, schframe->Kiway().ExpressMail( FRAME_SCH, MAIL_IMPORT_FILE,
wxString::Format( "%d\n%s", SCH_IO_MGR::SCH_EAGLE, sch.GetFullPath() ).ToStdString(), this ); wxString::Format( "%d\n%s", SCH_IO_MGR::SCH_EAGLE,
sch.GetFullPath() ).ToStdString(), this );
if( !schframe->IsShown() ) // the frame exists, (created by the dialog field editor) if( !schframe->IsShown() ) // the frame exists, (created by the dialog field editor)
// but no project loaded. // but no project loaded.

View File

@ -3,7 +3,7 @@
* *
* Copyright (C) 2017 Jean-Pierre Charras, jp.charras at wanadoo.fr * Copyright (C) 2017 Jean-Pierre Charras, jp.charras at wanadoo.fr
* Copyright (C) 2013 CERN (www.cern.ch) * Copyright (C) 2013 CERN (www.cern.ch)
* Copyright (C) 2004-2017 KiCad Developers, see change_log.txt for contributors. * Copyright (C) 2004-2018 KiCad Developers, see change_log.txt for contributors.
* *
* This program is free software; you can redistribute it and/or * This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License * modify it under the terms of the GNU General Public License
@ -311,7 +311,7 @@ void KICAD_MANAGER_FRAME::RunEeschema( const wxString& aProjectSchematicFileName
{ {
frame = Kiway.Player( FRAME_SCH, true ); frame = Kiway.Player( FRAME_SCH, true );
} }
catch( IO_ERROR err ) catch( const IO_ERROR& err )
{ {
wxMessageBox( _( "Eeschema failed to load:\n" ) + err.What(), wxMessageBox( _( "Eeschema failed to load:\n" ) + err.What(),
_( "KiCad Error" ), wxOK | wxICON_ERROR, this ); _( "KiCad Error" ), wxOK | wxICON_ERROR, this );
@ -358,7 +358,7 @@ void KICAD_MANAGER_FRAME::OnRunSchLibEditor( wxCommandEvent& event )
{ {
frame = Kiway.Player( FRAME_SCH_LIB_EDITOR, true ); frame = Kiway.Player( FRAME_SCH_LIB_EDITOR, true );
} }
catch( IO_ERROR err ) catch( const IO_ERROR& err )
{ {
wxMessageBox( _( "Component library editor failed to load:\n" ) + err.What(), wxMessageBox( _( "Component library editor failed to load:\n" ) + err.What(),
_( "KiCad Error" ), wxOK | wxICON_ERROR, this ); _( "KiCad Error" ), wxOK | wxICON_ERROR, this );
@ -384,7 +384,7 @@ void KICAD_MANAGER_FRAME::RunPcbNew( const wxString& aProjectBoardFileName )
{ {
frame = Kiway.Player( FRAME_PCB, true ); frame = Kiway.Player( FRAME_PCB, true );
} }
catch( IO_ERROR err ) catch( const IO_ERROR& err )
{ {
wxMessageBox( _( "Pcbnew failed to load:\n" ) + err.What(), _( "KiCad Error" ), wxMessageBox( _( "Pcbnew failed to load:\n" ) + err.What(), _( "KiCad Error" ),
wxOK | wxICON_ERROR, this ); wxOK | wxICON_ERROR, this );
@ -430,7 +430,7 @@ void KICAD_MANAGER_FRAME::OnRunPcbFpEditor( wxCommandEvent& event )
{ {
frame = Kiway.Player( FRAME_PCB_MODULE_EDITOR, true ); frame = Kiway.Player( FRAME_PCB_MODULE_EDITOR, true );
} }
catch( IO_ERROR err ) catch( const IO_ERROR& err )
{ {
wxMessageBox( _( "Footprint library editor failed to load:\n" ) + err.What(), wxMessageBox( _( "Footprint library editor failed to load:\n" ) + err.What(),
_( "KiCad Error" ), wxOK | wxICON_ERROR, this ); _( "KiCad Error" ), wxOK | wxICON_ERROR, this );

View File

@ -647,7 +647,7 @@ public:
} }
} }
void addVertex( DRW_Vertex v ) void addVertex( const DRW_Vertex& v )
{ {
DRW_Vertex* vert = new DRW_Vertex(); DRW_Vertex* vert = new DRW_Vertex();