haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert "Remove UpdatePins call from connectivity calculation" 

This reverts commit b351e70d13.

Causes crashes on entering subsheets; don't have time to debug yet
This commit is contained in:
Jon Evans 2019-04-22 23:31:11 -04:00
parent 782b8227fa
commit ff6a8cd537
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
eeschema/connection_graph.cpp
View File

@ -435,13 +435,10 @@ void CONNECTION_GRAPH::updateItemConnectivity( SCH_SHEET_PATH aSheet,
SCH_COMPONENT* component = static_cast<SCH_COMPONENT*>( item ); SCH_COMPONENT* component = static_cast<SCH_COMPONENT*>( item );
TRANSFORM t = component->GetTransform(); TRANSFORM t = component->GetTransform();
// Assumption: we don't need to call UpdatePins() here because anything component->UpdatePins( &aSheet );
// that would change the pins of the component will have called it already
for( SCH_PIN& pin : component->GetPins() ) for( SCH_PIN& pin : component->GetPins() )
{ {
pin.InitializeConnection( aSheet );
wxPoint pos = t.TransformCoordinate( pin.GetPosition() ) + component->GetPosition(); wxPoint pos = t.TransformCoordinate( pin.GetPosition() ) + component->GetPosition();
// because calling the first time is not thread-safe // because calling the first time is not thread-safe