080cbbe0dd
Error reporting for drawing sheet loading.
2024-06-24 20:22:29 +01:00
26b86b3922
Don't use wxLogMessage/wxLogError for messages not meant for user.
...
They are particularly damaging when our event loop
gets tied up in knots with the log message window
behind a modal window -- thereby locking up KiCad.
2024-06-24 20:22:29 +01:00
11c6164934
Silence font replace warnings for libs
...
When loading schematics/pcbs, notification of font replacements might be
warranted but in libraries, this warning is not helpful and intrusive
2024-06-24 09:55:10 -07:00
561106bd01
Formatting.
2024-06-24 14:14:03 +01:00
968ef0082d
Handle undo of a Repeat Draw Item.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18261
2024-06-24 13:59:05 +01:00
0b4d0bcb6c
Undo for Repeat Pin.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18261
2024-06-24 13:59:05 +01:00
69ee94f289
Fix crash when trying to draw a schematic polygon with no segments.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18246
2024-06-23 07:02:43 +03:00
3e480b6f6e
Improve error message when trying to Open non-KiCad schematic files.
...
See https://gitlab.com/kicad/code/kicad/-/issues/18241
(cherry picked from commit d319cd4b89
2024-06-22 17:35:57 +00:00
4ee1415164
Fix Eagle schematic importer incorrect symbol value field and visibility.
...
Also fix a crash if an XML_PARSER_ERROR exception is thrown when importing
Eagle symbol libraries.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18232
(cherry picked from commit 566fefafc5
2024-06-22 12:32:47 -04:00
4e3488c2e0
Altium schematic import: fix power port styles.
...
Need to use the symbol name with style, like "VCC_CIRCLE", not "VCC".
Issue was introduced in d939004bbdhttps://gitlab.com/kicad/code/kicad/-/issues/18209
2024-06-22 06:45:26 +03:00
f6994702aa
Fix arc edit points ordering in schematic.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18254
2024-06-22 06:17:00 +03:00
0ed72fb47a
Fix broken rectangles in Eagle schematic importer.
2024-06-21 16:18:42 -04:00
1613816e77
Fix EasyEDA/JLCEDA Pro 2.2 footprint/symbol library import.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18250
2024-06-21 22:20:54 +03:00
c549a214c9
Performance: don't alloc std::vector in critical areas.
...
For some history, see also aa2ad3b44c
2024-06-21 19:07:46 +01:00
b494166b10
Fix empty label names when importing Eagle schematic.
2024-06-21 12:07:06 -04:00
ece46223c9
Fix shadowed/conflicting enum values.
2024-06-21 16:16:29 +03:00
904055912b
Fix attribute display comparison in EAGLE schematic import.
2024-06-21 16:16:24 +03:00
8df28d4f5f
Fix crash in symbol editor when importing Eagle symbol library.
...
https://gitlab.com/kicad/code/kicad/-/issues/18221
2024-06-21 01:07:01 -04:00
31ab276aaf
Ease-of-use for un-commented ERC/DRC exclusions.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18220
2024-06-19 17:07:50 +01:00
251ed2ee54
Formatting and "auto" reduction.
2024-06-19 12:39:22 +01:00
bcf6b620a8
Large rework of BEZIER_POLY
...
Add direct handling of quadratic beziers to save compute time and number
of points. Update cubic interpolation to reduce number of points
generated for a given smoothness
Cache data on open and used cached data to avoid multiple re-calcs
Remove minimum line length and number of segments and replace with
standard max error level. Allows us to specify the tolerance of bezier
interpolation
2024-06-18 17:55:41 -07:00
16e708a0e7
Fix minor compil and Coverity warnings.
2024-06-15 11:20:21 +02:00
0f8d543172
Consistent capitalization.
2024-06-14 22:02:08 +01:00
ac576d7e0a
Normalize phase angles.
2024-06-14 19:03:55 +01:00
a2cbd1ff21
Fix QA tests compatibility
2024-06-14 19:14:09 +02:00
c633ac26eb
Don't lose value of cursor checkboxes when running sim.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18205
2024-06-14 16:37:49 +01:00
4eb048bba2
Don't assume AC gains will always be voltages.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18205
2024-06-14 16:37:49 +01:00
300313ce73
Correctly write phase/gain signals to workbook.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18205
2024-06-14 16:37:49 +01:00
5a3bad51d0
Don't use SI prefixes with degrees when auto-ranging.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18205
2024-06-14 16:37:49 +01:00
7b63429fe1
Current gain is the first Y axis, not the second.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18205
2024-06-14 16:37:49 +01:00
d778cb6647
Schematic editor: fix some issues that can crash the editor on closing.
...
- Add a test to be sure a SCHEMATIC exists before trying to use it
- Delete items in Repeat list and undo/redo list before deleting the schematic
- Delete also these items when loading a new schematic (the repeat list was
not cleaned previously)
Before these fixes I see a use after delete issue due to dangling pointers
stored in Repeat list.
2024-06-14 16:57:57 +02:00
a5e2615251
Revert "SCH/LIB SYMBOL: never allow null LIB_SYMBOLs in SCH_SYMBOL"
...
This reverts commit 0b187e7122
2024-06-12 13:30:29 -04:00
0c45f85bc0
Revert "sch_symbol: use fail message fall back to dummy symbol when passed null"
...
This reverts commit e0e837189d
2024-06-12 13:30:29 -04:00
b7161181e8
Hidden footprint libraries are not yet supported.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18183
2024-06-12 16:59:20 +01:00
2a37580839
Symbol editor: ensure the left panel is correctly refreshed when hiding a pane.
2024-06-11 17:48:25 +02:00
74070afbc6
Fix a bunch of GCC build warnings compiling the schematic editor.
...
Apparently GCC does not like competing definitions of the == operator.
The recent refactoring away of all LIB_ITEM objects created a conflict
with the SCH_ITEM == operator definition. This change required some
rather ugly comparison changes. There were no unit test failures but
that doesn't mean something didn't get broken.
2024-06-11 08:07:32 -04:00
439c25fca9
Altium schematic parser: Add fraction pin placement
...
In the schematic libaries, pin positions that are off 10mil spacing need
fractional elements stored in a different location
2024-06-10 15:02:18 -07:00
35d60598d5
Fix build error on MSVC.
2024-06-11 00:06:32 +03:00
1325701956
Altium SCH Lib updates
...
- Use pin-compatible line widths for symbols
- Handle circular arcs as circles, not elliptical arcs
2024-06-10 12:40:01 -07:00
de2fbbd11a
Fix stack address escaping routine.
2024-06-10 20:23:36 +01:00
4e133ae83b
Cleanup.
2024-06-10 20:23:36 +01:00
a02cb75656
Cleanup.
2024-06-10 20:23:36 +01:00
0826c10a20
Don't re-add deleted netclass assignments in incremental connectivity
...
Ensures that if moving or deleting a netclass directive label, the
netclass on the previously-assigned net doesn't have the stale
netclass re-applied.
2024-06-10 20:19:07 +01:00
5e048bc64c
Fix several Eagle schematic import issues.
...
Fix broken arc angle polarity due to library symbol changes.
Fix broken wire and text Y axis coordinate polarity due to library symbol
changes.
Fix broken field visibility and position on library symbols with multiple
units that have fields with different visibility and positions. Because
KiCad does not support this, when parsing the Eagle schematic file, the
last library symbol unit parsed ends up being the field visibility and
position for all units in the symbol.
2024-06-10 11:28:20 -04:00
889931505b
Eagle schematic importer improvements.
...
Change Eagle file importer to use a two pass import. The first pass
parses the entire Eagle file into an associated E* object. The second
pass converts the parsed E* objects into the appropriate KiCad objects.
Improve handling of Eagle versioned libraries.
Add helpers to IO_BASE to ease handling of PROGRESS_REPORTER and REPORTER
objects.
ADDED: Support for importing Eagle schematic modules.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/1813
2024-06-10 11:28:20 -04:00
e0e837189d
sch_symbol: use fail message fall back to dummy symbol when passed null
2024-06-10 11:24:58 -04:00
2e38fa84bf
Don't allow writing "//" to spice netlist.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18161
2024-06-10 15:36:20 +01:00
0b187e7122
SCH/LIB SYMBOL: never allow null LIB_SYMBOLs in SCH_SYMBOL
...
Also always always flatten incoming lib symbols.
2024-06-10 08:36:42 -04:00
ed0869aa0c
Share more library tree code.
2024-06-08 19:06:10 +01:00
cb7d51dbe4
Formatting.
2024-06-07 12:10:41 +01:00
Jeff Young
Seth Hillbrand
Alex Shvartzkop
Wayne Stambaugh
jean-pierre charras
Mike Williams
JamesJCode