Mike Williams
ab954456ee
Symbol Fields Table: don't leave Qty editable on error
2023-02-01 10:19:23 -05:00
Jeff Young
4c18dfebb9
Add Show Name column to FormBuilder files.
2023-02-01 12:36:27 +00:00
Jeff Young
b4a75cd1d5
Write out a diode .model for built-in diodes.
2023-02-01 12:36:27 +00:00
jean-pierre charras
29fd1b45d6
Ensure the DATASHEET field value only is used to know the datasheet URL.
...
previously, if the field option "show name" is set, the field name was
added to the URL, that broke it.
Fixes #13729
https://gitlab.com/kicad/code/kicad/issues/13729
2023-02-01 11:37:07 +01:00
Alex
56f900b14f
Remove errant wxTextCtrl style flags.
2023-02-01 06:22:32 +03:00
Mike Williams
29a4e2c7fe
Schematic: fix reversed tooltips for navigation buttons
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13707
2023-01-31 13:05:37 -05:00
JamesJCode
8590745e9c
Allow simulation probe of junctions
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13712
2023-01-30 23:15:55 +00:00
Seth Hillbrand
418f8e6f14
Re-add outline shadows to stroke fonts
...
If we draw using stroke fonts, we can still use the legacy shadow
routine to show nice highlights
2023-01-30 22:42:26 +00:00
Jeff Young
123467c8dd
Don't throw up debug message when signal is deleted.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13711
2023-01-30 21:32:18 +00:00
Jeff Young
c939b1ef76
Followed-by-3-digits doesn't guarantee a thousands separator.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13708
2023-01-30 21:22:48 +00:00
vinsfortunato
3d52115ae7
eeschema: focus eeschema on symbol when its row is selected in the symbol fields table
2023-01-30 15:12:57 +00:00
Mike Williams
207b8d3273
Symbol Fields Table: fix duplicated fields
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13687
2023-01-30 09:29:47 -05:00
Marek Roszko
f28339ded8
Hookup the skip drawingsheet arg
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13703
2023-01-30 07:50:16 -05:00
jean-pierre charras
241a283b03
DIALOG_TEXT_PROPERTIES_BASE: reduce the window min width.
2023-01-30 13:21:38 +01:00
Marek Roszko
fb57eac5f9
Add \n to report for cli
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13704
2023-01-30 07:11:36 -05:00
vinsfortunato
12101b6cad
eeschema: use correct sheet title block for plotting
...
Fixes: https://gitlab.com/kicad/code/kicad/issues/13690
2023-01-29 21:21:31 +00:00
vinsfortunato
586f22c2f7
eeschema: Focus eeschema on symbol when symbol fields table cell is selected with keyboard
...
Fixes: https://gitlab.com/kicad/code/kicad/issues/13688
2023-01-29 19:42:28 +00:00
JamesJCode
413169782a
Add SIM_ENABLE_FIELD column name when excluding symbol from simulation
...
Fixes #13691
2023-01-29 09:48:05 +00:00
Wayne Stambaugh
68decdd4f2
Fix static event table derived object definitions.
2023-01-28 14:10:06 -05:00
Ian McInerney
51c8f2c119
Fix library sort order in library viewers
...
The lib table returns a properly sorted list of libraries already, which
we just iterate through. A std::set is a sorted collection, but uses a
different sorting function than the lib table, so appending to a
std::set breaks the initial sorting that was done already.
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13530
2023-01-27 23:39:50 +00:00
Ian McInerney
a78e5b0141
Hide empty sizer in directive label dialog
...
Possibly fixes: https://gitlab.com/kicad/code/kicad/-/issues/13675
2023-01-27 22:25:33 +00:00
Ian McInerney
a91d2c21b8
Fix missing quotation mark in BOM plugin
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13685
2023-01-27 21:46:53 +00:00
Vincenzo Fortunato
f4e22cdcdb
altium: import component image only if part id matches
2023-01-27 16:28:38 +00:00
aris-kimi
b72cc23a00
Change one translatable "eeschema" string to "Schematic Editor"
2023-01-27 16:14:09 +00:00
Jeff Young
e5749d0cda
Position intersheet refs in imported Eagle schematics.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13667
2023-01-27 13:59:11 +00:00
Alex
a872ed11bf
Fix paths for Copy default global library table.
2023-01-27 09:24:52 +03:00
vinsfortunato
39e85015c2
Preserve pins positions when resizing sheet
2023-01-26 20:56:37 +01:00
vinsfortunato
cf1d17b566
Fix unexpected resizing behaviour when using top left edit corner
2023-01-26 20:54:51 +01:00
vinsfortunato
843600cb7e
Fix erratical sheet pins behavior when resizing
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13658
2023-01-26 20:54:51 +01:00
Gary Kim
0e939993bc
Only expand when opening alternate pin definitions
...
When opening alternate pin definitions collapsible
pane, only increase the window size to accommodate
the pane.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13596
2023-01-26 17:30:38 +00:00
Mike Williams
96e9cd6ecc
Schematic: added drag wires should copy stroke
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13666
2023-01-25 12:34:40 -05:00
Jeff Young
51293858b3
Allow empty lib tables.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13653
2023-01-24 23:45:55 +00:00
JamesJCode
f683df0d1f
Minor fix to ERC dialog
...
Correctly displays ERC aux item description when tied to specific
sheet context
2023-01-24 18:44:47 +00:00
Seth Hillbrand
43e4797d4d
Don't double-tap Connectivity Recalculate
...
SCH_EDIT_FRAME::RecalculateConnections() calls SchematicCleanup and then
resets the connectivity graph and recalculates it. OnModify() also
calls RecalculateConnections(). For long calculation schematics, this
can impact usability
2023-01-24 10:30:52 -08:00
Seth Hillbrand
420eceecbb
Simplify name caching
...
We don't need two functions to get driver names. The map should be
mutable to allow updates when needed. C++17 gives some extra syntactic
sugar for map manipulation
2023-01-24 10:30:52 -08:00
Wayne Stambaugh
a83313c4ab
Fix another build warning introduced by recent ERC changes.
2023-01-24 12:21:52 -05:00
Wayne Stambaugh
5638122d3d
Fix build warnings introduced by recent ERC changes.
2023-01-24 10:42:41 -05:00
JamesJCode
fef3274e8e
Eeschema: ERC checks handle connections between a common sub-circuit
...
Fixes #10926
Contains the following changes:
- Adds a new ERC_SCH_PIN_CONTEXT class which is used to provide deterministic
comparison between items causing ERC violations (e.g. pins) when associated
with a SCH_SHEET_PATH context.
- Adds association of SCH_SHEET_PATHs for ERC_ITEMs and the sub-schematic items
which caused an ERC violation. This allows correct display of markers on the
sheets of interest only, and allows correct naming resolution and cross-probing
from the ERC dialog.
- Adds a new ERC_TREE_MODEL class, derived from RC_TREE_MODEL, which correctly
resolves component references across heirarchical sheets using the associated
SCH_SHEET_PATHs. This allows sheet-specific component references to be displayed
correctly in the ERC results tree.
- Updates SCH_MARKER to only draw sheet-specific markers on the sheet causing
an ERC violation.
- Increments the schematic file version.
- When loading a schematic with legacy ERC exclusions, discards those of type
ERCE_PIN_TO_PIN_WARNING, ERCE_PIN_TO_PIN_ERROR, ERCE_HIERACHICAL_LABEL, and
ERCE_DIFFERENT_UNIT_NET as there is no safe way to automatically infer the
information which is now stored with these exclusions (sheet paths for error
location and related items). Requiring users to (once) re-add exclusions is
preferable to silently incorrectly matching new ERC issues to legacy exclusions.
2023-01-24 14:11:01 +00:00
Jeff Young
7a113a6a44
Fix misleading label (it filters label fields and other sheet fields as well).
2023-01-24 00:07:40 +00:00
Jeff Young
220c5a259b
Refresh schematic's copy of template fieldnames after preferences.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13203
2023-01-24 00:07:40 +00:00
Jeff Young
4de64b607a
Finish implementation of export_current_sheet_as_root.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13643
2023-01-24 00:07:40 +00:00
Jeff Young
25783f3b7e
Add label fields to Edit Text and Graphics Properties dialog.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13632
2023-01-24 00:07:40 +00:00
Jeff Young
4e50c5313d
More safety for array access.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13583
2023-01-24 00:07:40 +00:00
Graham Keeth
e4a8b9e76d
subckt export: add missing tristate pintype
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13644
2023-01-23 23:26:48 +00:00
Seth Hillbrand
00f93db2ff
Convert wide chars before reading model
...
The PEGTL parser used by KiCad for SPICE models only handles ASCII
characters. Despite the docs stating that you can, in theory, parse a
UTF-8 character by reading the base string, in pratice this does not
work as the UTF-8 string is represented by unsigned chars and the PEGTL
string is based on signed char.
To work around this, we need to convert micro and mu to the ASCII 'u'
equivalent
Fixes https://gitlab.com/kicad/code/kicad/issues/13642
2023-01-23 15:23:41 -08:00
Seth Hillbrand
442ee52905
Add versioning to lib tables
...
Sets lib table version to allow easier migration between versions
2023-01-23 22:21:12 +00:00
Seth Hillbrand
efe12f2da5
Cleanup variable naming
...
Also remove ancient/unused code for lazy resolving
2023-01-23 22:21:12 +00:00
Seth Hillbrand
a9ed47f06c
Update KICAD6->KICAD7
2023-01-23 22:21:12 +00:00
Mike Williams
b39aae6a93
Annotation: don't select hover item
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13352
2023-01-23 16:50:45 -05:00
Seth Hillbrand
9861ed1a5f
Don't special case power symbol re-annotation
...
When the designer asks to reset annotations, we reset all annotations
including power symbols. This may create additional churn in the files
but only when requested and is useful to fix schematic errors
Fixes https://gitlab.com/kicad/code/kicad/issues/13138
2023-01-23 13:19:01 -08:00
Seth Hillbrand
67c703e9e2
Fix LIB_TEXT plotting alignment
...
LIB_TEXT is not all aligned to the center, so place the proper flags
when calling Plot. This requires handling alignment offsets properly
when rotated as well
2023-01-23 12:23:14 -08:00
jean-pierre charras
2443d91265
SCH_FIELD: fix issue when try to clear its color from a previous color,
...
the old color was still used to display the field
Fixes #13631
https://gitlab.com/kicad/code/kicad/issues/13631
2023-01-23 10:22:42 +01:00
jean-pierre charras
e0111f709b
Fix minor cosmetic issues in Print dialogs
...
Fixes #13629
https://gitlab.com/kicad/code/kicad/issues/13629
2023-01-23 09:21:23 +01:00
Jon Evans
1bc3f77d2e
Coverity fixes
2023-01-22 22:48:31 -05:00
Jon Evans
e7a4d6d4da
Exclude database libraries from the symbol library editor
...
These libraries are metadata libraries and it does not make sense
to have them be shown in the symbol editor
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12842
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12878
2023-01-22 20:49:41 -05:00
Jon Evans
e419b0bfe8
Support sub-libraries in symbol library browser
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12842
2023-01-22 19:25:15 -05:00
Marek Roszko
0ff32d20cd
wxS more things
2023-01-22 09:41:42 -05:00
jean-pierre charras
9c12a6ee1d
Eeschema, eeschema_config.cpp: fix incorrect *.wks file path when trying to save it.
...
And add tests to see if the file can be saved
Fix also an issue in sch_editor_control.cpp: The page setup dlg must generate changes
only if the OK button is clicked.
Fixes #13599
https://gitlab.com/kicad/code/kicad/issues/13599
2023-01-22 13:17:05 +01:00
jean-pierre charras
e900e472ce
Fix compil and Coverity warnings
2023-01-22 09:40:09 +01:00
Jeff Young
542719c753
Add "all" mode to HSPICE emulation.
2023-01-21 19:32:25 +00:00
Wayne Stambaugh
0a7bd85cd6
Fix library symbol rescue issues.
...
https://gitlab.com/kicad/code/kicad/-/issues/13494
2023-01-21 10:35:14 -05:00
jean-pierre charras
4eb3a99bb5
SYMBOL_VIEWER_FRAME: fix some (minor) issues related to the symbol to display
...
Fixes #13274
https://gitlab.com/kicad/code/kicad/issues/13274
2023-01-21 11:29:01 +01:00
Seth Hillbrand
ed0d57ddf6
Handle the forced propagation to subgraphs
2023-01-20 15:20:03 -08:00
Seth Hillbrand
e6dbca051c
Force realtime connectivity on
...
The pressure relief valve was not useful for common work patterns as it
forced the recalculation on many common actions such as bus expansion.
This caused it to actually feel slower than with the pressure relief
valve off.
For most schematics, realtime is now fast enough to not need the valve
and for those that are extremely complex, removing the valve helps this
run more predictably
2023-01-20 15:17:57 -08:00
Seth Hillbrand
6fa2eedb4b
Avoid the obsolete GetNextPin() call
...
This iterated over all pins to find the pin after a given item. Because
out pattern is consistently to iterate in the outer loop, this means
that we were an O(n^2) loop for the pins just to find their names. This
affected very large parts (e.g. FPGAs) when switching sheets to display
2023-01-20 14:12:15 -08:00
Seth Hillbrand
b8ee588a76
Don't do a full connection database reset on redraw
...
All we need here is an updated intersheet reference, the connectivity
database remains valid and shouldn't be touched
2023-01-20 14:11:23 -08:00
Seth Hillbrand
08c2828bd3
Remove extra call to RecalculatedConnections()
...
This shouldn't happen when re-drawing, only on specific actions as it
will clog up our pipeline for other actions
2023-01-20 13:26:23 -08:00
Seth Hillbrand
4d7ddf619a
Remove unused var and cleanup
2023-01-20 13:26:11 -08:00
Jeff Young
3e55719831
May need to convert to UNIX style paths twice (before & after resolving).
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13591
2023-01-20 18:06:17 +00:00
Jeff Young
f7ebaf1bab
Add compatibility mode for netlist code.
...
(The non-A compatibility modes only run on included files.)
Fixes https://gitlab.com/kicad/code/kicad/issues/13589
2023-01-20 18:06:17 +00:00
Jeff Young
d9a90519f9
Flatten (and fix layout) of library table managers.
2023-01-20 14:19:58 +00:00
Marek Roszko
a9cb8e9a8d
Fix worksheets not loading in cli
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13489
2023-01-19 23:47:41 -05:00
Jon Evans
dee4f80680
DbLib: Load source symbol in editor when edit action is taken
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12840
2023-01-19 22:45:46 -05:00
Jon Evans
6cce99e0d0
Support showing Value field in symbol chooser
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13527
2023-01-19 22:14:10 -05:00
Jeff Young
27109bfc8a
MRU path for simulation model libraries.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13581
2023-01-20 00:18:55 +00:00
Mike Williams
5a2f4c445b
Global Label Dialog: add power nets to dropdrown
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/9118
2023-01-19 12:47:32 -05:00
Jeff Young
49f3b21f5c
Handle windows filepaths in SPICE include statements.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13591
2023-01-19 14:55:34 +00:00
jean-pierre charras
87975b2833
SYMBOL_EDIT_FRAME: make UpdateMsgPanel() working.
...
This is a virtual method, and the default method do nothing.
Now is calls SYMBOL_EDIT_FRAME::UpdateSymbolMsgPanelInfo()
Fixes #13586
https://gitlab.com/kicad/code/kicad/issues/13586
2023-01-19 15:52:23 +01:00
Wayne Stambaugh
ee3e285393
Correctly parent simulator netlist error dialogs.
2023-01-19 07:59:30 -05:00
Jeff Young
0e778f17db
Add context menu for simulation cursors.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13580
2023-01-19 12:50:21 +00:00
Jeff Young
715340b129
Fix erroneous early return.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13592
2023-01-19 12:19:49 +00:00
Jeff Young
959e20f52c
A fall-back model for FOO should supply FOO's pin names.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13589
2023-01-19 12:14:50 +00:00
Seth Hillbrand
7e5a2450b8
Move multiple wxMessageBox to DisplayErrorMessage
...
Also provide protection for headless running in multiple callsites
Fixes https://gitlab.com/kicad/code/kicad/issues/13575
2023-01-18 16:54:01 -08:00
Mike Williams
171cffec28
Schematic: actually check for hover on duplicate
2023-01-18 13:52:49 -05:00
Mike Williams
144cd0b7f2
Schematic: duplicate on hover: grabs symbol instead of field
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13495
2023-01-18 13:35:52 -05:00
Jeff Young
87377d1aac
Stop stepping on user's data.
...
Just because we can't find the file doesn't mean the path to it has
no value. Don't delete it. And don't crash afterwards either.
Fixes https://gitlab.com/kicad/code/kicad/issues/13578
2023-01-18 13:50:40 +00:00
Dag Lem
cff0560088
Eagle schematic import: Handling of escaped text
2023-01-18 12:33:36 +00:00
Jeff Young
3af9c658e6
Don't specify fonts in wxFormBuilder. It only leads to pain.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13547
2023-01-18 12:28:07 +00:00
Jeff Young
47d88c5647
Nullptr safety. (Sentry KICAD-71)
2023-01-18 00:52:19 +00:00
Jeff Young
26c821962f
Simplify and regularize text variable substitution architecture.
...
EDA_ITEMs are responsible for giving their parent a crack at it if
they failed to resolve it. This recurses all the way up to the schematic/
board, and then to the project.
Cross-reference handling is also move to the EDA_ITEMs. It must be done
before bubbling up so that we don't end up in loops. (The aDepth parameter
will break the loop, but without having done anything useful.)
Fixes https://gitlab.com/kicad/code/kicad/issues/13541
2023-01-17 17:05:41 +00:00
Mike Williams
369c0efade
Bitmaps: respect source DPI
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13565
2023-01-17 11:20:17 -05:00
Wayne Stambaugh
f81642bbb3
Fix broken graphics import file filters.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13570
2023-01-17 11:19:53 -05:00
Jeff Young
8d28cccfe2
Rework >NAME and >VALUE special processing a bit.
...
Earlier commit moved variable substition earlier (in loadSymbolText())
so we didn't have the correct info later when we tried to do the
special processing on it.
Fixes https://gitlab.com/kicad/code/kicad/issues/13541
2023-01-17 12:48:39 +00:00
Marek Roszko
d2c0f5fc2a
More wxSing
2023-01-16 23:14:38 -05:00
Jeff Young
6de25e2284
Lifecycle safety for highlight net items.
...
This possibly fixes Sentry issue KICAD-6E.
2023-01-16 18:11:16 +00:00
aris-kimi
3defb7679a
Schematic editor: move Update Schematic from PCB to the bottom
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13535
2023-01-16 17:18:21 +00:00
Jeff Young
a3a01a87e8
Resolve text variable references in LIB_TEXT and LIB_TEXTBOX.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13558
2023-01-16 16:01:45 +00:00
Jeff Young
9315e885ee
Substitute variables in imported symbol text.
...
Also allows mulit-line text items to be imported.
Fixes https://gitlab.com/kicad/code/kicad/issues/13541
2023-01-16 16:01:45 +00:00
Jeff Young
62649b868c
Ensure good fonts in grid headers.
...
Also moves rendering to a flat look for headers (instead of a beveled
border).
Fixes https://gitlab.com/kicad/code/kicad/issues/13547
2023-01-16 02:47:14 +00:00
Marek Roszko
789db0cecb
Some more wxS
2023-01-15 21:32:23 -05:00