Jeff Young
9d9745b555
Remove more legacy editing code.
2019-05-27 18:47:20 +01:00
Seth Hillbrand
f32c95229e
pcbnew: Check for valid data before deleting
...
We need to check for valid rows and iterators before removing a 3d model
Fixes: lp:1829337
* https://bugs.launchpad.net/kicad/+bug/1829337
2019-05-17 09:34:27 -07:00
Jeff Young
a461eae8b9
Fix 100s of usages of GetFlags() which conflated != 0 with being edited.
...
While this was true long ago, many flags have been added since which
have nothing to do with editing (HIGHLIGHTED, BEGIN_ONPAD, etc.)
2019-04-22 09:58:06 +01:00
John Beard
b6916c490c
Pcbnew: allow tab traversal of footprint orientation text control
...
Disable the text update event for the orientation cutom value field before
updating it when the radio buttons are selected. This allows to use the
conventional EVT_TEXT handler, rather than KEYDOWN, which has two effects:
* Tabbing though the dialog no longer sets custom orientation
* Click-driven clipboard actions trigger the update correctly.
Introduce a helper function in validators.h to assist in updating
validated fields without triggering further events.
Fixes: lp:1819006
* https://bugs.launchpad.net/kicad/+bug/1819006
2019-03-07 20:27:04 +00:00
Seth Hillbrand
525b9bd550
pcbnew: Correctly set the radio buttons in fpeditor
...
Radio buttons always have one set, so we need a single path to setting
the correct button.
2019-02-18 15:16:00 -08:00
Jeff Young
dc5ae574e2
Restore ability to hide grid columns.
...
wxGrids stupidly does this by setting the width to zero, so you
have to be careful when adjusting minimum widths.
2019-02-17 14:09:35 +00:00
Jeff Young
f1fb61202a
Spelling fixes.
2019-02-17 10:18:42 +00:00
Seth Hillbrand
5e5167f198
pcbnew: Adjust footprint properties columns
...
Size based on text width in 3d and check for overflow before expanding
the first column.
2019-02-14 22:09:01 -08:00
Seth Hillbrand
a02f447daa
pcbnew: Do not auto edit the 3d-model grid
...
Auto-selecting of the first grid element is performed in the footprint
editor to facility rapid editing. Rapid editing of the 3d-model fields
is not as useful and requires multiple esc-keys to cancel. This limits
the auto-edit to only the reference tab.
Fixes: lp:1815456
* https://bugs.launchpad.net/kicad/+bug/1815456
2019-02-14 16:29:51 -08:00
Wayne Stambaugh
fe5d2b8710
Pcbnew: fix footprint properties dialog 3D model visibility issue.
...
Update 3D model panel on initial dialog load to reflect the current
visibility state of the 3D model.
Fix a few minor footprint properties dialog spacing issues.
Fixes lp:1815184
https://bugs.launchpad.net/kicad/+bug/1815184
2019-02-10 12:00:19 -05:00
jean-pierre charras
a703c53312
Fixes in dialogs: mainly better sizes for grid columns, but more other minor fixes.
...
Fix wxGrid column minimal widths on Windows in dialogs (just fixing the size is not enough).
WX_GRID::GetVisibleWidth(): make width bigger for labels, because they usually use a bold font.
(However, the fix is just a workaround: a better code is welcome)
2019-02-10 16:40:47 +01:00
Seth Hillbrand
8ff764376a
wx_grid: abstract visible column width
...
Cleanup code for checking visible extents of grid text. Places single
routine to extract the current spacing from the grid in WX_GRID.
2019-02-09 15:31:31 -08:00
jean-pierre charras
61a95c5440
Fix compatibility with wxWidgets 3.1.1
2019-02-09 11:21:09 +01:00
Seth Hillbrand
76600e3436
pcbnew: Force grid sizing based on text extents
...
GTK does not handle enlarged text layouts automatically, so we need to
get the screen size before choosing the correct grid width for the
dialog
Fixes: lp:1788495
* https://bugs.launchpad.net/kicad/+bug/1788495
2019-02-08 20:03:45 -08:00
Jeff Young
dffa399eab
Set mirrored when creating footprint texts on back layer.
2018-12-31 21:50:09 +00:00
Jeff Young
4d9b4428fa
It's never a good idea to dereference a freed pointer.
...
Fixes: lp:1809897
* https://bugs.launchpad.net/kicad/+bug/1809897
2018-12-27 13:33:19 +00:00
Jeff Young
ff6a3482ec
Remove on-kill-focus-validation.
...
Fixes: lp:1805361
* https://bugs.launchpad.net/kicad/+bug/1805361
2018-11-29 19:00:21 +00:00
Jeff Young
fdff010199
Fix copy/paste errors in delayedFocusRow stuff.
...
Fixes: lp:1802907
* https://bugs.launchpad.net/kicad/+bug/1802907
2018-11-12 17:08:45 +00:00
Jeff Young
0585382986
Allow editing of library footprint from board reference.
2018-10-15 19:59:47 +01:00
Jeff Young
0bd0558833
Auto-select reference numbers in PcbNew like we do in Eeschema.
2018-10-14 00:06:41 +01:00
Jeff Young
19b1ae35ce
Don't assume GetFlags() != 0 means it's being edited.
...
It could just mean it's selected, highlighted or brightened.
Fixes: lp:1794624
* https://bugs.launchpad.net/kicad/+bug/1794624
2018-09-27 22:18:13 +01:00
Jeff Young
65f62f93ef
Fix MSW spacing issues.
2018-08-21 10:34:41 +01:00
Jeff Young
afacb6e7cb
Improve safety around un-committed grid changes.
2018-08-21 10:34:41 +01:00
Jeff Young
3c455949fc
Revert some dialog changes that lost button sizes.
...
These are required on MSW. Also back-dates the .fbp file to work
on Mac wxFormBuilder.
2018-08-14 13:54:04 +01:00
Jeff Young
185b524a62
Support both add-empty and add-browse for 3D models.
...
Also fixes a bug where the selected row and the grid cursor get
separated after a delete.
Fixes: lp:1782747
* https://bugs.launchpad.net/kicad/+bug/1782747
2018-07-23 01:09:47 +01:00
Jeff Young
ea3ef1eb87
Don't lose model filepath when writing spin boxes back.
...
Also renames a bunch of stuff to be clearer.
Fixes: lp:1782753
* https://bugs.launchpad.net/kicad/+bug/1782753
2018-07-20 21:59:12 +01:00
Jeff Young
829ba27206
Another round of dialog spacing/font adjustments for Windows.
2018-07-18 17:59:05 +01:00
Jeff Young
879ffa4d1c
Adjust dialog spacing for Windows.
2018-07-17 22:18:27 +01:00
Jeff Young
49ea6e1670
Fix occurrences of "edition" which should be "editing"
...
Fixes: lp:1778168
* https://bugs.launchpad.net/kicad/+bug/1778168
(cherry picked from commit bcb1220)
2018-07-17 15:12:39 +01:00
Jeff Young
aab97c8385
Consolidate design rules UI.
...
Implement new Board Setup paged dialog which includes:
Layers Setup
Design Rules
Solder Mask & Paste
Text & Drawings
Moves line width and text properties to a layer-class-based
system. Renames unlocked to upright (which also reverses the
logic).
New Edit Text and Graphic Properties dialog which replaces
Edit Footprint Text and adds layer-class-based editing and the
italic, upright and visibility properties.
Adds Import Settings functionality which allows settings to
be imported from another project at page granularity.
Also UNIT_BINDERizes the dialog and adds editing of pcb text.
Fixes: lp:1731952
* https://bugs.launchpad.net/kicad/+bug/1731952
Fixes: lp:1743464
* https://bugs.launchpad.net/kicad/+bug/1743464
Fixes: lp:1664761
* https://bugs.launchpad.net/kicad/+bug/1664761
Fixes: lp:1753362
* https://bugs.launchpad.net/kicad/+bug/1753362
Fixes: lp:1545427
* https://bugs.launchpad.net/kicad/+bug/1545427
Fixes: lp:1753775
* https://bugs.launchpad.net/kicad/+bug/1753775
Fixes: lp:1777692
* https://bugs.launchpad.net/kicad/+bug/1777692
Fixes: lp:1780670
* https://bugs.launchpad.net/kicad/+bug/1780670
Fixes: lp:1519601
* https://bugs.launchpad.net/kicad/+bug/1519601
(cherry picked from commit 3944a5e)
2018-07-17 15:12:34 +01:00
Jeff Young
ae2cb331b1
Merge PCBnew text edit dialogs.
...
(cherry picked from commit 63b7738)
2018-07-17 15:12:24 +01:00
Jeff Young
3e062867de
Move all the grid workarounds into our own WX_GRID class.
...
(cherry picked from commit 08b4463)
2018-07-17 15:11:38 +01:00
Jeff Young
0010ad37d1
In-place editing for footprint TEXTE_MODULEs.
...
Fixes: lp:1102168
* https://bugs.launchpad.net/kicad/+bug/1102168
Fixes: lp:1779913
* https://bugs.launchpad.net/kicad/+bug/1779913
(cherry picked from commit 83781ab)
2018-07-17 15:11:04 +01:00
Jeff Young
8f0aa68ab8
Fold 3D Search Paths dialog into Configure Paths.
...
Use in-place editing for both.
Fixes: lp:1743823
* https://bugs.launchpad.net/kicad/+bug/1743823
(cherry picked from commit 33622cd)
2018-07-17 15:11:01 +01:00
Jeff Young
a39fb03822
Remove some references to g_UserUnit
...
(cherry picked from commit 614d832)
2018-07-17 15:09:56 +01:00
Jeff Young
1f5b575eaf
Pretty-up new pad clearance UI.
2018-05-04 23:55:03 +01:00
Jeff Young
f32f14dc8f
Add WX_TEXT_ENTRY_DIALOG which inherits from DIALOG_SHIM.
...
Fixes: lp:1754977
* https://bugs.launchpad.net/kicad/+bug/1754977
2018-03-12 22:45:51 +00:00
jean-pierre charras
de72ef8518
Fix code after renaming files
2018-02-16 20:27:57 +01:00
jean-pierre charras
a5a6c4a012
Fix code after renaming files
2018-02-16 20:27:16 +01:00
jean-pierre charras
35a7f7a7b4
rename files: replace module by footprint in dialog filenames
2018-02-16 20:27:14 +01:00