jean-pierre charras
5484796745
BITMAP_BASE::Mirror() and ::Rotate(): fix an issue for bitmaps with ppi not 300
...
wxImage::Mirror() and wxImage::Rotate() transforms clear some parameters, especially
the PPI stored in the image. It creates bad size (bad ppi) when saving a BITMAP_BASE
in files.
These parameters are now restored after transform.
2023-04-23 16:12:14 +02:00
Jeff Young
be91f378ac
Suppress newlines in RC_ITEM messages.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14569
2023-04-19 12:38:46 +01:00
Jeff Young
4f9e754a51
Ignore empty field-name-templates.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14552
2023-04-18 13:46:08 +01:00
Jeff Young
955774a91a
Amend overly aggressive assert.
2023-04-17 17:52:28 +01:00
Jeff Young
e8a9485d5e
Markup fixes.
...
1) allow escape sequences inside markup sequences
2) keep overbar when inside nested markup
3) always place overbar at full height, not sub/superscript height
Fixes https://gitlab.com/kicad/code/kicad/issues/14553
Fixes https://gitlab.com/kicad/code/kicad/issues/13449
2023-04-17 17:52:11 +01:00
Jeff Young
82a5f307ed
Pull fix back from master.
2023-04-16 23:06:36 +01:00
Jeff Young
518980d9ed
Small improvements to lifecycle safety.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14521
Fixes https://gitlab.com/kicad/code/kicad/issues/14315
(cherry picked from commit cc4a8dcc89
)
2023-04-16 18:49:53 +01:00
Jeff Young
3217372720
Tighten up the lifecycle management of VIEW_ITEMs in
...
general, and the SYMBOL_VIEWER_FRAME's m_previewItem in
particular.
(Attempted fix for Sentry KICAD-G1.)
(cherry picked from commit 6f59740953
)
2023-04-16 15:38:15 +01:00
Jeff Young
9893921d76
Handle legacy libraries with escaped symbol names.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14057
(cherry picked from commit b74d964bff
)
2023-04-15 22:31:49 +01:00
Alex
fd42e493c0
Don't crash when canceling initial setup in Manage Footprint Libraries
...
(cherry picked from commit 21103924f4
)
2023-04-15 16:25:12 +00:00
Marek Roszko
4c129ec208
Init curl in InitPgm for thread safety
...
curl itself highly recommends not initializing curl from within a thread.
Due to the PCM, this can happen in a thread these days.
Pointed out by Érico Rolim in https://gitlab.com/kicad/code/kicad/-/merge_requests/855
(cherry picked from commit 8fd4909f86
)
2023-04-15 13:19:32 +00:00
Jeff Young
1707436cad
Retire the lib-tree scoring algorithm.
...
It appears to cause more confusion than help.
Fixes https://gitlab.com/kicad/code/kicad/issues/13905
(cherry picked from commit d01c023d5a
)
2023-04-15 00:09:34 +01:00
Marek Roszko
69989e4e64
Fix build error pre wx 3.1.6
...
(cherry picked from commit 0eefde6046
)
2023-04-13 22:21:35 +00:00
Lucas Dumont
f1f69c607e
Check KiFACE return value
...
Avoid segfault when cancelling initial global library setup
(Cherry-picked from 3c24017aa4
)
2023-04-13 14:39:49 +01:00
Jeff Young
a51475a094
Performance improvement for GetShownColumns.
...
(This needs to be fast as it's called from OnUpdateUI events.)
(cherry picked from commit 8e29a054f3
)
2023-04-13 13:47:21 +01:00
Ian McInerney
d3f4494925
Make version info work without lsb-release installed
...
(Cherry-picked from 8351c8923a
)
2023-04-12 16:13:51 +01:00
Ian McInerney
4ef6cbf4fb
Add hack to speed up font choice box widget creation
...
There are problems internal to GTK that mean creating choice boxes with
a lot of items is a very slow process. This hack works around one of
those issues to make it faster to create and display the menu in the
choice box.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14277
(Cherry-picked from a77e94d16f
)
2023-04-12 15:24:25 +01:00
jean-pierre charras
be7917c8d8
LIB_TABLE_GRID_TRICKS, popup context menu: fix minor issues:
...
- add separator only if needed
- ensure selection parameters are up to date.
From master branch
2023-04-12 11:20:11 +02:00
Marek Roszko
35def3ab2e
Prevent VIEW::UpdateItems and onShowTimer from firing repaints if GAL did not complete init
...
This appears to be a possible event race on startup
Fixes sentry KICAD-10A
(cherry picked from commit bfad8bb0d5
)
2023-04-12 02:10:34 +00:00
Jeff Young
1f34883a27
Make symbol/footprint trees sensitive to language change.
...
(cherry picked from commit eef3492fc0
)
2023-04-12 00:01:58 +01:00
jean-pierre charras
724262651f
manage libraries dialog: show new state of widgets as soon as the context-menu
...
activate/deactivate changes their state
From master branch
Fixes #14517
https://gitlab.com/kicad/code/kicad/issues/14517
2023-04-11 18:55:51 +02:00
Alex
d7b2247878
opengl_gal: Remove extra padding of bitmap textures.
...
Since the format has been changed to RGBA8, default (UN)PACK_ALIGNMENT = 4
works correctly, so the texture width padding to 4 is not needed anymore.
Fixes https://gitlab.com/kicad/code/kicad/issues/14432
(cherry picked from commit e91b53fc39
)
2023-04-11 04:32:42 +00:00
jean-pierre charras
e991ae504b
DIALOG_IMAGE_PROPERTIES: fix some issues:
...
- add missing panel_image_properties_base.fpb file
- fix not displayed image.
From master branch
2023-04-08 17:04:02 +02:00
Jeff Young
199e31ea3f
Eagle template footprints don't actually belong to board.
...
Set their parent to nullptr before deleting (as the board may have
already been deleted).
Likely fix for Sentry KICAD-79.
(cherry picked from commit 13e79af8a0
)
2023-04-04 14:21:19 +01:00
Jeff Young
89e78c0276
Fix Mac crash-on-quit when timed infobar is up.
...
(cherry picked from commit b3e2cf218f
)
2023-04-03 23:47:14 +01:00
Seth Hillbrand
29fd0caf58
Update translator contributions
...
Adds a number of missing contributors to our translations
(cherry picked from commit d135295ac8
)
2023-04-03 13:07:33 -07:00
Jeff Young
a21e7a5eee
Don't pass a FRAME-based UNITS_PROVIDER to a modeless dialog.
...
(The dialog may outlive said frame.)
Should fix Sentry KICAD-3A.
(cherry picked from commit 9b4627e782
)
2023-04-03 17:20:06 +01:00
Jon Evans
23b03fd6ab
Properties: Rename methods to better reflect their purposes
...
(cherry picked from commit 65193487a6
)
2023-03-26 19:48:46 -04:00
jean-pierre charras
56134d0202
KICAD_CURL_EASY: fix compil warnings (avoid using deprecated functions)
2023-03-25 18:27:35 +01:00
Marek Roszko
434161687e
Fix cli crash due to dialogs buried in the pcb parser...
...
Fixes sentry KICAD-Q2
(cherry picked from commit 8a8589b9db
)
2023-03-24 23:53:15 +00:00
Jon Evans
b0b9e66fad
Move to requiring explicit action to save project settings
...
(cherry picked from commit 610e787ada
)
Fixes https://gitlab.com/kicad/code/kicad/issues/14414
2023-03-24 11:49:50 -07:00
jean-pierre charras
36978d2ddc
Gerber plotter: fix incorrect arcs in regions when using a plot offset.
...
The arc center in Gerber units was incorrectly calculated.
From master
Fixes #14402
https://gitlab.com/kicad/code/kicad/issues/14402
2023-03-24 11:37:26 +01:00
Marek Roszko
3f90c895b9
Prevent crash in color settings due to dropdown weirdness
...
Fixes sentry reported crash KICAD-R6
(cherry picked from commit c65e33ac13
)
2023-03-23 23:47:13 +00:00
Alex
ba7598d90d
Fix clashing error dialogs when can't load dynamic library.
...
(cherry picked from commit 672c468342
)
2023-03-21 09:57:46 +00:00
Alex
92fc4872e8
GTK: Fix settings import paths showing up twice.
...
(cherry picked from commit b89545e484
)
2023-03-21 09:57:28 +00:00
jean-pierre charras
a65accd412
EDA_SHAPE_DESC(): catch a std::runtime_error when emitted by
...
template<typename T> T Get( PROPERTY_BASE* aProperty ) to avoid a crash,
and displays in Debug mode the runtime error message.
From master branch.
Fixes #14347
https://gitlab.com/kicad/code/kicad/issues/14347
2023-03-20 16:21:54 +01:00
Jeff Young
3afe02ac1f
Make sure legend reflects gain/phase for AC small signal analyses.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14301
(cherry picked from commit ec6d709929
)
2023-03-20 10:24:22 +00:00
Jeff Young
57aa61f1ba
Formatting. (No functional changes.)
...
(cherry picked from commit 6f44b85c13
)
2023-03-20 09:59:30 +00:00
jean-pierre charras
ae63313b55
PDF plotter: encode the letters ( and ) in strings with context CTX_JS_STR
...
They are separators and cannot be used in user strings.
Fixes #14302
https://gitlab.com/kicad/code/kicad/issues/14302
2023-03-15 09:36:01 +01:00
Jeff Young
94057886a3
Support SHEET_PATH when printing.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14233
(cherry picked from commit dc78797274
)
2023-03-14 11:56:33 +00:00
Jeff Young
2d9bcb6e4f
Select correct face from a .ttc file.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13314
(cherry picked from commit 7b3e01ce52
)
2023-03-14 11:56:33 +00:00
Jeff Young
74da0043b4
Move automatic dimension processing inside PCB_DIMENSION_BASE.
...
Also move dimension precision to an enum so it can get a proper dropdown
in the properties inspector.
(cherry picked from commit 461def2719
)
2023-03-12 21:04:09 +00:00
Jeff Young
c0ddca12df
Add Property Inspector support for dimension objects.
...
Includes changing the class hierarchy so that dimension objects inherit
from PCB_TEXT rather than containing a PCB_TEXT member variable.
(cherry picked from commit 23accffc6d
)
2023-03-12 21:03:58 +00:00
Wayne Stambaugh
9e1fd16329
Coverity fixes and code cleaning.
...
(cherry picked from commit 4e99812145
)
2023-03-10 11:21:19 -05:00
Jon Evans
ee0ba17c03
Improve HiDPI handling of appearance/layer controls
...
(cherry picked from commit 43d3a18b86
)
2023-03-07 08:49:06 -05:00
Jon Evans
64bc850d8f
Fix layer widget in HiDPI situations
...
(cherry picked from commit 89ef6b36f4
)
2023-03-07 08:49:06 -05:00
Salvador E. Tropea
f135881bd6
Use constants for the names of the built-in colors
...
- Avoid repetition and errors from typos
- Allow simple changes
- Simpler data type handling, the constants are wxString
2023-03-07 10:32:18 +00:00
Seth Hillbrand
5aba9b539f
Revert font spacing/tabs to the v6 model
...
While convoluted, this model matches as best we have found so far, the
alignment with scintilla. The spacing is character size for N-1 of the
characters in the 4-space tab stops. The final character is sized for
the actual space character in the stroke font (0.761905)
Fixes https://gitlab.com/kicad/code/kicad/issues/13791
(cherry picked from commit bce402a01c
)
2023-03-06 16:23:06 -08:00
qu1ck
d610486c1e
Add vector3 to swig
...
Fixes regression in 7.0 making fp 3d model offsets not accessible in
python
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14179
(cherry picked from commit 88062c5fc3
)
2023-03-06 11:23:09 -08:00
Wayne Stambaugh
2c7f44f78d
Coverity fixes and code cleaning.
...
(cherry picked from commit 789bf6455a
)
2023-03-04 13:14:59 -05:00
Jeff Young
8619705e44
Hook up AddField handler to GRID_TRICKS for SCH dialogs.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/git/14153
2023-03-02 18:16:02 +00:00
jean-pierre charras
dcc1009162
plotters rework: add plot fct to use TEXT_ATTRIBUTES class to pass text settings
...
Old PLOTTER::Text is not (yet) removed, but it use negative text size
to mirrored text, which is not really compatible with some plotters (especially PDF).
Using TEXT_ATTRIBUTES is much easy and much better,
so PLOTTER::PlotText() is added.
Note: "old" PLOTTER::Text() is not removed yet.
From master, commit 51d46c0e73
2023-03-01 10:45:23 +01:00
jean-pierre charras
d61e01ff4f
Plot Gerber format: ensure all attributes are added to polygon items.
...
Especially, TA.AperFunction,EtchedComponent for net tie footprints using polygons.
From master, commit ece34e1a0c
2023-03-01 09:39:15 +01:00
qu1ck
90eb5e9c31
PCM: auto reload global libs after dialog is run
...
This adds Reset() method to KIFACE to reload global libs stored in
global static vars.
Also refactors some lib reload code in various frames to have
common MAIL_RELOAD_LIB handler.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12500
(cherry picked from commit 2975f53647
)
2023-02-28 16:48:28 -05:00
Salvador E. Tropea
4213bb3a62
Fix rounding errors in gerber files
...
The userToDeviceCoordinates helper returns a VECTOR2D
Converting it to VECTOR2I back and forth generates rounding errors
Also is a waste of time
2023-02-28 19:23:26 +00:00
Johannes Pfister
33f835a437
When importing legacy PCB dimension: Use automatic dimension when Unit couldn't be determined
...
(cherry picked from commit a87550a2c6
)
2023-02-28 14:21:12 +00:00
Roberto Fernandez Bautista
c96f0f2396
Fix CADSTAR importer memory leaks
...
We were leaking the xml tree when throwing exceptions
(cherry picked from commit b03366c9e8
)
2023-02-27 22:58:41 +00:00
jean-pierre charras
c588639503
PANEL_COLOR_SETTINGS: swap swatches and texts to avoid annoying truncation.
...
In some languages, the texts can be long, and create truncation of the left
column. So if the left column shows swatches they are truncated, or not visible
Truncating long texts is less annoying.
Fixes #14052
https://gitlab.com/kicad/code/kicad/issues/14052
2023-02-27 08:37:13 +01:00
Jeff Young
b2241dca72
Adjust stroke font baseline offset to better match 6.0.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13886
(cherry picked from commit 4bb508eacf
)
2023-02-26 21:59:43 +00:00
Jeff Young
5979b8e385
Don't allocate all of memory when the coord system turns inside out.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14088
(cherry picked from commit fe9370ceea
)
2023-02-26 21:58:08 +00:00
Roberto Fernandez Bautista
955bd5a6d1
CADSTAR Sch: Fix loading of graphical arc shapes
...
Correctly load arc shapes as real arcs instead of approximating now that
v7 supports graphical arcs in the schematic.
Also fix calculation of arc geometry for ccw arcs.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14101
(cherry picked from commit 698d0b7e92
)
2023-02-26 18:47:39 +00:00
Seth Hillbrand
f927c15adf
Prevent mutex deadlock
...
The overbar function in outline fonts recursively calls the text
function which already owns the lock. To avoid this, we have an
unlocked variant that is wrapped by the exposed text function
Fixes https://gitlab.com/kicad/code/kicad/issues/14015
(cherry picked from commit 81256c0fa4
)
2023-02-25 13:44:18 +00:00
Jon Evans
009211c740
Fix some PCB_SHAPE properties
...
Hide irrelevant position/start/end properties
for shape classes that don't use them.
(cherry picked from commit 1651b44ab1
)
2023-02-24 01:24:41 +00:00
jean-pierre charras
c3d7158669
Eeschema plot: honor B&W plot option for bitmap images.
...
Fixes #14013
https://gitlab.com/kicad/code/kicad/issues/14013
2023-02-23 09:53:35 +01:00
jean-pierre charras
d5eb242295
Fix incorrect tilt of italic texts when plotting them.
...
Fixes #14023
https://gitlab.com/kicad/code/kicad/issues/14023
2023-02-22 20:25:25 +01:00
Salvador E. Tropea
b21e65fc5f
Fix compatibility with wxWidgets 3.0.x
...
- Use CanonicalName when GetCanonicalWithRegion() isn't available
2023-02-22 19:23:55 +00:00
Salvador E. Tropea
aee6d9d01c
Create the built-in colors in the constructor
...
This is needed so Python scripts can get built-in colors using the
SETTINGS_MANAGER.GetColorSettings() member.
Otherwise calling it with a built-in name crashes.
2023-02-22 09:12:22 -03:00
Marek Roszko
fd4a0dbedf
Fix up handling of font names available in multiple names
...
ttf fonts can declare multiple language names. Many by default opt to just declare one and not tag it any particular language.
However, there are CJK languages that typically leverage this function the most. They'll tag both a "en" and a cjk lang family name in CJK characters.
To be as user friendly as possible, we need to display said fonts in the CJK languages if KiCad to set to such a locale.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14011
(cherry picked from commit 39e69a3d29
)
2023-02-22 01:27:09 +00:00
Mark Roszko
aab7581909
Fix symbol contributor link
...
(cherry picked from commit 365c7be4ed
)
2023-02-20 19:44:59 +00:00
Marek Roszko
6b38927123
Fix crash parsing cadstar
...
Fixes sentry KICAD-B2
2023-02-19 08:11:33 -05:00
Marek Roszko
f46e4049b6
Try to prevent a crash in mpFXY::Plot
...
Fixes sentry kicad-c0
2023-02-19 08:11:27 -05:00
Marek Roszko
5d793193e0
Fix crash by using a shared_mutex to read/write lock the nickIndex
...
Fixes sentry kicad-ax
2023-02-18 13:02:25 -05:00
Mark Roszko
62337f75b8
FT_Face is also not thread, protect getTextAsGlyphs
...
(cherry picked from commit 7b4abb1f7b
)
2023-02-17 15:17:11 +00:00
Marek Roszko
4d4fdfff70
freetype is not thread safe, zone filler can trigger multi-thread access
...
sentry KICAD-B1
https://freetype.org/freetype2/docs/reference/ft2-base_interface.html
[Since 2.5.6] In multi-threaded applications it is easiest to use one FT_Library object per thread.
In case this is too cumbersome, a single FT_Library object across threads is possible also, as long as a mutex lock is used around FT_New_Face and FT_Done_Face.
(cherry picked from commit 65d5b34da3
)
2023-02-17 15:17:02 +00:00
Seth Hillbrand
3f535aca8c
Fix Ukrainian language name
...
Should refer to the language not to a Ukrainian person
(cherry picked from commit 576bef4ba0
)
2023-02-16 15:11:14 -08:00
Marek Roszko
3b5c38d861
CURLINFO_SIZE_DOWNLOAD_T is a enum entry, use the version check instead
...
(cherry picked from commit c189053ee5
)
2023-02-15 04:45:22 +00:00
Marek Roszko
90fb075e34
CURLOPT_XFERINFOFUNCTION is an enum entry not a define, the check is invalid
...
(cherry picked from commit 94b5ddbb50
)
2023-02-15 04:26:51 +00:00
Jon Evans
df0f626283
Properties: remove assertion that no longer makes sense
...
(cherry picked from commit e5b376721d
)
2023-02-14 21:10:42 -05:00
Jon Evans
1909ce9220
Properties: fix rebuilding when availability changes
...
(cherry picked from commit 61dd4b7043
)
2023-02-14 21:10:42 -05:00
Jon Evans
60a45241e6
Properties: introduce validators; re-enable zone hatch settings
...
(cherry picked from commit eb240fda9a
)
2023-02-14 21:10:42 -05:00
Jon Evans
d403e92315
Properties: introduce method chaining for initialization
...
(cherry picked from commit 254168c788
)
2023-02-14 21:10:42 -05:00
Jon Evans
d20f49b58b
Fix handling of PPI when loading embedded images
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13884
(cherry picked from commit 473979d686
)
2023-02-15 00:42:30 +00:00
Jeff Young
f4b2b1b03f
Workaround wxWidgets enforced min pen width by using transparent pen.
...
Also fixes some bugs in our shape printing code when a border is not
specified but a fill is.
Fixes https://gitlab.com/kicad/code/kicad/issues/13891
(cherry picked from commit 03484aedbc
)
2023-02-14 14:45:24 +00:00
Marek Roszko
a48eace90a
It's not impossible for the font face to fail loading
...
LoadFont()'s only usage already checked for nullptr to fallback, let's actually return nullptr on a failed load
Fixes sentry KICAD-8Z
Make the cause of sentry KICAD-95
(cherry picked from commit e8e407dfba
)
2023-02-14 01:09:56 +00:00
Marek Roszko
7a2a51ad44
Prevent another GAL crash on init due to psuedo-race
...
Fixes Sentry KICAD-98
(cherry picked from commit 9647a22e50
)
2023-02-14 00:11:15 +00:00
Marek Roszko
534000b49d
Ensure gal is initialized before letting DoRepaint blowup spectacularly.
...
Maybe a fix for KICAD-6B
(cherry picked from commit 58350b4521
)
2023-02-13 12:21:44 +00:00
Jon Evans
e1eedd3bba
Attempt to fix GitLab template duplication
...
(cherry picked from commit 609ef96e42
)
2023-02-11 12:04:39 -05:00
Jon Evans
6948a0bebd
Expose new netclass storage to SWIG
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13337
2023-02-11 09:50:24 -05:00
Alex
822d7af4b7
Hide scrollbars in editors by default.
2023-02-11 16:39:09 +03:00
Seth Hillbrand
fda3feaf3f
Revert "Add doc link to custom rules syntax help."
...
This reverts commit 7874735810
.
2023-02-10 15:33:03 -08:00
Alex
4ac6d6a0bd
Fix "wxEXPAND overrides alignment flags in box sizers" assert.
...
wxALIGN_CENTER_VERTICAL flag is ignored if wxEXPAND is present in
box sizers.
2023-02-11 02:15:44 +03:00
FPiorski
7978fdbfce
Plot colored drawing sheet text with the correct color
2023-02-09 14:12:48 +00:00
jean-pierre charras
5da5ccc4bf
pagelayout_editor: fix some minor issues:
...
- text color not always stored in file
- Indicator for changes in main title not updated after save.
2023-02-09 14:16:26 +01:00
jean-pierre charras
ae2da76615
Pcb printing: fix incorrect pos. of the board when printed without worksheet.
...
Fixes #13258
https://gitlab.com/kicad/code/kicad/issues/13258
2023-02-08 11:05:31 +01:00
jean-pierre charras
a493a2c822
kicad-cli, pcbnew pàlot: honor the color options when ploting pdf files
...
--black-and-white and -t were shown in help, but not handled
Fixes #13805
https://gitlab.com/kicad/code/kicad/issues/13805
2023-02-07 20:20:45 +01:00
jean-pierre charras
0d903d43a0
pagelayout editor: Add tests for invalid parameters.
...
Invalid parameters are repeat count < 1, size < 0 and default size < 0.01 mm
2023-02-07 12:53:34 +01:00
Seth Hillbrand
823607796b
Additional safety around wks bitmaps
...
Invalid files can create large problems for unloaded PNG data
Fixes https://gitlab.com/kicad/code/kicad/issues/13801
2023-02-07 12:08:39 +01:00
jean-pierre charras
23d0e6b4c0
Fix compil on msys2 (Structured Exception Handling not really supported)
2023-02-05 10:39:25 +01:00
Alex
525d0da126
Move __try into lambda.
2023-02-05 07:55:01 +03:00
Alex
b913e9be1e
Move more of defragment inside the __try block.
2023-02-05 07:45:03 +03:00