b343391723
Code cleanup for readibility.
2020-01-11 21:30:48 +00:00
116e3d6816
Fix missing member variable initialization.
2020-01-11 21:29:25 +00:00
3d8150032f
Fix some uninitialized variables found by Coverity.
2020-01-11 21:29:25 +00:00
2e509480a4
Fix guaranteed divide-by-zero error when called with correction of 0.
2020-01-11 21:29:25 +00:00
715448611d
Fix potential divide-by-zero (from Coverity scan).
2020-01-11 21:29:25 +00:00
1591d13839
Use static_cast since we've already checked the type.
...
This is faster and also keeps Coverity happy.
2020-01-11 21:29:25 +00:00
17710c15d3
Fix leak of empty PICKED_ITEMS_LIST.
2020-01-11 21:29:25 +00:00
677fcee0d2
Remove exception which is not caught in most code paths.
2020-01-11 21:29:25 +00:00
9182b3a850
Remove dead code and simplify remaining logic.
2020-01-11 21:29:25 +00:00
43abd53b19
Clarify limits of the if statement
2020-01-11 21:28:25 +00:00
6e8f06e042
Fixup some issues in libkimath
...
* Perform floating-point computations when needed
* Specify to use the default equality operator
2020-01-11 21:27:38 +00:00
f896043067
Fix comments for switch statement fall throughs
...
This cleans up all GCC warnings (-Wimplicit-fallthrough=2) about
implicitly falling through switch cases.
2020-01-11 19:16:32 +00:00
4ebb87d1c1
Fix Eeschema BW printing
...
Checks forced state when printing to convert images to grayscale.
2020-01-11 09:55:30 -08:00
195c3d074b
Fix bitmap clipping
...
When printing (using DC context) the bitmap will clear the full screen
unless the clipping region is set to the image itself.
Addresses KSC ticket 126
Fixes #1877 | https://gitlab.com/kicad/code/kicad/issues/1877
2020-01-11 09:47:19 -08:00
c3df984c0b
Project manager: fix files in nested dir not being added to hierarchy
...
Fixes #1945 | https://gitlab.com/kicad/code/kicad/issues/1945
2020-01-11 16:03:26 +00:00
94a9e81a0f
Fixes invalid initialization for Rect in rtree iterator.
...
The rtree has the rect array sizes templated by NUMDIM, initializing with 3 default values violates the templating.
2020-01-11 15:49:51 +00:00
ce5c63b368
Fix bitmap unit test
...
This was testing for bitmap dots per IU. But IU changed, so we needed
to adjust how the bitmaps were scaled. This brings the QA up to date.
2020-01-11 07:30:17 -08:00
7c28c3838a
Comment-only changes
...
Makes class comments conform to coding standards
2020-01-10 16:43:01 -08:00
2a780dba0e
Initialize view variable
...
Sets known initialization value to the last keyboard command
2020-01-10 16:43:01 -08:00
94f682c6bd
Fix bug in linux compile
...
wx 3.0 does not have an emplace_back method for wxVector
2020-01-10 16:41:55 -08:00
d1a0102e84
eeschema: Fix print order between worksheet and screen
...
The worksheet should be drawn behind the screen.
2020-01-10 16:33:53 -08:00
c2904ce7e9
Fixing drawing order when plotting/printing
...
This is a partial re-work of a previous commit to the v5 branch
(8f7278e34ffixes #368
2020-01-10 16:33:53 -08:00
a35db35029
eeschema: Fix bitmap scaling when printing
...
Bitmaps scale internally to 100nm instead of 1mil. There is a better
way to do this but I think we'll be adjusting it again when Cairo
printing in finished.
2020-01-10 16:33:53 -08:00
8fed9df1d0
Fix uninitialized variable (from Coverity scan).
2020-01-11 00:18:27 +00:00
254ba1f998
Fix null pointer access (from Coverity scan).
2020-01-11 00:15:47 +00:00
88eab8134e
Fix a couple of uninitialized variables (from Coverity scan).
2020-01-11 00:11:31 +00:00
0fd68dad62
Fix freed pointer access issue (from Coverity scan).
2020-01-11 00:09:08 +00:00
7bb9551801
Handle boost exceptions. (From Coverity scan.)
2020-01-11 00:04:01 +00:00
33da81cd27
Repair Coverity scan defects.
2020-01-10 23:17:54 +00:00
b54a42ba53
Clean up dialog (including uninit var from Coverity scan).
2020-01-10 22:32:50 +00:00
8576a4a067
Fix unchecked array access (from Coverity scan).
2020-01-10 22:32:50 +00:00
8abfc13053
Fix possible null dereference (from Coverity scan).
2020-01-10 22:32:50 +00:00
c27e278e58
Fix uninitialized variable (from Coverity scan).
2020-01-10 22:32:50 +00:00
cc5a42ff41
Minor cleanup and performance.
2020-01-10 22:32:50 +00:00
ae74815ff0
Go to seleted object when opening Symbol Fields dialog.
...
Note: only active if there is a single item selected and it (or
its parent) is a component.
2020-01-10 22:32:50 +00:00
5e5edd03f6
Implement super- and subscript printing and plotting for eeschema.
2020-01-10 22:32:49 +00:00
65c88ba2c3
Reduce the auto-panning margin and implement acceleration.
2020-01-10 22:32:49 +00:00
e03281a9ae
Allow exclusive-or selections on OSX.
2020-01-10 22:32:49 +00:00
7c61b83df6
Code cleanup
2020-01-10 20:10:29 +00:00
5e6c6e7e22
Fix memory leak in the footprint preview panel
...
The cached modules were never deleted, so they would
leak whenever the panel was closed.
2020-01-10 20:10:29 +00:00
77c60d9655
Remove the last vestiges of dlist
...
It served us (mostly) well for more than a decade. It helped KiCad grow
before the std:: came into decent shape or speed. It was a good little
list.
RIP DLIST 2008-2020
2020-01-10 06:37:08 -08:00
6e5e453d0d
Replace EESchema DLIST
...
This moves EESchema DLIST structures to rtree. These changes are more
fundamental than the pcbnew changes from 9163ac543888c01d11d1877d7c1961b22d60
2020-01-10 06:37:08 -08:00
a8d9fcb4e0
Fix event handler type casting
...
The old methods were very clunky and not recommended (and didn't
properly cast the function types). This changes to useing the
recommended way of declaring events and casting the event handlers.
2020-01-09 18:08:49 +00:00
d587bd5bca
SVG plotter: fix an issue with mirrored texts.
...
Mirrored texts have a size < 0.
Of course, the actual value for the plotter is the absolute value.
2020-01-09 18:07:56 +01:00
f53aa51326
Fix save library bug in symbol editor.
...
Add try/catch blocks when saving symbols using a plugin object directly
to prevent potential unhandled exception bugs. I'm not totally happy
using wxLogError to flag exceptions but I couldn't think of a better way
to handle them.
Fixes #3665
https://gitlab.com/kicad/code/kicad/issues/3665
2020-01-09 11:23:46 -05:00
3f161965cd
Eeschema: Draw selected global labels:fix incorrect text drawing.
...
Happens only on Cairo.
Was due to the fact on cairo the shape area was deleted after the shadow
text was drawn, and only the second text was seen.
Fixes #3745
https://gitlab.com/kicad/code/kicad/issues/3745
2020-01-09 14:43:46 +01:00
03611f7bb7
missing change
2020-01-09 09:14:04 +01:00
c17c9960d8
Eeschema: fix a colliding name between sch_text.h and a Windows/msys2 header.
...
"INPUT" declaration in sch_text.h generate *a lot of* compil warnings.
So it is replaced by PS_INPUT.
For consistency, others member of enum class PINSHEETLABEL_SHAPE are also renamed.
2020-01-09 08:52:30 +01:00
ca34ade00c
Make global labels have the same spin style as net/hierarchical labels
...
For legacy reasons, it stored left and right "spin" as flipped integers in the file format.
But the code handled the flip in multiple locations rather than just doing it on file io.
This change unifies the internal code and does the mapping in the file I/O.
2020-01-08 19:07:55 +00:00
fd0d5fdb38
HIERARCHY_NAVIG_DLG: fix crash when in a subsheet one open the dialog
...
and switch to the paren sheet from the context menu.
Mainly, change the way the dialog is managed from the sch_edit_frame:
the pointer to find the created dialog is replaced by a call to wxWidows::FindWindowByName().
Using a pointer set and cleared by events is a recipe for crashes.
2020-01-08 15:01:22 +01:00
Jeff Young
Ian McInerney
Seth Hillbrand
Mikołaj Wielgus
Mark Roszko
jean-pierre charras
Wayne Stambaugh