Jeff Young
da12746a3a
Clear selection before deleting board layers.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15866
(cherry picked from commit 8d3047d6eb
)
2023-10-14 15:33:00 +01:00
jean-pierre charras
8432fb4fea
Pcbnew: when adding layers, do not change via layers.
...
Via layers are not defined by a LSET, and the code that used the new LSET
broke the Via start and/or end layers (for blind/buried vias)
From master branch
Fixes #15856
https://gitlab.com/kicad/code/kicad/-/issues/15856
2023-10-14 08:56:19 +02:00
jean-pierre charras
00bf2ca36f
Pcbnew: rename ZONE* m_SolderMask to m_SolderMaskBridges
...
(It is a container to build bridges on solder mask layers by DRC, not real zone)
Disable also this special zone selection by adding it in
PCB_SELECTION_TOOL::itemPassesFilter
Do not display the outlines of this very special zone used by DRC
to show layer mask bridges created by DRC to show these bridges.
From Master branch
Fixes #15847
https://gitlab.com/kicad/code/kicad/-/issues/15847
2023-10-13 17:15:37 +02:00
jean-pierre charras
8f58e1a9e0
DIALOG_EXPORT_STEP_LOG: print the command line sent to kicad-cli in report window.
...
It can be useful in case of problems.
(cherry picked from commit 2bf8602912
)
2023-09-05 00:26:43 +00:00
Jeff Young
02a95b958d
Remove up/down buttons until we implement layer ordering.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14574
(cherry picked from commit d27413a032
)
2023-09-03 22:43:41 +01:00
Jeff Young
5cd88dbd20
Bug fixes for paste margins on custom-shaped pads.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15125
(cherry picked from commit 60419f542a
)
2023-09-03 22:32:40 +01:00
Jeff Young
889689e31a
Stop trying to zero-out offset of custom-shaped pads.
...
It causes *way* to many issues.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15555
(cherry picked from commit 68c839b214
)
2023-09-02 11:18:34 +01:00
Marek Roszko
2209f5e93b
Fix accidental plotting of disabled textbox borders
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15252
2023-08-24 21:14:27 -04:00
Marek Roszko
a17cd9d054
Make VRML use board edge bounding box for parity with step
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15472
2023-08-24 20:42:58 -04:00
Jeff Young
c521efa35d
Move checking for null parent higher.
...
(Otherwise we set the failure flag without telling the user why.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15415
(cherry picked from commit 6a6e839cc4
)
2023-08-19 20:09:47 +01:00
jean-pierre charras
246be732a1
Pcbnew, DIALOG_PAD_PROPERTIES: ensure the right spoke angle is displayed.
...
From master, commit d8ba6c07ac
2023-08-17 08:04:18 +02:00
Jon Evans
88dfe6eb9c
Stricter API for LIB_TABLE
...
Prevent nickname map or row parent getting out of sync
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15315
(cherry picked from commit 4c4bbdc8f3
)
2023-08-15 01:39:09 +00:00
jean-pierre charras
8625a59d4c
Fix a display issue in wxStyledTextCtrl widgets in dialogs (Windows specific).
...
It happens when a text is using some esoteric unicode chars.
Fixes #15314
https://gitlab.com/kicad/code/kicad/-/issues/15314
2023-08-03 18:44:57 +02:00
Jon Evans
228fe71eb4
Do not force focus on dataview in RC dialogs
...
On GTK, this causes the first item to be selected, firing the
selection handler and causing unwanted side effects.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/11925
(cherry picked from commit 7804c2177c
)
2023-08-03 13:06:37 +00:00
Jeff Young
62bf6a9d57
Save a bit of space in FP 3D preview by moving board thickness to dlg.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13896
(cherry picked from commit df63ca0189
)
2023-07-16 20:01:26 +01:00
Jeff Young
16d24d4b43
Tailor inspector text properties for dimension objects.
...
(cherry picked from commit 50da4e483e
)
2023-07-09 21:54:52 +01:00
Jeff Young
12cf696097
Tab-order fix provided by aris-kimi.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9406
2023-06-17 18:34:52 +01:00
Alex Shvartzkop
a5ded3341a
Adapt panels to PAGED_DIALOG sizing algorithm.
...
Also some cosmetic fixes (GTK).
(cherry picked from commit d3be62f644
)
2023-06-17 15:19:26 +03:00
Alex Shvartzkop
c61931996a
PAGED_DIALOG: allow setting initial size in ctor.
...
(cherry picked from commit f5da58e17d
)
2023-06-17 15:19:26 +03:00
Jeff Young
1e013274c2
Fix broken build.
2023-06-11 22:35:54 +01:00
Jon Evans
fe5c7a60ab
Net Inspector: clear sort ordering during rebuild
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14697
(cherry picked from commit 3a2cc8f56f
)
2023-06-11 17:16:57 +00:00
Jeff Young
bc0a53a226
Increased mutex safety.
...
Don't even query the size() without having at least a shared_lock.
*May* prevent KICAD-4S, but seems unlikely.
(cherry picked from commit f3d3ade1dc
)
2023-06-10 10:57:14 +01:00
Jeff Young
0bd45f691e
Make sure 3D file browser is treated as modal by quit.
...
(Otherwise we crash when freeing it during the quit.)
(cherry picked from commit c36b0fcda7
)
2023-06-04 21:22:19 +01:00
Jeff Young
4a274709e7
Go back to using QuasiModal for TextBox Properties.
...
Also removes auto-closing of blocking dialogs when inserting
symbols from the Symbol Editor or Chooser, preventing the bug
that QuasiModel was removed for earlier.
Also fixes a non-initialized parent pointer when the TextBox
Properties dialog was called from DrawShape().
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14777
(cherry picked from commit 5a9ed66cfd
)
2023-05-28 19:19:50 +01:00
Jeff Young
c6e4f18d99
Hook up text variable auto-complete for PCBNew.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14777
(cherry picked from commit 14f004d2a5
)
2023-05-28 18:46:39 +01:00
Wayne Stambaugh
0e5155ae2f
Fix clipped combobox entry in board editor text box dialog.
...
The layer combobox color swatch was clipped when the combobox was
closed when the dialog was launched. Setting the minimum width
resolved the issue. This may have been a GTK only issue.
(cherry picked from commit a13a49f45a
)
2023-05-28 18:43:32 +01:00
Jeff Young
19e5a231a7
Don't run onPageChanged() event handler during initialization.
...
(cherry picked from commit 3f44c811c7
)
(cherry picked from commit f35ed59868
)
2023-05-28 19:38:27 +02:00
Jeff Young
01fcb2276b
Move remainder of Board Setup to lazy loading.
...
(cherry picked from commit 03c9b1c202
)
(cherry picked from commit 3cd87c2a44
)
2023-05-28 19:38:27 +02:00
Jeff Young
19b4e98ee7
Lazy loading of Schematic Setup panels.
...
(cherry picked from commit ddc6ecf7be
)
(cherry picked from commit 6cbc10db81
)
2023-05-28 19:38:27 +02:00
Jeff Young
77c76bbc8a
Insta-prefs.
...
(cherry picked from commit 9ae8255202
)
(cherry picked from commit 4c28070449
)
2023-05-28 19:38:27 +02:00
Seth Hillbrand
fa56b17c88
Revert "Fix clipped combobox entry in board editor text box dialog."
...
This reverts commit 7ea907c343
.
2023-05-24 08:54:16 -07:00
Seth Hillbrand
7e39411910
Revert "Insta-prefs."
...
This reverts commit 4c28070449
.
2023-05-24 08:54:16 -07:00
Seth Hillbrand
2f3659e7ac
Revert "Lazy loading of Schematic Setup panels."
...
This reverts commit 6cbc10db81
.
2023-05-24 08:54:16 -07:00
Seth Hillbrand
c0567aa011
Revert "Move remainder of Board Setup to lazy loading."
...
This reverts commit 3cd87c2a44
.
2023-05-24 08:54:16 -07:00
Seth Hillbrand
9b310ab955
Revert "Don't run onPageChanged() event handler during initialization."
...
This reverts commit f35ed59868
.
2023-05-24 08:54:16 -07:00
Jeff Young
f35ed59868
Don't run onPageChanged() event handler during initialization.
...
(cherry picked from commit 3f44c811c7
)
2023-05-23 09:40:32 +01:00
Jeff Young
3cd87c2a44
Move remainder of Board Setup to lazy loading.
...
(cherry picked from commit 03c9b1c202
)
2023-05-23 09:40:32 +01:00
Jeff Young
6cbc10db81
Lazy loading of Schematic Setup panels.
...
(cherry picked from commit ddc6ecf7be
)
2023-05-23 09:40:32 +01:00
Jeff Young
4c28070449
Insta-prefs.
...
(cherry picked from commit 9ae8255202
)
2023-05-23 09:40:32 +01:00
Wayne Stambaugh
7ea907c343
Fix clipped combobox entry in board editor text box dialog.
...
The layer combobox color swatch was clipped when the combobox was
closed when the dialog was launched. Setting the minimum width
resolved the issue. This may have been a GTK only issue.
(cherry picked from commit a13a49f45a
)
2023-05-22 12:06:13 -04:00
qu1ck
874191bd8d
Don't disable reload button in action plugins preferences
...
(cherry picked from commit a86aa6fc3e
)
2023-05-11 01:13:42 +00:00
Jon Evans
ef7b3c1715
Use constraints to determine netclas width
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14190
(cherry picked from commit 61d30ee5bc
)
2023-05-10 16:10:30 +00:00
Jeff Young
97be02356f
CLang can't do a dynamic_cast across the KiWay.
...
Rely on DRC for text readability instead.
(Fixes Sentry KICAD-R4 on Mac, and the assert when opening
Preferences from a non-PCBNew-module window.)
(cherry picked from commit 245c3ba6e4
)
2023-05-09 11:15:00 +01:00
Jeff Young
e28b50e8d6
Fix a bunch more issues with sheetpaths and allowExtraText.
...
A sheetpath is required to correctly resolve text variables.
Depending on currentSheet is rife with bugs.
There are many places where we do *not* want to be prepending
field names to the field values, such as netlisting,
building PDF hypertext menus, etc.
Also, Find/Replace needs to work on unresolved text, as
that's what we're going to display (and if replace nuked
your variable references you wouldn't be happy).
(cherry picked from commit b41d446f58
)
2023-05-05 18:02:59 +01:00
Jeff Young
a51475a094
Performance improvement for GetShownColumns.
...
(This needs to be fast as it's called from OnUpdateUI events.)
(cherry picked from commit 8e29a054f3
)
2023-04-13 13:47:21 +01:00
Jeff Young
927b5ae707
Use enums for column ids.
...
(The nickname, in particular, is no longer column 1.)
Fixes https://gitlab.com/kicad/code/kicad/issues/14291
2023-04-02 15:28:11 +01:00
Seth Hillbrand
85038c2b46
Prevent PCB Editor from opening multiple board_setup
...
ShowBoardSetup can be called multiple times from multiple locations,
resulting in duplicate board setup dialog boxes. This is confusing and
should be prevented. We use the established patter from the symbol
picker to ensure that only one copy of the dialog is ever opened at a
time
(cherry picked from commit 7695d510d6
)
2023-03-30 15:34:42 -07:00
Jon Evans
23b03fd6ab
Properties: Rename methods to better reflect their purposes
...
(cherry picked from commit 65193487a6
)
2023-03-26 19:48:46 -04:00
Marek Roszko
5dc683c968
Fix crash editing footprint editor defaults
...
Missing one level of GetParent()....use a dynamic_cast to sanity check it in debug
Fixes sentry crash KICAD-R4
(cherry picked from commit d49562a7aa
)
2023-03-22 22:41:57 +00:00
jean-pierre charras
7b4dd2f7f5
DIALOG_BOARD_REANNOTATE: ensure indexes are not out of bound.
2023-03-13 20:25:54 +01:00