haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
20,678 Commits 9 Branches 105 Tags 1.3 GiB
Commit Graph

20678 Commits

Author SHA1 Message Date
Ian McInerney 2becd368d9 Thirdparty: Properly handle error condition in nanosvg 
ftell() returns -1 on an error, so it must be a long return
type, and we should test for its failure.

(found by Coverity)
 2020-09-20 22:39:31 +01:00
Ian McInerney 68985490c6 Update lemon and its template to most recent upstream version 
This should fix some Coverity warnings about memory management
in the lemon tool (less critical), but also fix improper
memory accesses in the generated parsers (labeled critical
by Coverity).

Ref: https://sqlite.org/forum/forumpost/edecf32da3
 2020-09-20 22:27:11 +01:00
Jeff Young 650cff5b39 Shorten solder mask alert and provide a link for fixing. 
Fixes https://gitlab.com/kicad/code/kicad/issues/4798
 2020-09-20 21:26:39 +01:00
Jeff Young b3a369bd7c Remove zone areas outside board edges. 
The first attempt to address this which added back in the zones
with a 0 netcode didn't pick up those with a netcode which weren't
isolated (ie: because there were unplaced footprints outside the
board edges).

The new system gives up on trying to adjust the insulated island
list and just makes a second pass.

Fixes https://gitlab.com/kicad/code/kicad/issues/5658
 2020-09-20 20:36:01 +01:00
Jeff Young fdbb28aea2 Treat Reference and Unit as separate words when searching. 
Fixes https://gitlab.com/kicad/code/kicad/issues/4630
 2020-09-20 18:57:33 +01:00
Dominik Wernberger 884bed7e12 Fix that all file types are shown in file dialog 2020-09-20 16:04:44 +00:00
Jeff Young d9a94dc538 Don't allow selection of PCB_NETINFO_T. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5729
 2020-09-20 16:41:39 +01:00
jean-pierre charras e64806cd20 Menus/Submenus: fix incorrect bitmap for checkable menuitems in submenus. 
Windows specific, because other OS do not accept user bitmaps in ckeckable menuitems
the bug was due to the same bitmap was set for each state for these menuitems.

Fixes #5622
https://gitlab.com/kicad/code/kicad/issues/5622
 2020-09-20 16:30:23 +02:00
jean-pierre charras 0b03d8a5ff Fix a few Coverity warnings. 2020-09-20 16:30:23 +02:00
jean-pierre charras 2751c67746 Pcbnew, PCB_PAINTER: provides an option to show footprints bounding box. 
This is only for bounding box debug purposes, and is not activated.
 2020-09-20 16:30:23 +02:00
Jeff Young 1039fb1bc5 Minor refinement to Import Settings from Board dialog. 
Also some defensive code to protect against an ASAN stack buffer
underflow.

Fixes https://gitlab.com/kicad/code/kicad/issues/5660
 2020-09-20 13:55:59 +01:00
Jeff Young 0b108d61e7 Cairo canvas not on Mac; no need to show antialiasing settings. 2020-09-20 13:55:59 +01:00
Jeff Young ad2407867a Disable Save Report while DRC is running. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5723
 2020-09-20 13:55:58 +01:00
Jeff Young e27ff1dd3c Add Select All to multi-line text properties. 2020-09-20 13:55:58 +01:00
Ian McInerney 89dcc46898 Coverity cleanup and remove unused variables 2020-09-20 02:20:41 +01:00
Ian McInerney 65bd1ee9a4 Add a new BITMAP_BUTTON widget and use it in the appearances panel 
This button behaves like an AUI button, so it is more suited
to being on panels without a border.
 2020-09-20 01:43:27 +01:00
Ian McInerney c5feccca53 Add stub functions in KIPLATFORM to detect dark mode 
These haven't been written yet, but current code can
be adapted to use these now.
 2020-09-20 01:43:27 +01:00
Ian McInerney f82ad61c90 More warning cleanup 2020-09-20 01:43:27 +01:00
Jeff Young 4558aff24b Add textVar cross-reference support to Dimensions. 
Also adjusts spacing in the dialog.

Fixes https://gitlab.com/kicad/code/kicad/issues/5664
 2020-09-19 20:42:30 +01:00
Jeff Young 13f1de8e73 Forgot a bunch of files from last commit. 2020-09-19 19:53:58 +01:00
Jeff Young 64fa400b19 Ease translation a bit. 
Also improves the SNR and consistency of the menu item text.  For
instance, a position is rarely useful, while relative sizes can be.

Also removes some unnecessary repitition, such as "Graphic Rectangle"
when "Rectangle" communicates the necessary information.
 2020-09-19 18:49:06 +01:00
Jeff Young db5de738ae Apply rules commutatively. 2020-09-19 18:48:11 +01:00
jean-pierre charras 121ccc3a10 Fix broken MODULE::HitTest() 
HitTest was using a rotated bounding box, but the bounding box
is already right.
 2020-09-19 19:37:58 +02:00
jean-pierre charras 55089f4732 Better strings for translation (minor fix) 2020-09-19 19:02:19 +02:00
Seth Hillbrand d227b53e1a Fix broken translation string 2020-09-19 09:13:30 -07:00
Jeff Young 39bdc547af Smarten up the guess selection routine to pick closest item. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5697
 2020-09-19 15:55:27 +01:00
Jeff Young d402d93487 Implement shape routines for DIMENSION_Ts. 
This allows them to participate in DRC and PNS.

Fixes https://gitlab.com/kicad/code/kicad/issues/5712
 2020-09-19 14:16:00 +01:00
Jeff Young ece2ae9805 Don't capture commands in the router eventloop that it doesn't process. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5692
 2020-09-19 12:08:18 +01:00
Jeff Young 0763a8962c Implement boolean not processing in expression language. 
Also adds some more error catching to be more robust in the face
of malformed customer rules.

Fixes https://gitlab.com/kicad/code/kicad/issues/5694
 2020-09-19 12:08:18 +01:00
Seth Hillbrand 23f7ba6ee4 Ensure that we had a pad remaining before painting 
Null polygons should not be send to the painter, so we need to check to
see if our mask has removed the complete pad before painting

Fixes https://gitlab.com/kicad/code/kicad/issues/5702
 2020-09-18 22:33:24 -07:00
Jon Evans 375f1b8129 Avoid throwing exception when starting from scratch 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/5661
for some reason
 2020-09-18 20:41:27 -04:00
Seth Hillbrand 4fa3de2211 Ensure we clear forced position 
Fixes https://gitlab.com/kicad/code/kicad/issues/5699
 2020-09-18 16:10:09 -07:00
qu1ck 5e0d79449e Fix pcbnew api for DIMENSIONs 
DIMENSION is now an abstract class and we should cast to
concrete implementations instead.

Also change broken 'return none' to throwing an exception
which will give feedback about what is not supported by
the API instead of silently returning a non-object.
 2020-09-18 22:52:47 +00:00
Jeff Young ef48dba7ff Correctly set value and footprint fields from Symbol Fields editor. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5689
 2020-09-18 23:30:16 +01:00
Jeff Young 7062a3b29b Fix bug in net <-> netclass matching. 
Also adds a "Default" setting for Edit Text and Graphics Properties
so the linestyle can be batch-edited back to default.

Fixes https://gitlab.com/kicad/code/kicad/issues/5674
 2020-09-18 23:29:34 +01:00
Jeff Young 2799faf52b Add syntax example using "not". 
Fixes https://gitlab.com/kicad/code/kicad/issues/5694
 2020-09-18 22:39:51 +01:00
Jeff Young 80acf944a0 Don't assert when compiling rules; generate a user-visible error. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5694
 2020-09-18 22:29:47 +01:00
Jeff Young 67b5d24995 Support ESC & Cancel for DRC. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5698
 2020-09-18 22:14:00 +01:00
Jeff Young 73fc00ee69 Collapse VIA_TOO_SMALL and MICROVIA_TOO_SMALL into VIA_DIAMETER. 
We'll also check too large in future....
 2020-09-18 16:50:41 +01:00
Jeff Young f340636f70 When knocking out higher-priority zone use fill, not outline. 
Also fixes a bunch of naming issues, primarily with lowercase for
protected variables, but also some for consistency with other parts
of the code.

Also changes the zone fill radio buttons in Board Setup to be more
generic referring to legacy vs. current, and to have tooltips.

Fixes https://gitlab.com/kicad/code/kicad/issues/5583
 2020-09-18 16:45:41 +01:00
Jeff Young d468618411 Don't eat commands that aren't ours in SCH_MOVE_TOOL. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5692
 2020-09-18 16:45:41 +01:00
Jeff Young 90b147a914 Add DRC_ITEM definition for DRC_VIA_DIAMETER. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5695
 2020-09-18 13:32:44 +01:00
Jeff Young 079bc52f6d Minor cleanup. 2020-09-18 13:14:08 +01:00
Jeff Young 53297c78a6 Don't eat commands we don't need in move tool. 
This also fixes the dynamic ratsnest issue.

Fixes https://gitlab.com/kicad/code/kicad/issues/5692
 2020-09-18 13:14:08 +01:00
Jeff Young 1a988e8d85 Fix event processing bug which kept ModEdit's context menu from working. 2020-09-18 11:49:34 +01:00
Ian McInerney 34527630d0 Small cleanup 2020-09-18 11:17:37 +01:00
Ian McInerney a53f3899d4 Initialize variables properly 2020-09-18 11:17:37 +01:00
Ian McInerney aa0b0ca7e7 Fix some warnings in the cadstar importer 2020-09-18 11:17:37 +01:00
Ian McInerney 4ca103c82c Fix problem in groups QA test 
The items should always be added to the group.
 2020-09-18 11:17:37 +01:00
PJM c8879d9034 Eeschema: Check if user wants to warp mouse to origin of moved object 
CHANGED: When moving a footprint, Eeschema was always warping the mouse
when moving an item regardless of the state of the "Warp mouse to
origin of moved object" checkbox.  This MR now honors the state of the
checkbox when moving schematic items.

NOTE: Issue 5279 originally only mentioned Pcbnew, but after the fix
for Pcbnew was submitted, a user pointed out it also happened in
Eeschema.  Becuase of this, there are two MRs that "fix" the same issue.

Fixes https://gitlab.com/kicad/code/kicad/issues/5279
 2020-09-18 02:49:59 +00:00