When active project flag is disabled, the application buttons are
disabled in the main launcher window. It usually happens when 'kicad'
runs without any project preloaded.
There is a significant difference in the behavior of wxFileDialog
between Windows and Linux (GTK+). On windows, wxFileDialog will
return the path chosen even if no file is selected. On Linux,
wxFileDialog returns the default path when no file is selected. This
caused the destination path to be the same path as the source which
was causing the issue. Use wxDirDialog instead so the selected path
is returned.
Fixes lp:1732759
https://bugs.launchpad.net/kicad/+bug/1732759
The GTK+ file dialog is case sensitive however it does support regular
expressions. Most of the file dialog wildcards are lower case so only
files with the lower case extensions will show up in the file dialog.
This code adds a method to convert file extensions of any case to the
appropriate (sch -> [sS][cC][hH]) regular expression on GTK+ builds so
all file extension case combinations will show up in the file dialog.
A note to developers: make sure to add a file extension when setting
when setting the default file argument. If you do don't set an
extension, the GTK+ file dialog will happily append the regular
expression as the file extension which is surely not what you want.
There are still a few known places (mostly gerbview) where there are
some complex wildcard code that has not been converted.
Fixes lp:1720542
https://bugs.launchpad.net/kicad/+bug/1720542
- Also makes the project and file import functions filetype dependent.
- The change from IO_MGR::KICAD to IO_MGR::KICAD_SEXP removes a conflict from a compile definition for KICAD when compiling kicad/import_project.cpp
Fixes: lp:1492577 (and probably also lp:1672116).
*https://bugs.launchpad.net/kicad/+bug/1492577
*https://bugs.launchpad.net/kicad/+bug/1672116
- Fixes a race condition causing the wrong page to be selected in
`OnPageChange`
- Allows the validate path and browse button to refresh the
template page even when the path was not changed. This is needed
since on OSX the page needs to be active for the templates to be
rendered.
Add tests to check for existing files before copying template files.
Split load project, create new project, create new project from template,
and load project from history command events into simple methods that
perform the correct actions before loading the project. This greatly
simplifies the code.
Create a load project method that can be called from the event handlers
above. This simplified a lot of duplicate code that existed in many of
these event handlers.
Remove the dummy "noname.pro" file creation which created required some
ugly code to prevent this file from being created unexpectedly. Now
KiCad launches without setting a project file name when appropriate.
Fixes lp:1713951
https://bugs.launchpad.net/kicad/+bug/1713951
The executable name constants are only used by two files, they do not
have to be in common.h.
Also converted to const wxString for better type-safety and removed
old-style wxT macros.
This function is called only from three sites, it doesn't need to be in
common.h.
The implementation was already in systemdirsappend.cpp, so a matching
header was created for it.
This reduces the visibility of the function to only the files that need
it and slightly shrinks common.h.
eeschema now supports arbitrary colors for all object types, and
pcbnew does in GAL canvas. When switching from GAL to legacy canvas,
pcbnew will convert colors to the nearest legacy color.
bitmaps.h was included in nearly every file in the project due to it
being included by base_struct.h
Only about 130 files actually use the XPM definitions defined there, and
many of those already included bitmaps.h themselves, or via
menu_helpers.h. However, touching bitmaps.h would result in over 400
rebuilt files for pcbnew alone.
This commit moves the bitmap-related types like BITMAT_DEF out to a new
header, which is still included by base_struct.h, which is less
avoidable for now, it's it's used in the interface.
The icon list is still in bitmaps.h. This has the side effect that's
it's now easier to automatically generate this file.
Many classes in pcbnew and eeschema needed some functions moved
to the implementaitons from the headers too.
wxNO_BORDER and wxSW_3D seem incompatible and the border flickers
when the tree frame gets resized. Using KICAD_DEFAULT_DRAWFRAME_STYLE
avoids this.
Signed-off-by: Clemens Koller <cko@embeon.de>
*) Extend SWIG support deeper into the BOARD class.
*) Move swig *.i files into a directory identified for SWIG, in preparation
for a parallel universe involving Phoenix's SIP.
*) Move swig files which will be common to both eeschema and pcbnew into
common/swig.
*) Sketch out a "common" python module, and plan on dovetailing that into a
libkicad_shared.{dll,so}
*) Add common/swig/ki_exceptions.i and define a macro HANDLE_EXCEPTIONS()
which is to be applied to any function which needs C++ to python
exception translation.
*) Move the test for SWIG tool into top level CMakeLists.txt file for use
in all python modules beyond pcbnew, i.e. eeschema and common.
*) Add SWIG_MODULE_pcbnew_EXTRA_DEPS which generates a better Makefile, one
which rebuilds the swig generated *.cxx file when one of its dependencies
change.
*) Re-architect the board.i file so that it can be split into multiple *.i
files easily.
*) Make some KIWAY from python progress, in preparation for Modular KiCad
phase III.
* Deleting the wxFileSystemWatcher when switching from a remote project to
a local project caused KiCad to segfault. Switching from a local project
to a remote project did not cause KiCad to crash. The fix was to clear all
of the file system watcher paths instead of deleting and creating a new file
system watcher object between project changes. The object still crashes on
exit when deleted in the main window dtor. Allocating the file system
watcher object on the stack instead of on the heap did not make any difference.
* An assumption was made that wxDynamicLibrary.Load() would always result in
a wxLogSystemError on failure which was not always true. The code now throws
an exception which is caught by KiCad and an error message is displayed. In
the case where the wxLogSystemError is shown, there will be an annoying two
error messages but that is better than a crash.
Maciej Suminski
jean-pierre charras
Wayne Stambaugh
Marvin Schmidt
Russell Oliver
Fabrizio Tappero
Seppe Stas
Michael Kavanagh
metacollin
Oliver Walters
John Beard
Chris Pavlina
Jon Evans
Clemens Koller
Cirilo Bernardo
Simon Richter
Dick Hollenbeck
Wayne Stambaugh