haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
15,940 Commits 9 Branches 105 Tags 1.3 GiB
Commit Graph

15940 Commits

Author SHA1 Message Date
Jeff Young 8518c373d1 Move PLEditor to common actions for file ops. 2019-05-25 01:34:44 +01:00
Jeff Young a3dfce5adb Implement common file menu actions and move Eeschema over. 2019-05-25 01:14:21 +01:00
Jeff Young ba4ba5b668 Implementing boundingbox getters for WS_DRAW_ITEMs. 2019-05-24 21:23:26 +01:00
Jeff Young a6dee516fd Fix issue with LAYER ids and bitfields. 2019-05-24 21:23:26 +01:00
Jeff Young a1b3e5d9bb Move PLEditor title updating to somewhere it will get called. 
Also cleans up some uncalled stuff.
 2019-05-24 21:23:26 +01:00
Jeff Young 94c8e84d3b Make sure PCB document is opened when doing an update. 
Fixes: lp:1830256
* https://bugs.launchpad.net/kicad/+bug/1830256
 2019-05-24 21:23:26 +01:00
Jeff Young a73f3fe36d Use a bigger hammer when changing plEditor display mode. 2019-05-24 21:23:26 +01:00
Michael Kavanagh 741140e4a4 Fix footprint marked as modified when layer visibility changed 
Fixes: lp:1830330
* https://bugs.launchpad.net/kicad/+bug/1830330
 2019-05-24 16:13:22 -04:00
Seth Hillbrand 7058b79bf1 pcbnew: Fix assert in debug build 
Previously we saved the visibility as a mask of 32bits and the check was
needed.  These are now saved as per-layer setting, so the assert is
extra.
 2019-05-24 12:39:01 -07:00
Seth Hillbrand f0352176ec Fix a compile error in Linux 
Operands to the ternary operator cannot have different types under g++
(linux)
 2019-05-24 12:12:10 -07:00
jean-pierre charras 32f25cf8b4 ACTION_MENU::appendCopy: Fix an issue on Windows with Check-able menu-items. 
The source bitmap was copied to the new created item.
However, for Checkable menu-items, when setting a bitmap, our standard check bitmap is also added.
This is unwanted when the source bitmap is the wxNullBitmap (bitmap sizes are different)
 2019-05-24 21:01:49 +02:00
jean-pierre charras 057366e97e Viewlib frame: make toolbar menu "List Hotkeys" working 2019-05-24 21:01:49 +02:00
Jeff Young 899c8ccc8d Highlight currently active inspector Apply button. 2019-05-24 19:49:10 +01:00
Jeff Young 71f188f3de Hook up import-page-layout and change-background-color actions. 2019-05-24 19:49:10 +01:00
Jeff Young 2901fee9a0 Improve property panel <> selection synchronization. 2019-05-24 19:49:09 +01:00
Jeff Young 85f984ccd9 Add point-editor activation for immediate-mode drawing. 2019-05-24 19:49:09 +01:00
Jeff Young 09424db68f Restore selection around undo/redo. 2019-05-24 19:49:09 +01:00
Jeff Young 431eae0492 Implement undo for PageLayout drawing tools. 2019-05-24 19:49:09 +01:00
Jeff Young 323bb0f8e1 Moving PageLayout editor to GAL canvas and modern toolset. 2019-05-24 19:49:09 +01:00
Michael Kavanagh 43a5bb72ca Fix swapped mirror icons in eeschema context menu 
Fixes: lp:1828631
* https://bugs.launchpad.net/kicad/+bug/1828631
 2019-05-24 13:12:58 -04:00
jean-pierre charras 40382f4d52 Viewlib: menubar/view menu: make grid select working 
Set also a better icon for this menu item
 2019-05-24 15:49:51 +02:00
jean-pierre charras 944ecc8913 Remove unused vars. 2019-05-24 15:21:40 +02:00
John Beard 2ec4ceffbd Reinstate "QA: Tweak boost print helper macro"" 
This reverts commit 3afea91088.

This was actually not the issue, even though it seemed to trigger the
issue.
 2019-05-24 13:23:51 +01:00
John Beard a88ac393bb QA: Remove helper function 
The InOutString function is not really useful, in most cases it can
be done more simple with string operator+. This function is causing
issues on MSVC (perhaps the template param names) anyway.
 2019-05-24 13:23:51 +01:00
Wayne Stambaugh 816f6db310 Pcbnew: Python scripting support clean up. 
Always check the return value of PyRun_SimpleString() for errors when a
Python script is run and show an error message rather than fail silently.

Enable Python interpreter I/O redirection in debug builds so that script
string errors will be shown when PyRun_SimpleString() is called.

Do not call PyErr_Print() after a PyRun_SimpleString() call failure.  It
doesn't do anything useful.

Do not call Py_Finalize() after a PyRun_SimpleString() call failure.  It
seems to cause Pcbnew to crash.
 2019-05-24 07:32:38 -04:00
jean-pierre charras 4ae5a006d0 Viewlib: fix minor issues. 2019-05-24 12:54:11 +02:00
jean-pierre charras e3815381ab Viewlib: register missing EE_SELECTION_TOOL. 
This tool is needed to manage the View menu.
 2019-05-24 11:28:39 +02:00
jean-pierre charras e957fb403b eda_draw_frame.cpp: fix missing EVT_MENU_CLOSE capture, that can create crashes. 
in this case the crash can happens because a menu pointer used in EVT_MENU_HIGHLIGHT
is not cleared when closing the menu
 2019-05-24 10:22:09 +02:00
Jon Evans 4c33320cbc Stop erroneously accepting bus alias labels without curly braces 2019-05-23 23:06:51 -04:00
Jon Evans 4e6c9ac7b1 Remove defunct junction code that left some isolated 
Fixes: lp:1828716
* https://bugs.launchpad.net/kicad/+bug/1828716
 2019-05-23 22:58:46 -04:00
Jon Evans 8c89847627 Properly handle tildes at the end of bus vector names 
Fixes: lp:1825532
* https://bugs.launchpad.net/kicad/+bug/1825532
 2019-05-23 22:47:01 -04:00
Jon Evans ab3ada5200 Clear moving flag for second-click-placed items 
Fixes: lp:1830227
* https://bugs.launchpad.net/kicad/+bug/1830227
 2019-05-23 21:51:14 -04:00
John Beard 3afea91088 Revert "QA: Tweak boost print helper macro" 
This reverts commit 593b7cd6a1.

This causes breakage on MSVC. I am not sure sure why, but
this is not that important, so just back it out.
 2019-05-23 23:31:03 +01:00
Jeff Young 924736c6f3 Make sure PCBNew is open when running F8. 
Fixes: lp:1830256
* https://bugs.launchpad.net/kicad/+bug/1830256
 2019-05-23 22:57:53 +01:00
Jeff Young 39bb4b639f Fix crash with opening find dialog twice. 
Fixes: lp:1830224
* https://bugs.launchpad.net/kicad/+bug/1830224
 2019-05-23 22:57:53 +01:00
Jeff Young ebd8c44eee Don't confuse SCH_ITEMs and LIB_ITEMs. 
Fixes: lp:1829826
* https://bugs.launchpad.net/kicad/+bug/1829826
 2019-05-23 22:57:53 +01:00
John Beard 241127788e Format: add some formatting aliases, improve dev docs 
The aliases are easier than calling check_coding.sh manually,
and we already provide an alias file for the fixes alias, so
do the same for these.
 2019-05-23 21:28:42 +01:00
John Beard 073c03e61f Common: declare COLOR4D inside KIGFX 
Forward declaring as just COLOR4D is no right, though can
work due to people putting using directives in headers.
 2019-05-23 19:35:20 +01:00
jean-pierre charras ce93934f08 Pcbnew, ZONE_FILLER: fix incorrect test to remove filled areas outside the board edge cuts. 
This incorrect test was only for zones with no net.
 2019-05-23 20:22:03 +02:00
John Beard 2c55091a74 QA: Adjust bitmap test bitmap 
For some reason, older WXs on Linux (e.g. Ubuntu 16.04) would
segfault on loading the 4-tile test image. Change one tile to
a circle to fix this (presumably an old and fixed image library
function).
 2019-05-23 18:59:20 +01:00
Ian McInerney 0daf14f9c3 pcbnew: Fixed listing of 3D libraries in the github wizard 
Fixes: lp:1830137
* https://bugs.launchpad.net/kicad/+bug/1830137
 2019-05-23 09:50:05 -07:00
Seth Hillbrand 1a56dfe342 Plotter: Ensure group style is respected in SVG 
Graphics Changed is cleared when setting graphics for a group but needs
to be reset when the group ends.

Fixes: lp:1830245
* https://bugs.launchpad.net/kicad/+bug/1830245
 2019-05-23 09:40:35 -07:00
John Beard 2dd5757eb5 Common: Fix copy-construction of empty BITMAP_BASE 
The bitmap pointer is not checked at copy construct. This is
an instant segfault if you copy an empty bitmap.

Fix the constructor and remove the expected test failure, from the
previous commit.
 2019-05-23 16:58:08 +01:00
John Beard d642ac39ae Common: Bitmap base: catch copy segfault 
Copying an empty image is not checked for nullity,
so it will segfault. Introduce a test for this case,
for fixing as a follow-up.
 2019-05-23 16:58:08 +01:00
jean-pierre charras 872c8ca37b Remove a duplicate icon. 2019-05-23 16:21:06 +02:00
John Beard 94b46ce176 QA common: add some BITMAP_BASE tests 
Also:

* Init wx image handlers for qa_common
* Break out COLOR4D test predicates
* Fix some bitmap_base.h headers/forwards
 2019-05-23 15:19:51 +01:00
John Beard 593b7cd6a1 QA: Tweak boost print helper macro 
By making the caller use the "namespace" keyword, the formatter
is given the right indentation hints.

Also makes it clearer synatactically. One day, this will be a
namespace alias (needs GCC 7).
 2019-05-23 14:37:35 +01:00
Wayne Stambaugh c52ff1ca23 Symbol Editor: fix datasheet field bug loading old symbol libraries. 
This only applies to the root symbol when the datasheet field is not
empty and the datasheet for root symbol alias in the document file is
empty.  Use the root symbol datasheet field value when adding a new
symbol that meets this criteria.

The root symbol datasheet field gets copied to the root symbol alias
datasheet member variable so if the symbol is modified and saved, the
datasheet information is saved in the .dcm file.

https://bugs.launchpad.net/kicad/+bug/1830078

Fixes lp:1830078
 2019-05-23 09:00:50 -04:00
John Beard a045642b7e Sexpr: Do not leak memory on parse exception 
Use std::unique_ptr to guard against leaking the new'd pointers
in SEXPR lists if there is an exception during parse.

This was noticable during the Sexpr/ParseExceptions unit test.

Fixes: lp:1830209
* https://bugs.launchpad.net/kicad/+bug/1830209
 2019-05-23 13:52:39 +01:00
jean-pierre charras 83e08c9277 Fix crash in Eeschema when clicking on a menubar item. 
It happens if an other frame (libedit) was opened, a menubar clicked, an this frame was closed.
 2019-05-23 13:35:12 +02:00