Before, we did not actually prevent users from adding a field also named
Quantity to their symbols. This of course does not play nicely with the
assumptions that Quantity is a special column in the fields editor.
By making it a named variable, the user can safely add it to a symbol
and it will not be editable, and will also work in the fields table
editor as expected.
Simple recursion of variable expansion allows for multiple use cases in
portability of designs. This also includes basic prevention of
recursion loops
Fixes https://gitlab.com/kicad/code/kicad/issues/10398
Older boards use older 3d model environmental variables. We need to
support both older environmental variables (if the user has them) as
well as updated environmental variables (if the user only has a single
3d model path)
This updated the environmental resolver to look first in the named
location and then substitute the new location if the old location is not
defined in the environment
Fixes https://gitlab.com/kicad/code/kicad/issues/10674
EDA_ITEMs are responsible for giving their parent a crack at it if
they failed to resolve it. This recurses all the way up to the schematic/
board, and then to the project.
Cross-reference handling is also move to the EDA_ITEMs. It must be done
before bubbling up so that we don't end up in loops. (The aDepth parameter
will break the loop, but without having done anything useful.)
Fixes https://gitlab.com/kicad/code/kicad/issues/13541
Also removes a bunch of std::string stuff from the file handling in the
simulator. All our file handling, env variable expansion, project path,
etc. stuff is wxString based, and jumping through std::string in between
just makes it more complex and increases the potential bug surface.
Also fixes a bug where you'd get two error messages when a spice model
library wasn't found.
Also fixes a bug where you'd get a spice model library not found error
when the text field was empty.
Also fixes a bug where we'd try to absolutize a path starting with an
unresolved text or environment variable. If the path starts with a
variable it's probably absolute, and tacking on the project path in the
error message just obfuscates things.
Fixes https://gitlab.com/kicad/code/kicad/issues/13082
Jon Evans
Mike Williams
Jeff Young
Seth Hillbrand
Mikolaj Wielgus
Wayne Stambaugh
david-beinder
Marek Roszko
Roberto Fernandez Bautista
jean-pierre charras
RigoLigoRLC
Ian McInerney