b5fd9e830f
A bit more safety around disabling the event handler.
2018-09-29 23:05:43 +01:00
2eea45b50c
Go back to earlier strategy for net selector popup.
...
This version makes use of lots of things learned going down the
other rat hole. Avoiding the wxComboFocusHandler is key, as well
as specifying using the AltPopupWindow.
The key handler is still tricky with respect to those platforms
that use native controls, but the starting-key strategy is similar
to the one used with wxGrid text editors.
2018-09-29 22:07:31 +01:00
3c2aafd7b7
Move Edit Symbol References to standard text/button control.
2018-09-29 22:07:31 +01:00
26838c6800
Pcbnew: Crash after running external plugin
...
Happens only in Opengl mode.
So enforce controls in 3 group function: DrawGroup, ChangeGroupColor, ChangeGroupDepth.
Fixes: lp:1795044
https://bugs.launchpad.net/kicad/+bug/1795044
2018-09-29 12:58:47 +02:00
5843b1a6a1
Possible solutions to <enter> and keyboard activation on GTK.
2018-09-29 10:28:19 +01:00
3f6819e592
Improve visiblity of net selector popup.
2018-09-28 22:39:42 +01:00
0a43584c5c
Another attempt to catch enter on GTK, and better button processing.
2018-09-28 19:36:50 +01:00
704615721f
Prevent segfault when undoing or resetting non-hotkey rows
...
This is caused by:
* Not checking the hotkey data is not null when performing a
hotkey action
* Allowing hotkey actions on non-hotkey rows.
This fixes both of these, and adds an assert to warn if someone
does manage to fire a hotkey action on a non-hotkey row (but it
won't crash).
Fixes: lp:1794756
* https://bugs.launchpad.net/kicad/+bug/1794756
2018-09-28 08:28:30 -04:00
a294e8d6c4
Check for conflicts when reseting/undoing hotkey changes
...
It was possible to get conflicting hotkeys when undoing and resetting hotkeys
to defaults.
This uses the same logic as when setting hotkeys to avoid conflcits in these
other two cases.
Fixes: lp:1794730
* https://bugs.launchpad.net/kicad/+bug/1794730
2018-09-28 08:28:22 -04:00
3283bd9fdc
Mark modified hotkeys in the hotkey editor
...
THis uses a simple " *" suffix, as the wxTreeListCtrl-derivative
widget doesn't allow easy access to things like font style.
2018-09-28 08:28:16 -04:00
9f38b70491
Add a filter box to hotkey dialog and filter using it
...
This uses a simple case-insensitive partial match, which is
a good start for the relatively limited number of hotkeys
generally present.
2018-09-28 08:28:04 -04:00
4f0166e064
Add some hotkey store tests
...
This also adds some mocks to the libcommon test executable, which
hopefully will allow it to work with more of libcommon.
2018-09-28 08:27:57 -04:00
1f2c8fa698
Separate storage at iteration of hotkeys from the HK list widget
...
This separates the "ground truth" store of hotkeys from what is shown
in the dialog. This will allow us to filter the displayed hotkeys
while keeping the same underlying data structures.
Now, the UI data items interact with an intermediate set of data, which
represents the "original" hotkey data, and the "changed" data. The
ultimate aim here is to allow UI elements to come and go, but the
hotkeys that are "in-edit" are preserved.
This also allows us to abstract some bookkeeping complexity
out of the WIDGET_HOTKEY_LIST class into a separate non-GUI
class.
2018-09-28 08:27:51 -04:00
3927dc5820
More fixes for event handling in net selector.
2018-09-28 00:23:22 +01:00
453dadbc3c
Use EventFilter strategy on GTK; leave FocusLost for MSW & OSX.
2018-09-27 20:42:59 +01:00
136525b870
Decrease list-item padding for GTK.
2018-09-27 18:58:32 +01:00
5703060d87
Turn off escaping names for now.
...
Fixes: lp:1794816
* https://bugs.launchpad.net/kicad/+bug/1794816
2018-09-27 17:21:49 +01:00
50b96b406f
More net selector fixes.
2018-09-27 16:58:12 +01:00
3ae049c729
Address some MSW issues in net selector.
2018-09-27 14:44:42 +01:00
f10635e8be
More work on arbitrary characters in references, etc.
2018-09-27 14:44:42 +01:00
4a553b6423
NET_SELECTOR fix: remove SetHint() because it does not work on Windows, that prevents filtering.
...
Replaced by a wxStaticText
Minor cosmetic fixes (on Windows)
2018-09-27 13:19:09 +02:00
521183a587
Work in progress to allow arbitrary chars in references, etc.
2018-09-27 11:56:51 +01:00
eaf3d48260
Simplification of the net selector code to fix GTK issues.
2018-09-27 11:52:58 +01:00
d1e64919a7
Fix for GTK net selector popup border.
2018-09-26 22:50:27 +01:00
f7ffbb17bb
Another try at the net selector popup.
2018-09-26 21:57:35 +01:00
04a1084549
QA: Place UTF8 tests under Boost unit tests
...
This transfers the old #if'd-out tests in utf8.cpp into a
proper Boost unit test in /qa (run on `make test`).
2018-09-26 09:32:26 -04:00
86b654e493
Hook up 3D viewer to common preferences.
...
Also removes nanny limits on text sizes.
Fixes: lp:1794093
* https://bugs.launchpad.net/kicad/+bug/1794093
Fixes: lp:1794345
* https://bugs.launchpad.net/kicad/+bug/1794345
2018-09-25 20:47:03 +01:00
3cc6e0cf02
Fixes to NET_SELECTOR event loop for non-OSX platforms.
...
Don't assume events are always Pending(). Other platforms handle
idle events differently.
2018-09-25 17:56:38 +01:00
37f7faf433
Move lock checks to CLIENT_SELECTION_FILTER.
...
Also checks render item visibility as well as layer visibility
when making selections.
Fixes: lp:1066220
* https://bugs.launchpad.net/kicad/+bug/1066220
Fixes: lp:1541756
* https://bugs.launchpad.net/kicad/+bug/1541756
2018-09-25 17:56:38 +01:00
66848b9334
Show pads when parent footprint is selected.
...
Fixes: lp:1670090
* https://bugs.launchpad.net/kicad/+bug/1670090
2018-09-23 23:51:13 +01:00
ae13e441af
pcbnew: Yield in GTK for redraw
...
GTK uses a level of cooperative multitasking when dealing with
secondary event loops. This gives the wm enough leeway to process the
redraw before returning to the secondary loop
2018-09-22 19:38:42 -07:00
cbce4d7663
Work around a stupid assert in GTK wxGUIEventLoop::Dispatch()
2018-09-22 19:38:42 -07:00
0309228276
Don't allow drawing to a zero-height or zero-width GAL canvas.
...
Fixes: lp:1793913
* https://bugs.launchpad.net/kicad/+bug/1793913
2018-09-22 22:06:40 +01:00
458af25282
Turn problematic code off for now....
2018-09-22 17:54:59 +01:00
4edf18b023
Attempt to fix Linux build issue.
2018-09-22 17:41:52 +01:00
5974899fa5
Clean up file locations and names.
2018-09-22 16:23:13 +01:00
666da3849b
Make esc dismiss net and layer selector popups.
2018-09-22 16:23:13 +01:00
f8784f30a8
Removing OpenMP
...
This commit finishes the removal of OpenMP from the KiCad codebase.
Removed in this commit are the OpenMP calls in 3d-viewer and
qa/polygon_triangulation as well as all references in CMakeLists.txt
std::thread is used instead for multithreaded computation
2018-09-21 12:44:20 -07:00
21485e6f24
kicad_curl should be built only with BUILD_GITHUB_PLUGIN enabled
2018-09-21 12:44:20 -07:00
42ab116bc2
Rewrite the NET_SELECTOR combobox in the hopes of better platform support.
2018-09-21 20:40:04 +01:00
e985f797c3
Return reference to current object from operator=
2018-09-21 05:03:30 -07:00
8c3a82e526
Code cleanup: Fixing assignment operators
2018-09-20 20:15:47 -07:00
cd5b1c2885
set_wxMenuIcon: prevent null pointer dereference
2018-09-19 14:07:50 +02:00
e485cee384
Honour ModEdit layer colors in browser and previews.
...
Fixes: lp:1793141
* https://bugs.launchpad.net/kicad/+bug/1793141
2018-09-18 19:14:35 +01:00
9e33d38cd5
unit_binder: allow updates without triggers
...
Adds a helper function to allow unit binder calls that change a value
but shouldn't trigger wxevents
2018-09-17 15:55:22 -07:00
aacb3f9075
Update translators list to include simplified Chinese translator.
2018-09-17 10:12:03 -04:00
e45afdb912
Revert absolute-path asserts and fix off-by-one bug.
...
Fixes: lp:1767582
* https://bugs.launchpad.net/kicad/+bug/1767582
2018-09-15 22:36:09 +01:00
02a3f83040
Implement poor-man's RTTI for use over KiWAY.
...
Fixes: lp:1777883
* https://bugs.launchpad.net/kicad/+bug/1777883
2018-09-15 20:06:42 +01:00
872e1e6532
Remove asserts for absolute paths.
...
You can, for instance, specify relative paths via the command
line.
Fixes: lp:1767582
* https://bugs.launchpad.net/kicad/+bug/1767582
2018-09-15 20:06:42 +01:00
af2dcd61bb
Fix build error against head of wxWidgets master branch.
...
The wxTreeCtrl header file wx/treectrl.h needs to be included in
common/widgets/paged_dialog.cpp.
2018-09-14 10:49:54 -04:00
Jeff Young
jean-pierre charras
John Beard
Seth Hillbrand
Fabio Rossi
Simon Richter
Maciej Suminski
Wayne Stambaugh