6225ef69b6
Altium schematic import: fix power ports.
...
Use different symbol names for different port port styles.
Also fixes curved shapes construction.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16823
2024-01-31 08:22:27 +03:00
c64b74918f
Altium schematic import: put Template items on sheet.
...
So we can use variable resolution.
2024-01-31 07:00:02 +03:00
9ed735ef5d
Fixes for Altium/CircuitStudio schematic import
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16825
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16824
Adds support for Templates.
Also fixes symbols on schematic with multiple display modes.
2024-01-31 02:07:06 +03:00
a3e6e08d92
Spice Simulator : update simulation after tuning cursor moved by arrow keys.
...
Fixes #16808
https://gitlab.com/kicad/code/kicad/-/issues/16808
2024-01-30 15:57:46 +01:00
94cb00392e
Repair connectivity if bus aliases changed.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16503
2024-01-30 14:16:55 +00:00
b77709bb4d
Formatting.
2024-01-30 14:03:38 +00:00
ee5e2e56c0
Naming conventions; no functional changes.
2024-01-29 16:00:06 +00:00
00aed2aa3e
Don't attempt to test for recursion on unsaved file.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16722
2024-01-28 15:37:08 +00:00
92308698ba
Coding policy fixes.
2024-01-28 09:26:46 -05:00
2f0337974b
Update schematic connectivity when redoing changes.
...
Apparently we forgot to handle schematic connectivity changes when redoing
undone changes. The same connectivity update logic that was added to the
commit object is now used in SCH_EDIT_FRAME::PutDataInPreviousState().
Please note the granularity of connectivity rebuilds on schematic object
property changes is at the object level which is overly aggressive. This
means that connectivity rebuilds will happen when connectivity changes
that have nothing to do with and objects connectivity are changed. Until
objects can handle their own connectivity state, this will have to suffice.
2024-01-27 12:02:53 -05:00
c0cbaa4c53
Finish earlier commit that somehow escaped my notice.
...
(String is existing.)
2024-01-27 15:55:05 +00:00
d2f0acae6b
Expose pin visibility to property manager.
...
Also re-orders properties in Pin Properties dialog order.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16785
2024-01-27 15:52:59 +00:00
ad1a929404
Do not mark an empty string as translatable
...
It is not accepted by our tools
2024-01-27 09:06:03 +01:00
ceb8beb8c4
Move ChangeBodyStyle and CleanupSheetPins to SCH_COMMIT.
...
Also fixes a bug where showDeMorganAlternate didn't work
at all.
2024-01-26 22:29:51 +00:00
fb8f05fb34
Correctly report body style in symbol checker.
...
Also fixes a bug where off-grid pin locations were truncated.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16770
2024-01-26 18:11:23 +00:00
cc9f8f5b83
Fix a straggler from rename.
2024-01-26 18:01:22 +00:00
bcad0761a4
Fix compile error
2024-01-26 08:35:11 -08:00
ae735d3eb4
Renaming: replace convert with body-style.
...
No functional changes.
2024-01-26 16:21:03 +00:00
8975f26c26
Coding policy fixes.
2024-01-26 08:59:14 -05:00
c39bec4c08
SCH_FIELD.Visible can be unmasked
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16760
2024-01-26 08:54:04 -05:00
e99f758447
Revert b8a2b3b2bf.
2024-01-26 12:33:21 +00:00
12357cfba6
symbol checker: do not forget to display error messages about pins not on grid.
...
Fixes #16759
https://gitlab.com/kicad/code/kicad/-/issues/16759
2024-01-26 10:19:58 +01:00
74e02d7701
Eeschema, open CvPcb: ensure the netlist sent to CvPcb is up to date.
...
Fixes #16762
https://gitlab.com/kicad/code/kicad/-/issues/16762
2024-01-26 09:24:38 +01:00
ec82a1b4e2
Fix duplicate pin check string
...
MessageTextFromValue returns text not floating point
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16758
2024-01-25 18:02:05 -08:00
c2989132ac
DeselectRow as we delete rows to avoid asserts
2024-01-25 20:37:00 -05:00
bba0a8d038
Protect schematic undo list actions
...
The undo/redo lists can have non-SCH_ITEM elements such as worksheet
items. When re-doing connectivity, we only need the schematic items, so
we pass on these
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16752
2024-01-25 16:47:14 -08:00
b8a2b3b2bf
Take a stab at fixing #16752 .
2024-01-25 23:46:35 +00:00
4d6bbc8caa
Fix symbol annotation when pasting nested hierarchical sheets.
2024-01-25 16:39:21 -05:00
2e760483b0
HIERARCHY_PANE: Update tree labels when editing a sheet name or number
...
Fixes #16650
https://gitlab.com/kicad/code/kicad/-/issues/16650
2024-01-25 18:22:41 +01:00
a2b204572d
Don't assert when a sim returns no results.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16749
2024-01-25 15:40:12 +00:00
70bca8bc4e
Provide popups for inductor references.
...
Also fixes a long-standing bug deleting the last field of
a symbol in the Symbol Editor.
2024-01-25 15:30:25 +00:00
340d1b7fad
Guard against nullptr access.
2024-01-25 15:30:25 +00:00
c816280c6d
Move the current selection before deleting the row to avoid asserts
...
Fixes sentry KICAD-63D
2024-01-24 22:57:36 -05:00
b8bbbcf410
Fix assert in SYMBOL_VIEWER_FRAME::onSelectNextSymbol due to bad current selection check
...
Fixes sentry KICAD-6KE
2024-01-24 20:15:23 -05:00
5d7eac7677
Allow for empty LIB_PART in certain symbol functions
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16731
2024-01-24 12:18:10 -05:00
b8b4ea1a45
Comments.
2024-01-24 16:24:19 +00:00
d04b21c6d6
Ensure parameter typeinfo matches the actual object's typeinfo
...
AppleClang seems to generate different typeinfo for forward declarations
of classes than the actual class object, so the any_cast for the pointer
parameter fails due to the types not matching (even when they look the
same when printed in the error).
Instead, we must always ensure we use the actual object when defining
the parameter type when placing the object into the event.
2024-01-24 16:14:32 +00:00
6407576cb9
Convert between refs and KIIDs in Symbol Properties.
2024-01-24 11:02:56 +00:00
ddc2092dac
Eeschema: Autoplace fields offset correction
...
No longer count fields without 'Allow automatic placement'
toward the Autoplace offset.
Fixes https://gitlab.com/kicad/code/kicad/issues/16588
2024-01-24 00:24:16 +00:00
c7475a16c8
implemented better caching for categories and parts overview to reduce processing time
2024-01-23 22:32:05 +00:00
d96ebf5745
Remove paste sheet instance path debugging output.
2024-01-23 16:04:08 -05:00
8d2784b822
Eeschema, hierarchy navigator: right click on an item must select the corresponding
...
sheet, not the currently opened sheet.
Fixes #16670
https://gitlab.com/kicad/code/kicad/-/issues/16670
2024-01-23 18:13:03 +01:00
e549d7c0c6
Formatting and clearer variable names.
...
(No functional changes.)
2024-01-23 16:02:30 +00:00
a263b6d343
Mutual inductance statements have no model.
2024-01-23 15:14:09 +00:00
1bd8da41a7
Mutual Inductor isn't an inductor.
...
It's a statement about two other inductors.
2024-01-23 15:07:29 +00:00
a836a66170
Update labels when editing field names.
...
This is yet another path for getting duplciate fields
when changing the case of an existing field name.
2024-01-23 14:58:56 +00:00
9935a022cd
Fix typo in OnRenameField() that can cause OOB access.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16625
2024-01-23 14:02:13 +00:00
179ab1011f
Don't use canonical name for user fields with an id of -1.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16715
2024-01-23 13:42:17 +00:00
8b56b3d999
Formatting.
2024-01-23 13:42:17 +00:00
b3a36bd783
Fix overly aggressive sheet instance pruning.
2024-01-23 07:44:45 -05:00
4cf22e428c
Fix broken pasted sheet page numbering.
...
This change no longer sorts pasted sheets by page number. This was done
because pasted sheets may not be numbered. When sheets are not numbered
they are sorted by UUID path which results in some unexpected results.
Since the pasted sheet code uses recursion, pages will be numbered in the
order they are added.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16580
2024-01-22 16:55:43 -05:00
43a3ed2522
Don't hardcode symbol library stub when converting library
...
Also, make sure options column is set back to blank
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16706
2024-01-22 22:52:40 +01:00
85f0dd279c
Push fileFilter callback function down a level.
...
(The GRID_CELL_PATH_EDITOR is shared by the whole column.)
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16707
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13959
2024-01-22 18:27:31 +00:00
f63c7806fd
More bitmap bundle comboboxes
2024-01-21 22:55:13 -05:00
059b043935
Try and walk from a real component pin rather than power symbol that will fail our later check
2024-01-21 21:12:14 -05:00
caf463bbd2
Pass KiBitmapBundle instead of KiBitmap to the pin property comboboxes
...
Related https://gitlab.com/kicad/code/kicad/-/issues/16698
2024-01-21 20:47:46 -05:00
fb8dc75108
Fix broken conditional check while walking global power connected items
...
Per the if statement and logic, we want to walk into looking up connections if we are a pin on a chip.
IsGlobalPower is a test for it's in a power symbol, so we want it false not true.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16699
2024-01-21 19:54:09 -05:00
1981997ee2
Dump the ERC report as part of the erc failure
2024-01-21 16:10:43 -05:00
e58615952c
Fix delimeter -> delimiter typo in translated strings
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/16673
2024-01-21 13:44:43 -05:00
2cfb7a5310
Incremental schematic connectivity fixes.
2024-01-21 16:53:05 +00:00
5c4313587b
Attempt to fix hierarchy tree selection issue.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16670
2024-01-20 19:25:18 +00:00
7687f240a2
Prevent footprint editing in power symbols
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16663
2024-01-19 12:52:03 -08:00
ac4f9dc97a
Initialize shared sheet instance page no's in drawing tool.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16580
2024-01-19 18:45:46 +00:00
4d80da8238
Separate symbol angle and mirroring in prop manager.
2024-01-19 13:40:56 +00:00
f80094e7c5
Warn the search pane that pointers are going invalid
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16612
2024-01-18 17:50:50 -05:00
6361995412
Beef up property manager access to SCH_SYMBOL.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16640
2024-01-18 16:17:46 +00:00
61876533df
Clean up formatting.
2024-01-18 16:17:46 +00:00
7b24167398
FromDIP symbol and footprint editor aui panes
2024-01-17 23:08:38 -05:00
f5db4d6864
Remove the invalid default dock directions for search panel
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16636
2024-01-17 22:26:04 -05:00
1c6d7a5fa5
Sprinkle FromDIP in SCH_EDIT_FRAME aui setup
2024-01-17 22:05:54 -05:00
4d1a016429
HTTP Libraries: Improved cache performance
2024-01-18 02:33:16 +00:00
ba6979a274
Fix pin check to allow for globals
...
Don't short-circuit adding global labels to the pins vector or we won't
search all subnets
2024-01-16 16:35:47 -08:00
8fea4812f3
Don't count power flags as sinks/sources
...
Just because we have a power flag on a net does not mean that there are
more than 1 pin
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13469
2024-01-16 15:24:32 -08:00
b4bfdf95d3
Explicitly add 48, 128, 256 to icon bundles for each app
2024-01-16 17:21:44 -05:00
76e8ed2506
Fix sch_field and pcb_target not returning evaluated similarity correctly
2024-01-16 15:43:49 -05:00
3bbf45dccb
EasyEDA Pro: resolve device attribute variables in schematic.
2024-01-16 23:40:00 +03:00
42255f10c3
EasyEDA Pro: fix default netport orientations.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16620
2024-01-16 22:47:15 +03:00
4f6c25895e
Rename UNKNOWN in enums to prevent shadowing.
2024-01-16 19:14:57 +03:00
07fa42644d
SCH_PAINTER: fix a few minor issues related to Cairo print engine
...
- shows correctly hidden power pins unconnected circle
- do not print dangling indicators
- do not print highlight shadows.
Fixes #16615
https://gitlab.com/kicad/code/kicad/-/issues/16615
2024-01-16 16:30:55 +01:00
f99505e190
Fix arc editing bugs when endpoints match.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16532
2024-01-16 16:17:45 +03:00
5bd620d8f9
Support Bezier curve editing in eeschema.
2024-01-16 14:11:25 +03:00
57bc443f0b
Fix HPGL color mode being set.
2024-01-15 22:35:35 +03:00
01e88d33aa
Fix Bezier reading in schematic as well.
2024-01-15 22:35:35 +03:00
ad7258721b
Initialize SCH_SHEET members earlier.
...
m_borderWidth is used for autoplacing fields.
Fixes sheet filename being in extreme locations in some cases.
2024-01-15 22:35:35 +03:00
d3f40dde3f
Fix assertion when pasting schematic sheets.
...
Pasted sheets do not have assigned SCH_SCREEN objects until after they
are loaded.
Do not recalculate connectivity unless the SCH_COMMIT object actually has
connectable schematic object changes.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16579
2024-01-15 12:15:30 -05:00
4fac43d696
Fix variable substitutions in library tables.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16601
2024-01-15 09:53:08 +03:00
b7460f29b4
Altium schematic: fix properties parsing in old formats.
...
Leading "|" can be missing before "RECORD=28" in old formats.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16513
2024-01-14 13:12:47 +03:00
4e3d2a148d
Fix typo
2024-01-12 14:51:32 -08:00
c18bfe0c61
DIALOG_DRC & DIALOG_ERC: re-enable button "Run ERC" and "Run DRC" after running tests.
...
Fixes #16583
https://gitlab.com/kicad/code/kicad/-/issues/16583
2024-01-12 15:38:25 +01:00
2aab24ef29
Prevent multiple reloads when saving
...
Avoid potential issues with Mac libedit crashes (hopefully)
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14865
2024-01-11 19:01:31 -08:00
0df8d5c2d6
Do not assert when pruning orphaned sheet and/or symbol instances.
...
Running the schematic editor in the stand alone mode can result in an
empty project name. Rather than assert when the project name is empty,
just don't run the pruning algorithm. The pruning will just have to
happen on the next load of the schematic when it has a proper project
name.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16577
2024-01-11 15:47:21 -05:00
382fe3de09
Symbol Fields Table: fix regroup button using schematic values
...
Should use the datastore where possible since users are using this to
regroup before applying the data.
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/16574
2024-01-11 12:01:12 -05:00
4b1fc9c129
Update AM and SFFM source parameters to ngspice-43.
...
Note: there's no migration strategy because they didn't
work at all prior to ngspice-43.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16529
2024-01-10 20:27:52 +00:00
94a7d1647f
Fix typo.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16542
2024-01-10 18:32:47 +00:00
9038f80543
Switch button focus to Close after running ERC or DRC.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16541
2024-01-10 17:36:31 +00:00
e7746d3bc8
Fix spelling mistakes
2024-01-10 16:17:07 +00:00
4f3fb5c23f
Second attempt at fixing ERC dialog reference update issue.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16519
2024-01-09 13:14:13 -05:00
92c58f2564
Fix sheet path dependent ERC dialog selection issues.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16519
2024-01-08 11:16:55 -05:00
120937b6b0
Honour forced transparency for strokes and fills.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16542
2024-01-07 17:40:50 +00:00
392242b9a4
Make sure OK button has focus when re-displaying ERC window.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16541
2024-01-07 17:23:45 +00:00
Alex
jean-pierre charras
Jeff Young
Wayne Stambaugh
Seth Hillbrand
Jon Evans
Marek Roszko
Ian McInerney
Martin Berglund
afkiwers
Roberto Fernandez Bautista
Graham Keeth
Andre Iwers
Mike Williams