b7ba24b2d9
TOOL_EVENT: fix lifetime issues with const aEvent& refs
...
Without this the event is on the stack, and as soon as the tool calls
Wait(), the event will be deallocated. The aEvent reference will then
point to invalid memory.
2022-09-19 07:59:11 -04:00
45d6b4a9fc
Readability improvements.
2022-09-19 11:18:20 +01:00
bdf4cf51b8
Add a missing statement in segments reservation.
...
Also adds an assert in FinishItem.
Fixes https://gitlab.com/kicad/code/kicad/issues/12448
2022-09-19 02:36:21 +00:00
63295cfb9e
Remove unused vars
2022-09-18 08:49:07 -04:00
f26a6f76e4
IUToMils should return int
...
It was already truncating even in old code...lets just clean this up
2022-09-17 09:27:27 -04:00
97963a2bba
Better after base_units.cpp changes in python stuff.
...
Move an include to kicad.i
2022-09-17 11:21:48 +02:00
ece23d434b
Split up Double2Str to a format function to make its use case clear
2022-09-17 00:10:22 -04:00
59a9ddac20
Convert the primary file io formatter for doubles
2022-09-16 23:20:15 -04:00
3d5913c825
Remove convert_to_biu.h, merge contents to base_units.h
2022-09-16 21:09:28 -04:00
0f2411587e
Remove Millimeter2iu
2022-09-16 21:09:27 -04:00
7a5829f8d6
Move IU2Mils
2022-09-16 21:09:27 -04:00
61e11d6896
Strip out Mils2Iu
2022-09-16 21:09:27 -04:00
ee48c8d232
Remove some more
2022-09-16 21:09:26 -04:00
a8613ee80f
Combine Iu2Millimeter & remove PcbMm2iu
2022-09-16 21:09:26 -04:00
85e8d1eb38
Try re-organizing the events for the search ctrl to allow MSW icon to be shown.
...
See further comments in bug report.
Fixes https://gitlab.com/kicad/code/kicad/issues/11743
2022-09-16 17:04:46 +01:00
4de264ddaa
Don't steal up/down arrows from textboxes and the like.
2022-09-16 16:52:26 +01:00
4f453d6b92
Remove turning the cursor on in FocusOnLocation.
...
We don't (at present) have any good way to turn it back off.
Fixes https://gitlab.com/kicad/code/kicad/issues/12440
2022-09-16 16:44:18 +01:00
cf1565a16a
Bug fixes for layer expression processing.
...
1) Push a VAR onto the stack, not a resolved value
2) Don't collapse a PCB_LAYER_VALUE to a VALUE during processing
3) Make sure we run overloaded operators from the correct side
Fixes https://gitlab.com/kicad/code/kicad/issues/12437
2022-09-16 14:14:43 +01:00
b00178adb3
Nuke base_units from orbit
2022-09-16 04:38:10 +00:00
9a4a68fb5e
Hide search button on MSW.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11743
2022-09-15 23:23:23 +01:00
a21d24a4c8
Experiment with loading recent searches into the search menu.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11743
2022-09-15 14:44:02 +01:00
da9be1a812
ADDED: Multi-selection cut/copy/paste in symbol editor library tree
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/11505
2022-09-14 22:20:38 -04:00
c48286b879
Fix missing variable initialization.
2022-09-15 00:45:29 +01:00
12ee8b5d7c
Improve DRC cross-probing a bit.
2022-09-15 00:45:29 +01:00
0180bcf90a
ADDED: Implement Drag and Drop
...
dropping files to Kicad manager :
*.kicad_pro, *.pro -> open project;
gerber and job files -> open in Gerbview editor;
Eagle and Cadstar files -> open project.
dropping file to schematic editor -> append schematic;
dropping library file to Symbol editor -> add library;
dropping board file to PCB editor -> append board;
dropping library or footprint file to Footprint editor -> add library or import footprint;
dropping ZIP file or gerber files to Gerbview editor -> open files;
dropping sheet file to Drawing Sheet editor -> open sheet.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/11638
2022-09-14 22:28:09 +00:00
b97f9ea329
Add support for symbol unit display names in eeschema and symbol editor
2022-09-14 22:11:37 +00:00
bd8b737c44
GAL: Do better job at reserving vertices.
2022-09-14 16:07:47 +00:00
75ae0d8e5e
Revert "Use {fmt} for double -> string conversions"
...
This reverts commit 03fff6e58d
2022-09-14 10:56:50 +00:00
281b9d405a
ADDED ability to specify where pad number (& net name) go on custom shaped pads.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6627
2022-09-14 11:37:20 +01:00
03fff6e58d
Use {fmt} for double -> string conversions
...
Faster at printing floats than sprintf due to the modern algos
2022-09-13 23:17:15 -04:00
f304e2d4f6
ADDED: Search/inspect pane
2022-09-14 02:59:57 +00:00
7bd8cfd7f9
Added common option to hide scrollbars
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9093
2022-09-13 22:15:27 +03:00
bde2d388f1
Fix a very serious memory leak in OUTLINE_FONT::getTextAsGlyphs().
2022-09-13 17:55:12 +02:00
4f3db82c68
Add debugging support for KiCad2Step command line generation.
2022-09-12 14:30:07 -04:00
9cda5e200c
Hotkeys: Swap on Shift S and revert old actions back to S
2022-09-12 14:18:54 -04:00
37d2addf0e
Icons: add swap
2022-09-12 11:11:49 -04:00
f70e1d0f22
SCH/PCB: Set Swap hotkey to 'S'
...
* Move Add Sheet to Shift+S in Schematic Editor
* Move Set Grid Origin to Shift+S in PCB Editor
2022-09-12 11:11:49 -04:00
fcfb9cc5ad
Selection: track selection order
2022-09-12 09:39:43 -04:00
d95847ae79
Add missing format specifier to UnescapeString.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9542
2022-09-12 01:48:23 +01:00
b4e71de89f
LIB_IDs can have forward slashes
2022-09-11 10:11:25 -04:00
1b104f20b6
Don't give Scintilla a colour with alpha; it doesn't know what to do.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10829
2022-09-11 13:08:31 +01:00
da7eaeffd2
Move IsOK() to wxRichMessageDialog so it handles <ESC> properly.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12360
2022-09-11 12:21:16 +01:00
a9877ab117
Include markdown files in project view.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12178
2022-09-10 21:11:24 +01:00
52ea9d0bc5
Don't allow preview canvases to steal focus when keyboard navigating preferences tree.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10407
2022-09-10 20:15:49 +01:00
d5430906d4
Make sure cursor settings get saved.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11663
2022-09-10 18:43:32 +01:00
b95d9d660d
Move gerbview colors to preferences dialog.
2022-09-10 16:11:24 +01:00
f87bf3c46d
Special case up-key so it can get past headers in paged dialogs.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10078
2022-09-10 09:31:27 +01:00
09ef7c8f1e
Add RPT_SEVERITY_DEBUG for developer-type messages
...
Move a bunch of importer messages out of the user-visible space as they
are not information that the average user can act on.
2022-09-09 17:21:47 -07:00
59f546ced0
Allow recursion up the sheet hierarchy for text variable resolution.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11953
2022-09-10 00:04:20 +01:00
df35576cf9
fix my previous commit ( c0661468) broken.
2022-09-09 19:00:47 +02:00
c06614689e
OPENGL_GAL: disable bitmap image caching due to serious issues (memory leak)
...
It was re-enabled by commit cbc3bfbf
2022-09-09 18:37:30 +02:00
f179754118
Implement add-new-on-return for some of our grids.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12335
2022-09-09 13:41:13 +01:00
087550ebd3
Get 3d plugins working for running from build dir
2022-09-08 21:49:10 -04:00
c13b938a4b
Free memory when unused, forgotten in my commit d4feb59e
2022-09-08 13:07:36 +02:00
d4feb59ed9
OPENGL_GAL, draw bitmap: Rebuild the bitmap cache if the bitmap itself was rotated.
...
Fixes #12378
https://gitlab.com/kicad/code/kicad/issues/12378
Fix also a Coverity warning.
2022-09-08 12:00:43 +02:00
9523586bf1
Remove atrophied PCB NO_CONNECTS layer and its colour.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12316
2022-09-08 00:28:31 +01:00
6f5281258e
Separate text-thickness clamping into strict and lenient modes.
...
We used to use the bold setting, but since PCBNew allows you to
directly define the width you end up with settings in between normal
and bold that get clamped to the normal max.
Fixes https://gitlab.com/kicad/code/kicad/issues/12367
2022-09-08 00:28:30 +01:00
89310bc403
"Cleaner" pan fix and add internal setter on state
2022-09-07 07:19:39 -04:00
59e9225619
Remove accidental debug code
2022-09-06 23:09:07 -04:00
971a8489b3
Hackfix the autopan on Windows
...
Autopanning is kinda doesn't jive with how events work on Windows
This is a hackfix for testing
Kinda fix https://gitlab.com/kicad/code/kicad/-/issues/11425
2022-09-06 23:07:59 -04:00
1520a1d372
Use cached untranslated header for looking up width
2022-09-06 09:18:34 -04:00
b80824951e
Clean up some of the PDF hypertext stuff, and add opening HTTP[S] urls.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12153
2022-09-06 13:59:52 +01:00
8afc1db7a6
Property popups for symbols, labels, sheets, and footprints in PDF.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5521
2022-09-06 13:59:52 +01:00
90996d0698
Don't toggle checkboxes selected rows if only one row is selected
2022-09-05 16:50:54 -04:00
e294fe2074
ADDED: Dynamic field columns in symbol chooser
...
CHANGED: Symbol chooser search now considers custom symbol fields
Visible columns can be controlled in database libraries.
In standard KiCad libraries, we show columns for all custom fields for now.
Customizable column visibility will be added in the future.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/11946
2022-09-05 16:38:14 -04:00
6013c796dd
Fix TRANSFORM::MapAngles (Third time lucky?)
...
Use epsilon value to decide whether we should swap the angles
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12346
2022-09-04 23:21:29 +02:00
895a8a8dbc
Work around focus issues for status popups.
...
Autoscroll wasn't working on Mac because the status popup's panel
has the focus. This *may* also fix a problem on MSW of the auto-scroll
not being cancel-able.
Fixes https://gitlab.com/kicad/code/kicad/issues/11425
2022-09-04 21:08:01 +01:00
26ba8e1938
Don't use recursive mutex for nicknames anymore
2022-09-04 13:01:32 -04:00
a5246a6df7
DbLib: Support showing field names
2022-09-04 13:01:32 -04:00
71724bea0c
Remove curly brace from string encoding.
...
It causes issues with formatting constructs and text variable refs,
and it's not a reserved character even in filenames.
Fixes https://gitlab.com/kicad/code/kicad/issues/12351
2022-09-04 10:34:32 +01:00
efae2bbb4c
Better feedback for netclass assignment patterns.
2022-09-03 21:33:56 +01:00
c30a557810
ADDED netclass assignment from PCB canvas.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5975
2022-09-03 19:29:59 +01:00
977b6cd8f3
PCM: add ability to pin packages
...
Pinned packages don't affect available update notification and will not
be updated with "Update All" button. Manual update is still possible but
will trigger a confirmation dialog.
2022-09-03 17:07:55 +00:00
112f089485
Fix TRANSFORM::MapAngles for other transformations than y=-y
...
Tested on transformation that results in: y=-y & x=-x
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12345
2022-09-03 00:28:15 +02:00
b0aba0fdf3
Cache works better with unique keys
2022-09-01 23:11:35 -04:00
60f6bb8c77
DbLib: Fixes for MySQL ODBC driver
...
SQLSetConnectAttr crashes for this driver, and SQLSetStmtAttr is the ODBC3 way anyway.
2022-09-01 00:24:56 -04:00
9188838e50
RIP EDA_RECT.
2022-08-31 23:57:24 +01:00
b4492e0bd2
More EDA_RECE yeetage.
2022-08-31 17:19:50 +01:00
f17a865593
Move EDA_ITEM hitTest to BOX2I.
2022-08-31 17:18:45 +01:00
3857e68452
Python, swig: add definition of BOX2I
2022-08-31 17:18:46 +02:00
2dc6300501
Move EDA_ITEM bounding boxes to BOX2I.
2022-08-31 10:16:55 +01:00
ae879c8f02
DbLib: Add single-row query cache
...
Since single-row queries are performed rapid-fire during certain actions like
stepping through the symbol browser, there is high value in caching them for
a small amount of time. The default cache parameters will keep results for
10 seconds, which errs on the side of getting fresh data from the database
on most user interactions.
2022-08-30 22:18:36 -04:00
5679b9dbdc
Remove a few EDA_RECT instances.
2022-08-31 01:22:49 +01:00
0c8787cbb9
Some more wxPoint/EDA_RECT yeeting.
2022-08-31 00:44:33 +01:00
b736460e71
Move optional access from value() to *operator
...
`value()` throws. Where we check for existence, we don't need to use
the throwing version and should just use the unprotected variant
2022-08-30 13:59:39 -07:00
91fbb5c957
Don't prevent immediate actions while router active
...
Immediate actions that can take place are useful. We should only be
preventing immediate actions while actively routing or dragging
Fixes https://gitlab.com/kicad/code/kicad/issues/12311
2022-08-30 10:31:29 -07:00
63386ba64d
Pointer safety for ERC/DRC dialogs.
...
Also makes the "Edit ingored violations" easier to find.
Fixes https://gitlab.com/kicad/code/kicad/issues/12308
2022-08-30 12:07:19 +01:00
8dddc07f26
Remove #ifndef that's redundant
...
This seems to date back to once upon a time when gerbview didn't even use base_units
2022-08-29 23:24:48 -04:00
a8a75a91e1
Try and fix file encoding
2022-08-29 20:57:14 -04:00
03aa63bd50
Move 5 helpers to EDA_UNIT_UTILS since they aren't iu specific
2022-08-29 20:11:03 -04:00
99f8bb3219
panel_gal_display_options can be common
2022-08-29 18:18:38 -04:00
f0956e48f2
Make EDA_TEXT common
...
Since EDA_TEXT is a base class, we can just force the child classes to pass the correct iu scaled size
ALLOW_BOLD_THICKNESS removed because it's a pre-custom font holdover
2022-08-29 07:31:03 -04:00
1a7157fe37
Remove unused include
2022-08-29 07:31:03 -04:00
b1eff8abd4
Fix leftover base_screen.cpp
2022-08-28 19:41:52 -04:00
5ebd3b2d80
Make EDA_SHAPE common
...
Looks like it's dependency on unit macros was dropped some time ago
2022-08-28 19:35:41 -04:00
ba3e31bd09
GRID_TRICKS: Allow toggling checkboxes in a set of selected rows
2022-08-28 18:30:08 -04:00
48f77973da
Another try at getting the Link combobox working on MSW.
2022-08-28 23:25:01 +01:00
abc7335fd7
Cosmetic enhancement: add two missing icons
2022-08-28 16:01:26 +02:00
474d732d94
Fix for wx3.2
2022-08-28 08:53:25 -04:00
7d73376bbd
Fix assertion when no netclass assignments exist
2022-08-28 08:28:13 -04:00
95fd7cb80a
Move wxComboBox to wxBitmapComboBox in hopes it will work better.
...
(Not sure if it solves the MSW issues yet, but at least it highlights
the items in the dropdown on rollover on OSX.)
Also added some text to the dropdown menu for intersheet references in
the PDF.
2022-08-28 12:05:27 +01:00
c0d2052e4b
PDF hypertext menus for intersheet references.
2022-08-27 23:58:13 +01:00
560dc7d2b6
Underline for hypertext rollovers.
2022-08-27 23:58:13 +01:00
49354e52a8
Add support for sub-libraries concept
...
Sub-libraries allow a single-level hierarchy inside a symbol library.
This is useful for database libraries and for supporting other EDA library types where a
single file can contain multiple logical groupings of symbols.
2022-08-27 18:47:39 -04:00
a76d1a791d
Hyperlinks: Don't forget about file:// protocol
2022-08-27 23:16:28 +01:00
f73a3f852e
Hyperlinks: Fix URL validation for https
2022-08-27 22:45:19 +01:00
122a6d7f46
Move hypertext linking to user-page-numbers.
...
Also moves most navigation code to SCH_NAVIGATION_TOOL.
Also changes page number href to anchor syntax ('#foo').
Also adds hypertext processing to SCH_TEXTBOXes.
Also adds combobox with schematic pages to text properties dialog.
2022-08-27 19:17:43 +01:00
9b007ca4bf
ADDED: Go to page hyperlinks in schematic editor (virtual page numbers)
...
The problem is that "real" page numbers can be duplicated, so we work around it
by using virtual page numbers instead which are guaranteed unique.
Example "goto:3" will go to page 3. If customised page numbers are used such as
a, b, c, then to go to page b, we should specify goto:2 (i.e. the virtual page
number).
2022-08-27 19:17:42 +01:00
5d90f3f54f
WIP - fix up parsing + generalise to the pcb
2022-08-27 19:17:42 +01:00
3cd867e656
WIP - add hyperlinks to pages within pdf
2022-08-27 19:17:42 +01:00
f788945cf4
Add pdf output to hyperlinks
2022-08-27 19:17:42 +01:00
366b0ab08b
Fix variable naming in pdf plotter
2022-08-27 19:17:42 +01:00
20ed9b475b
Configurable hyperlink hovering color
2022-08-27 19:17:42 +01:00
840bcffefb
ADDED: Hyperlinks on text items in Schematic Editor
2022-08-27 19:17:42 +01:00
9acc5ac7ea
base_screen became free of base_unitry awhile ago
2022-08-27 14:02:51 -04:00
bf964d8678
Commonize page_info by simply making the Iu scale a parameter on call.
2022-08-27 13:36:00 -04:00
7d5bdd23de
more cleanup TRANSFORM::MapAngles
2022-08-27 12:51:33 +01:00
5cae80d737
Cleanup asserts in TRANSFORM::MapAngles
2022-08-27 12:51:33 +01:00
029cc65b34
EDA_SHAPE: Remove m_upsideDownCoords hack (Fixes hitTest routine)
2022-08-27 12:51:32 +01:00
2812794742
Move TRANSFORM to common
2022-08-27 12:51:32 +01:00
4b5c5aa6b6
Preferences dialog: avoid crash on opening if a dll is missing.
...
Fixes #12273
https://gitlab.com/kicad/code/kicad/issues/12273
2022-08-27 11:36:37 +02:00
300d92438c
Allow hiding symbol library tables from symbol chooser
...
Hidden but loaded libraries are useful when using database libraries
2022-08-26 20:18:40 -04:00
d22fc24d9e
Attempt to fix MSVC build
2022-08-26 12:51:14 -04:00
5c7f1083c7
database_connection.cpp: Fix compil issues on msys2. these issues are
...
due to "old" (or not existing) types used in sql.h
2022-08-26 18:15:57 +02:00
3da2f79d0e
Fix initialisation order issue in PANEL_SETUP_NETCLASSES.
2022-08-26 17:05:25 +01:00
146495672e
Utilize our combine_hash routine for multiple hash
...
We should be using the one routine every time we want to build a hash
from indepedent values rather than rebuilding it differently in multiple
places
2022-08-26 08:45:13 -07:00
06786c34d7
Blacklist hashes for 2d integer elements
...
The hash table for integer hashes is extremely limited and places most
elements in the same buckets. This leads to a linear search time for
structures built on this.
This blocks hashes, directing the coder to utilize std::set or std::map
structures instead of hash tables for implementing integer-based
lookups.
2022-08-26 08:43:37 -07:00
ed02d7c974
Spread bitmap store hash table elements
...
XOR of two sequential ints makes for an inefficient hash table. The
hash_combine function is intended for this purpose
2022-08-26 08:43:37 -07:00
ae6a2a6443
ADDED: Database libraries MVP
...
Allows placing parts from an external database that reference symbols from another loaded library.
Includes:
- nanodbc wrapper
- database schematic library plugin
- basic tests
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7436
2022-08-26 10:51:13 -04:00
31c24f4421
Add nanodbc
2022-08-26 09:38:11 -04:00
f1261e71d4
Replace boost::optional with std::optional
2022-08-25 15:50:47 -07:00
c491cd01c5
Silence property warnings
2022-08-25 13:39:38 -07:00
8a02f2f809
DIALOG_PASTE_SPECIAL: Set focus on OK button
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12285
2022-08-25 20:25:23 +01:00
a306246558
Fix a few (minor) compil and Coverity warnings.
2022-08-25 20:21:00 +02:00
27c31061b1
Set locale in SaveToFile routine before calling json stuff.
...
It avoid wxWidgets alerts about locale when running some python scripts
2022-08-24 07:36:57 +02:00
e30f059b43
Silence uninitialized warning
2022-08-23 23:51:42 -04:00
fc99b3ba95
Don't link gdiplus everywhere anymore
...
Tested on msys2 which is the only place it would have been buggy
CMake seems to share the gdiplus linkage with the other dependencies automatically now
2022-08-23 23:51:35 -04:00
e0f28fc4e1
Replace wxFindReplaceData with our own container
...
By dropping the flags, we can be strict with options.
Also it makes future usage of search functionality a little more "UI" framework independent
2022-08-23 22:16:51 -04:00
7a8b188569
Fix Sentry crash for font loads
...
We cache newstroke loading, but if we have threaded loads, we might ask
multiple threads to load the newstroke font at the same time. This
causes conflicts in the vector allocations->crashes
2022-08-23 09:51:20 -07:00
284917b999
Fix assertion when rendering layer editor
2022-08-22 21:32:33 -04:00
7208ceb5f1
Handle mils in property panel
2022-08-22 21:32:33 -04:00
bfdb39f418
Properties Panel: Plain-language descriptive noun function of EDA_ITEM
2022-08-22 21:32:33 -04:00
f5a75a4001
Minor nullptr fixes
2022-08-22 21:32:33 -04:00
f5597238fb
Properties: add color swatch to layer enum
2022-08-22 21:32:33 -04:00
239fd29da4
Use checkbox mode for boolean props
2022-08-22 21:32:33 -04:00
91c15b7e21
Properties panel appearance tweaks
2022-08-22 21:32:33 -04:00
3c6e8aea0f
Properties panel: post-rebase fixes and hide by default
...
Remove layer widget re-added by Orson's rebase
2022-08-22 21:32:33 -04:00
990ea5595e
Properties: Fixed a startup crash
2022-08-22 21:32:33 -04:00
af71d42307
Renamed PROPERTY_TYPE enum names to avoid a conflict on MSYS2
2022-08-22 21:32:32 -04:00
c37c429c75
Rename PROPERTY_PANEL::Update() to PROPERTY_PANEL::UpdateData()
...
The base class (wxPanel) already provides Update() method,
which should not be overridden.
2022-08-22 21:32:32 -04:00
Mike Williams
Jeff Young
Alex
Marek Roszko
jean-pierre charras
Jon Evans
lulu731
kliment
aris-kimi
Wayne Stambaugh
Seth Hillbrand
Roberto Fernandez Bautista
qu1ck
Maciej Suminski