e824e5a267
Compiler warning: C4555 result of expression not used
2024-03-09 17:11:38 +00:00
72ba31ba27
Pass symbol's netlist to footprint preview widget.
...
This allows us to show the pin functions on the corresponding
pads.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17349
2024-03-09 15:01:59 +00:00
cb01bca1f4
Add PADS netlist format export
2024-03-09 10:00:46 -05:00
c5a02fc266
Do not update schematic connectivity for irrelevant property changes.
...
Prior to this change, the schematic connectivity was updated any time a
change was made to a connectable object. Now the connectivity is only
updated when an object change actually affects the connectivity. Other
properties like line width, fill type, custom fonts, etc. will not cause
the connectivity graph to be rebuilt.
The SCH_COMMIT flag SKIP_CONNECTIVITY has been removed. All schematic
objects can test if they are connectable and if there have been changes
to any connection properties that require a connectivity rebuild.
Remove duplicate rebuild connectivity calls from editor control tool.
This was causing the tangling end test to get called four times on every
undo and redo action because the dangling end test is already called in
the connectivity graph calculation code.
Update connectivity when changing label names which fixes an unreported
connectivity bug.
2024-03-09 08:50:26 -05:00
5ac8449e1f
Minor compil and Coverity fixes
2024-03-06 13:05:21 +01:00
4bc69183ab
Set description on Altium imported symbols
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16943
2024-03-05 23:08:11 -05:00
1600d8bead
Prevent use-after-free of symbol screens
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17204
2024-03-05 22:53:51 -05:00
c1ba07e6bc
SelectAll should use the filter
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17157
2024-03-05 18:27:51 -05:00
1988aac2b3
Update a few more list/tree views for macOS
2024-03-05 08:38:46 -05:00
8cda72f8d5
Fix defects reported by Coverity scan introduced in !1765
...
Corrects lifetime performance issue where extra copies of SCH_SHEET_PATH objects were being passed on the stack.
2024-03-04 19:45:05 +00:00
62c961b8ba
Performance Mitigate "Edit all symbol fields" dialog slow closing.
...
GetSymbols will return all symbols. Call it once and cache it.
2024-03-04 19:41:01 +00:00
ff8ddae9bd
Convert OP text variables pin names/numbers to SPICE vectors.
...
Also fixes a wrap-around bug in SPICE_VALUE::Normalize() where
it would lose the run of itself if the value was already
normalized to either the largest or smallest UNIT_PREFIX.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17228
2024-03-04 14:25:29 +00:00
c056ef407a
EasyEDA Std: support multiple schematic sheets.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17219
2024-03-04 15:09:31 +03:00
cc181df916
EasyEDA Std: support Dot and Clock symbol pin styles.
2024-03-04 15:09:31 +03:00
69b15e83c5
EasyEDA Std: hide invisible text in symbols.
2024-03-04 15:09:31 +03:00
563278d0f6
EasyEDA Pro schematic: place items on root sheet when it's the only sheet.
2024-03-04 15:09:31 +03:00
13c647ef6f
Fix resources leak reported by coverity
...
For unique_ptr, release only set the ownership to null, but don't free the resource behind. On the other hand, reset do.
Closes Coverity ID 483269
Closes Coverity ID 471974
Closes Coverity ID 471973
2024-03-03 16:23:49 +00:00
c76c4ba304
schematic: do not skip item repaint if item's parent type != SCHEMATIC_T
...
the item repaint was skipped when unhighlightning symbols after dragging
and unselecting.
Fixes https://gitlab.com/kicad/code/kicad/issues/17193
Fixes https://gitlab.com/kicad/code/kicad/issues/17206
2024-03-03 16:21:29 +00:00
4851b0f1ac
Database library cache: fix memory leak
2024-03-03 16:20:32 +00:00
0c8e08ed58
Move some language changes to a event on the frame
2024-03-03 11:02:26 -05:00
66925ec2a2
Update net navigator when cross probing from board editor net highlight.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16838
2024-03-03 08:56:48 -05:00
612c7015a7
REMOVED: Clicking on pin selects symbol setting
...
This is now redundant with the selection filter
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17114
2024-03-02 22:18:51 -05:00
c51e9917ba
Fix ordering of selection filter and net navigator
2024-03-02 20:21:16 -05:00
9c371e2ef5
Don't draw the selection if it's not from the current screen.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17132
2024-03-02 18:57:39 +00:00
428f2087bd
Eeschema: fix crash when editing a old legacy schematic with missing libs,
...
and trying to edit a dummy symbol. (crash due to a null pointer due to missing lib)
Fixes #17232
https://gitlab.com/kicad/code/kicad/-/issues/17232
2024-03-02 15:23:23 +01:00
c97c69a2f0
First alt-pin menu item must be fetched from the LIB_PIN.
...
(The SCH_PIN will return any alt function already assigned.)
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17221
2024-03-02 12:17:22 +00:00
70fe2a8f1e
kicad_cli: Allow upgrade of legacy and non-kicad symbol libraries
2024-03-02 13:06:23 +01:00
0d03f2febc
When failing to import, ensure extant screen
...
We need at least the root screen in order to handle any action in
Eeschema. Because this is destroyed by starting to load the new
schematic, when failing, we need to reset to null.
This is not as good as resetting to the previous state but that will
take refactoring our file load routines in schematic editor
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16993
2024-03-01 18:48:14 +00:00
a902898522
schematic: legacy kicad schematic files don't have a default description field
...
Without this, we would parse a legacy schematic symbol field at the same
index as the new description field's index into description, instead of into
a user field.
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/17202
2024-03-01 10:40:03 -05:00
defcb49ac8
Support Altium Schematic ASCII import
2024-02-29 20:49:20 +00:00
24529e5242
ADDED: library tree context menu option to open sym/fp library files from the defined text editor.
...
Short description:
Works for Symbol and Footprint Editor behind an advanced config option.
For Symbol Editor it is shown for a single item selection (library or symbol).
For Footprint Editor it is shown for a footprint selection.
(fp editor allows a single tree item selection only).
Option stays hidden if current frame has been modified.
Also small fix(?) for similar action to the project manager.
(Call for the Execution has moved inside the file loop.)
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/15736
2024-02-29 19:01:59 +00:00
cd27f801f6
Allow .kicad_sym in Import Symbol filters.
2024-02-29 17:36:32 +03:00
39a0a81832
EasyEDA Std import: support multiline text on PCB.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17171
(cherry picked from commit 0dab086f0c
2024-02-29 00:54:46 +00:00
20ea299742
Cleanup.
2024-02-28 22:18:26 +00:00
d08e0e9eaa
_() -> _HKI() for group names.
2024-02-28 17:50:51 +00:00
141d03c266
Fix sheet pin align to grid issue.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16920
2024-02-28 11:57:49 -05:00
0314540fdb
Keep schematic text upright (especially when opening v6 schematic).
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17082
(cherry picked from commit bec068324e
2024-02-28 15:25:39 +00:00
9a9d6f2afb
Sheet synchronization dialog layout improvements.
2024-02-28 08:08:03 -05:00
fe349be48b
Eeschema, DIALOG_CHANGE_SYMBOLS: fix incorrect initial lib link name when
...
changing symbols: the "old" displayed link was in fact the new link because
the link was updated before the report is created.
Fixes #17162
https://gitlab.com/kicad/code/kicad/-/issues/17162
2024-02-28 11:21:17 +01:00
31fab831ad
Remove unnecessary assert
...
GetModifyHash can be called before a row is loaded
2024-02-27 19:03:06 -05:00
2dce618f9f
Expose text size for SCH_FIELDs.
2024-02-27 17:48:09 +00:00
a5fda819eb
Fix typo.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16991
2024-02-27 17:16:14 +00:00
3079f7c742
Fix copy pasta.
2024-02-26 22:29:29 +00:00
ac0758eca0
Only change pin assignments from user interaction.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16349
2024-02-26 19:02:00 +00:00
d16b5fb810
Handle single-source DC analyses correctly.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17119
2024-02-26 19:02:00 +00:00
23169ca1a7
Post merge request clean up.
2024-02-26 07:54:22 -05:00
2f6c9d1f3a
ADDED: Selection filter for schematic editor
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14988
2024-02-25 17:44:10 -05:00
aef87b9796
Push thickness handling down into EDA_TEXT::SetBold().
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17077
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14875
2024-02-25 17:28:52 +00:00
7789dfcfdc
fix a compil issue (missing include and nullptr_t -> std::nullptr_t)
2024-02-25 16:26:05 +01:00
f7721f385a
Symbol editor: add option (view menu+toolbar) to show/hide invisible pins and fields
...
Fixes #8020
https://gitlab.com/kicad/code/kicad/-/issues/8020
2024-02-25 16:09:50 +01:00
be81bce637
Add Feature: synchronize hierarchical labels and sheet pins
2024-02-25 14:23:59 +00:00
d939004bbd
Fix use-after-free in Altium importer
...
If the library already contains a symbol with the same name,
SaveSymbol will replace the existing symbol,
which will invalidate a cached pointer.
2024-02-25 08:47:07 -05:00
99948de45a
Support pin count and footprint filters in symbol editor.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17105
2024-02-25 13:14:31 +00:00
dba2fdb6d3
Don't import invalid polygons.
...
If we *do* get a 2-point polygon in SVG, import it as a segment.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17091
2024-02-25 12:28:19 +00:00
caa83ec9bd
Fix missing unit initialization.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17076
2024-02-24 22:34:41 +00:00
9a02712c4f
Update VDMOS models to ngspice-41 (and later) defaults.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17073
2024-02-24 20:05:51 +00:00
f77de66f4e
Generalize ERCItem inspections.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/10539
2024-02-24 20:05:51 +00:00
e7abeb3c38
Cleanup.
2024-02-24 20:05:51 +00:00
fa0ead98d8
Split out table editing and table cell editing.
2024-02-24 20:05:51 +00:00
3282e4bb66
Formatting.
2024-02-24 20:05:51 +00:00
782af3a918
Clear text before replacing in ImportSettingsFrom.
2024-02-24 20:05:51 +00:00
e760317af6
ADDED: Implement footprint link checking in ERC.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16842
2024-02-24 20:05:51 +00:00
d7e4a8cebd
ADDED: ERC/DRC exclusion comments.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16020
2024-02-24 20:05:51 +00:00
c8d2a9340b
ADDED: ExpandAll/CollapseAll for hierarchy pane.
2024-02-24 20:05:51 +00:00
4eefbc7815
ADDED: textbox and tablecell margins.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/10672
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6806
2024-02-24 20:05:51 +00:00
e445249720
ADDED: PCB tables.
2024-02-24 20:05:51 +00:00
91df43c97a
ADDED: schematic tables.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6806
2024-02-24 20:05:50 +00:00
4a9df1e18e
ADDED: actions for left-, center-, and right-justifying text items.
...
(For both PCBNew and EESchema.)
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12375
2024-02-24 20:05:50 +00:00
6347cb043e
Add bottom panel to have correct background in fp/sym chooser frames.
...
See https://gitlab.com/kicad/code/kicad/-/issues/15810
(cherry picked from commit 97ff48b426
2024-02-24 18:20:16 +03:00
5578b2c954
Hide unused message panel in footprint/symbol chooser frames.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15810
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15889
(cherry picked from commit badc4e7411
2024-02-24 18:20:16 +03:00
b7b64d959f
Performance UpdateDanglingState
...
Avoid O(N^2) by spatial sorting, don't run checks if the bounding boxes
don't overlap.
A second copy is ordered by type to help classes that only want to check
a few types having to walk the whole list.
2024-02-23 19:21:44 +00:00
f3c2083018
Performance SCH_EDIT_FRAME::SchematicCleanUp
...
Avoid O(N^2) comparisonis by spatial presorting. If bounding boxes don't
overlap there's no need to run expensive checks.
2024-02-23 19:21:44 +00:00
006f93773c
Fix collecting of signals for S-Parameters analysis
2024-02-23 18:34:21 +00:00
cb25c8620e
Performance optimizations for database libraries.
...
(cherry picked from commit e68df8e1d1
2024-02-23 20:29:18 +03:00
e5896374e3
Normalize SCH_PIN BBox to fix assert.
...
(cherry picked from commit 3e26e7b646
2024-02-23 20:29:18 +03:00
72354ac033
Eeschema: select graphical shapes based on effective shapes.
...
(cherry picked from commit a13e4e7d9f
2024-02-23 20:29:18 +03:00
12c21abdff
Don't use EQUALITY flag when doing a symbol diff with library.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16944
(cherry picked from commit adae4de438
2024-02-23 16:53:36 +01:00
4a561b04bc
Code cleanup and compiler warnings.
...
(cherry picked from commit 51848a0b43
2024-02-23 16:53:35 +01:00
98cd040952
Set up default netclass wire & bus widths.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17024
(cherry picked from commit 2d7f4faf72
2024-02-23 16:53:35 +01:00
2c49ba4252
Formatting.
...
(cherry picked from commit c75bb5d01a
2024-02-23 16:53:35 +01:00
19dedccd98
Improve layout of schematic colors preview.
...
Also, set pin name/number sizes. Don't use defaults (which
will get plucked out of the Symbol Editor's settings).
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17043
(cherry picked from commit df8f043c16
2024-02-23 16:53:35 +01:00
17a37a55f0
When updating RefDes only update the prefix.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16991
(cherry picked from commit b6036f368e
2024-02-23 16:53:34 +01:00
2cd9fbab9d
Check known m_Desc field before m_Fields.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16971
(cherry picked from commit 25291d6e3a
2024-02-23 16:53:34 +01:00
ca3cd706e5
Show friendly name in toolbar button tooltips.
...
(Don't require the same text to be put into the tooltip.
It's error-prone and also disallows us from having a separate
tooltip for toolbar buttons.)
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17009
(cherry picked from commit f4a085575a
2024-02-23 16:53:33 +01:00
800bbd8841
Delete empty Netclass fields only if there are others.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16997
(cherry picked from commit a34b242f4e
2024-02-23 16:53:33 +01:00
57dcf285c5
Various string issues held over from 8.0 string freeze.
...
(cherry picked from commit a610542a19
2024-02-23 16:53:31 +01:00
23c2104ffa
Improve alignment tooltips.
...
(cherry picked from commit 2ab492474e
2024-02-23 16:53:31 +01:00
f161a1eaac
Ignore duplicate/repeat when drawing an existing item.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16885
(cherry picked from commit 3caede3799
2024-02-23 16:53:30 +01:00
9ff66d0e71
Don't capture references to local variables for CallAfter.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16934
(cherry picked from commit 9d40374baf
2024-02-23 16:53:30 +01:00
d464d7995b
Thread safety: replace ++m_modHash by IncrementModifyHash()
2024-02-23 14:59:10 +00:00
991ddfe6be
Add cache to SCH_IO_DATABASE to improve loading performance
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17031
2024-02-23 14:59:10 +00:00
07ab18a1e6
Legacy libraries: De-duplicate field names on load
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16902
2024-02-23 14:57:57 +00:00
420413969e
Altium: Don't create duplicate fields
2024-02-23 14:57:57 +00:00
1a6e6a06eb
Altium: Don't load library parameters with an owner for now
...
In Altium many objects can have parameters (including pins). For now
we will drop library parameters belonging to any sub-components of a
symbol.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17048
2024-02-23 14:57:57 +00:00
27911d9b5a
Fix crash when changing sheet file name that contains a highlighted net.
...
Performing a full connectivity rebuild after changing a sheet file name
ensures that there are no stale connectivity object pointers laying around.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17011
2024-02-17 08:50:22 -05:00
206a631135
Ensure stream is valid before checking for Eagle XML tag
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16989
Fixes KICAD-7QQ
2024-02-16 11:14:10 +00:00
f894a41dc2
LIB_SYMBOL::IsMulti() seems to be wrong, use the iterate conditional as the multi-unit check instead
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16932
2024-02-16 00:18:05 -05:00
9e08e6e4f1
USe setactive in cli in the LoadSchematic helper too
2024-02-16 00:08:10 -05:00
7b0bb59b37
Remove hard-coded versioned env vars in most places
2024-02-15 15:31:08 +00:00
0775d1364a
Add bezier icon
...
Fixes https://gitlab.com/kicad/code/kicad/issues/16830
2024-02-14 02:01:01 +01:00
Yon Uriarte
Jeff Young
Marek Roszko
Wayne Stambaugh
jean-pierre charras
Jon Evans
Ethan Chien
Alex Shvartzkop
Lucas Dumont
Petri Hodju
Roberto Fernandez Bautista
Seth Hillbrand
Mike Williams
aris-kimi
Andrej Krpic
Ian McInerney