haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
12,985 Commits 9 Branches 105 Tags 1.3 GiB
Commit Graph

930 Commits

Author SHA1 Message Date
jean-pierre charras 45dad4ded5 DIALOG_POSITION_RELATIVE: make dialog more understandable. 
Better texts, and add a helper comment.
 2018-05-18 13:53:31 +02:00
jean-pierre charras 2832f997c5 PcbNew; fix crash on copy/paste 
Due to a bug introduced by commit ba1e0efda that tried to fix an other bug.

Fixes: lp:1771003
https://bugs.launchpad.net/kicad/+bug/1771003
 2018-05-13 21:50:59 +02:00
Jeff Young a9dc417319 Fix bug in pruning of selection. 
Fixes: lp:1770939
* https://bugs.launchpad.net/kicad/+bug/1770939
 2018-05-13 15:23:41 +01:00
jean-pierre charras ba1e0efdad Pcbnew, GAL mode: Fix incorrect management of zones in append board and copy from Paste from clipboard. 
Fixes: lp:1770855
https://bugs.launchpad.net/kicad/+bug/1770855
 2018-05-12 20:48:50 +02:00
Maciej Suminski 471e3de5a7 Fixed board append function, broken in 046e73ec 
The previous implementation cleared all DLISTs, but has not added
everything back on append.
 2018-05-08 11:21:55 +02:00
Maciej Suminski 8cb3aa79f2 pcbnew_control.cpp code formatting 2018-05-08 10:40:33 +02:00
Maciej Suminski 046e73ecac Clear the source DLIST when pasting items to a BOARD 
Fixes the assert triggering when items already belonging to a list are
added to another one.
 2018-05-08 10:40:33 +02:00
Seth Hillbrand 4c7f5f2a2f Allow disabling snap-to when placing vias 
This allows the user to selectively disable the snap-to behavior when
placing stand-alone vias.  Full solution will require an update to the
segment distance calculation that takes into account the rounded line
caps.

Fixes: lp:1769523
* https://bugs.launchpad.net/kicad/+bug/1769523
 2018-05-07 13:58:26 -07:00
Jeff Young a31017bc9c Check zone fills before plotting. 
Also adds a "Draft Plot" button for those who wish to sidestep
zone checking (which can be slow).

Fixes: lp:1712579
* https://bugs.launchpad.net/kicad/+bug/1712579
 2018-05-05 23:40:40 +01:00
Maciej Suminski 684f085ac5 Coverity fixes 
CIDs:
dereference before null check:
175439 @ drc.cpp

uninitalized field:
175435 @ point_editor.cpp
174162 @ zone_filler.cpp
163188 @ footprint_info_impl.cpp

logically dead code:
155146 @ pcb_editor_control.cpp
 2018-05-04 14:06:08 +02:00
Jeff Young 2f157f9b23 Enable magnetic pads in Modedit. 
Also fixes a bug where a FOOTPRINT_EDIT_FRAME was being passed
in to a PCB_EDIT_FRAME.

Also tidies up Modedit settings handling for settings which can't
be edited in Modedit's preferences dialog.  They're now copied
from Pcbnew.

Fixes: lp:1768477
* https://bugs.launchpad.net/kicad/+bug/1768477
 2018-05-02 21:49:57 +01:00
jean-pierre charras 037f7a1698 Cosmetic enhancement: Add missing icons in GAL Select submenu (context submenu). 2018-05-02 21:42:41 +02:00
Seth Hillbrand 76d3b6f04a Adding locking to the context menu for modules 
Locking submenu was activated only for tracks and via but it makes sense
(and is probably expected) when right-clicking on modules as well.
 2018-05-02 08:35:53 -07:00
Jeff Young 6b3410974d Fix "same layers" test when duplicating zones. 2018-05-01 13:54:31 +01:00
Andrzej Wolski 5ac4dbe641 Fix window/crossed selection mode recognition in flipped view 
Fixes: lp:1767233
 2018-04-30 14:57:38 +02:00
Jeff Young c8a784058e Allow duplicating a zone onto the same layer in a GAL canvas. 
Duplicate already works, so there's little reason to disallow
using the zone dialog to do it.

The legacy canvas can't be fixed because we'll immediately
union the two zones, resulting in a no-op.

Fixes: lp:1464677
* https://bugs.launchpad.net/kicad/+bug/1464677
 2018-04-29 20:28:45 +01:00
Jeff Young 5342aacf97 Implement magnetic pads & tracks for measurement tool. 
This really needs to get put into the VIEW_CONTROLS for all the
tools, but that's probably a bit too risky for 5.0 at this
point.

Fixes: lp:1766547
* https://bugs.launchpad.net/kicad/+bug/1766547
 2018-04-25 23:36:17 +01:00
Seth Hillbrand d0ffff3b88 Prevent deletion while actively routing 
Fixes: lp:1766280
* https://bugs.launchpad.net/kicad/+bug/1766280
 2018-04-24 10:44:49 -07:00
jean-pierre charras bfc70c8208 Fix an issue in footprint editor, "Create Pad from Selected Shapes" command. 
If the initial pad was a custom pad converted in a usual pad + graphic items by the command:
"Explode Pad to Graphic Shapes"
the "old" primitives were not cleaned, and the new created pad contained these old primitives, regardless the new selected shapes.
(Usual case when a user want to edit a custom shape)
 2018-04-24 17:00:29 +02:00
Maciej Suminski 143d580596 Fixed relative coordinates reset when a tool forces the cursor position 
Fixes: lp:1759044
* https://bugs.launchpad.net/kicad/+bug/1759044
 2018-04-24 12:56:19 +02:00
Maciej Suminski 536529e48f Fixed unused captured variable warning 2018-04-20 08:44:41 +02:00
Maciej Suminski f81c77cd4e Edit Tool: update the reference point for in-place modification 
Fixes: lp:1765027
* https://bugs.launchpad.net/kicad/+bug/1765027
 2018-04-19 17:10:06 +02:00
Maciej Suminski 0a58de0c46 Selection Tool: reset is-hover flag 
Fixes: lp:1765034
* https://bugs.launchpad.net/kicad/+bug/1765034
 2018-04-19 16:17:54 +02:00
Maciej Suminski dce0743ddb Removed nagging dialog in the delete tool. 2018-04-19 15:35:10 +02:00
Seth Hillbrand f68268c8ca Only update msgpanel when dimension started 
Fixes: lp:1765118
* https://bugs.launchpad.net/kicad/+bug/1765118
 2018-04-18 10:06:23 -07:00
Seth Hillbrand 1663627135 Update msg panel on create/modify graphic items 
This clears the msg panel when not editing an item and updates the
position information when moving
 2018-04-12 10:07:24 -07:00
Tomasz Włostowski 4e99b0d0e7 pcbnew: refresh message panel while drawing & editing graphical lines, arcs, circles and texts 
Fixes: lp:1763052
* https://bugs.launchpad.net/kicad/+bug/1763052
 2018-04-12 18:23:33 +02:00
Jeff Young a597ebc85e Break a track when placing a via on it. 
Fixes: lp:1737349
* https://bugs.launchpad.net/kicad/+bug/1737349
 2018-04-09 11:05:14 +01:00
Carsten Schoenert 77b3a662fc fix misspelled 'Allows to' -> 'Allows one to' 2018-04-08 13:24:30 -04:00
Maciej Suminski 94dbcc7199 Fixed crash after multiple 'cut' commands in the footprint editor 
When multiple cut commands were issued, the cut command handler would
restart multiple times and keep running until the handler that was
invoked first finishes. As all handlers kept a selection copy, they
would try to save the deleted items to the clipboard resulting in a
crash.

Fixes: lp:1761221
* https://bugs.launchpad.net/kicad/+bug/1761221
 2018-04-05 00:26:57 +02:00
Maciej Suminski 7943372e8b Refill zones only when required 
Previous implementation refilled zones every time they have been
unselected. This patch adds a flag that tracks whether the
zone has been actually modified, so it will be refilled only when
necessary.

Fixes: lp:1760903
* https://bugs.launchpad.net/kicad/+bug/1760903
 2018-04-03 22:28:05 +02:00
Jeff Young d391489596 Don't clear old footprint till after user has hit OK. 
Fixes: lp:1759190
* https://bugs.launchpad.net/kicad/+bug/1759190
 2018-04-02 22:32:09 +01:00
Jon Evans 0ded476f9d Add a hotkey to control net highlighting 
Fixes: lp:1757446
* https://bugs.launchpad.net/kicad/+bug/1757446
 2018-03-26 23:09:44 -04:00
Maciej Suminski 886dc48cc4 Point Editor: reset the pointer to the modified point as it becomes invalid 
Fixes: lp:1759024
* https://bugs.launchpad.net/kicad/+bug/1759024
 2018-03-27 00:03:48 +02:00
Maciej Suminski 4b5ca0ec14 Drawing tool: prevent creating zero-length lines 
Fixes: lp:1758570
* https://bugs.launchpad.net/kicad/+bug/1758570
 2018-03-24 23:57:06 +01:00
Andrzej Wolski 4152069504 Make vias selectable even if top and bottom layer are hidden 2018-03-21 22:15:17 -04:00
Andrzej Wolski ff3f229871 Decouple vias from tracks in selection filter 2018-03-21 17:21:08 -04:00
Andrzej Wolski ea3f8743fd Fixes in GAL selection filter: 
- vias were always left selected, include vias in tracks filter - as in legacy
- make text filtering work
- cleanup drawings filtering code
- hide checkbox "Include items on invisible layers" because it does not work in GAL
 2018-03-21 17:21:01 -04:00
Jon Evans b9ce203487 Fix pad selection requirements in footprint editor 
Fixes: lp:1757295
* https://bugs.launchpad.net/kicad/+bug/1757295
 2018-03-20 21:15:05 -04:00
jean-pierre charras b5f1fdd981 Add icon to Get and Move context menu item in GAL mode. 
Windows does not like mixing menu items with and without icons (sizing error).

Fixes: lp:1756263
https://bugs.launchpad.net/kicad/+bug/1756263
 2018-03-20 08:30:02 +01:00
Maciej Suminski ce610f33a2 Coverity fixes 
resource leak: #172233
negative array index write: #102363
uninitialized scalar field: #174540 #174539
structurally dead code: #169334 #169331
 2018-03-19 10:02:05 +01:00
Jeff Young 89ebab5df2 Comments for SELECTION_TOOL::guessSelectionCandidates(). 2018-03-18 22:17:27 +00:00
Maciej Suminski ab37801489 Do not define hotkeys for copy/cut/paste to avoid double action execution 
CTRL+{X,C,V} used to be handled both by the legacy hotkey system that
generated ID_EDIT_{CUT,COPY,PASTE} wxCommandEvent, and the Tool Framework
hotkey system.

Fixes: lp:1749549
* https://bugs.launchpad.net/kicad/+bug/1749549
 2018-03-12 16:53:17 +01:00
Seth Hillbrand 8639c308fa Spelling "free-stanging" -> "free-standing" 2018-03-08 12:33:32 -08:00
Jeff Young ab730709c7 Only use hover track if there are no selected tracks. 
Fixes: lp:1645670
* https://bugs.launchpad.net/kicad/+bug/1645670
 2018-03-08 18:03:46 +00:00
Jon Evans 1e66a23dbc Rework footprint selection filtering to improve behavior 
Fixes: lp:1751960
* https://bugs.launchpad.net/kicad/+bug/1751960
 2018-03-07 20:41:10 -05:00
Tomasz Włostowski f2bb398ae6 pcbnew: fixes in primitives->custom pad tool 
Fixes: lp:1753712
* https://bugs.launchpad.net/kicad/+bug/1753712

Fixes: lp:1753711
* https://bugs.launchpad.net/kicad/+bug/1753711
 2018-03-06 14:59:15 +01:00
Tomasz Włostowski 48459e4268 pcbnew: fixes in custom pad creation tool 
Fixes: lp:1753152
* https://bugs.launchpad.net/kicad/+bug/1753152
 2018-03-06 14:59:15 +01:00
Tomasz Włostowski 4be12292a0 Fixed duplicate misbehaviour when duplicating single track/via 
Fixes: lp:1753158
* https://bugs.launchpad.net/kicad/+bug/1753158
 2018-03-05 14:52:12 +01:00
Seth Hillbrand 01ef0bd2e9 pcbnew: Add graphic polygon on drawing layer 
Fixes: lp:1753151
* https://bugs.launchpad.net/kicad/+bug/1753151
 2018-03-04 12:49:41 -08:00