haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
19,542 Commits 9 Branches 105 Tags 1.3 GiB
Commit Graph

329 Commits

Author SHA1 Message Date
Ian McInerney b6f6fc3d65 Return handled status for actions run from hotkeys 2019-08-05 20:46:05 -06:00
Jeff Young cc82e59003 Push the Quit/Close menu logic down into common. 2019-08-02 14:32:49 -06:00
Tomasz Wlostowski 6cab769f41 MSVC support for libcontext 
This uses the Windows native Fiber API.
 2019-07-17 08:10:47 -04:00
Jeff Young e816a0c29d Push Eeschema & PLEditor PICKER_TOOLs down into common. 
Also implements a more robust push/pop tool strategy for pickers.
 2019-07-16 00:44:01 +01:00
Jeff Young 30ec895c96 Cleanup event processing stuff to keep better track of "handled". 
See: https://lists.launchpad.net/kicad-developers/msg41471.html .
 2019-07-09 21:59:46 +01:00
Jeff Young 4852c91b42 Possible fix for GTK bug differentiating hotkeys from menu picks. 
Fixes: lp:1835672
* https://bugs.launchpad.net/kicad/+bug/1835672
 2019-07-08 10:51:45 +01:00
Jeff Young a11f3a0b80 Make <esc> unhighlight nets, but only after all tools have been cleared. 
Also moves the Highlight Net hotkey from activating the tool to just doing
a one-shot highlight.

Fixes: lp:1835658
* https://bugs.launchpad.net/kicad/+bug/1835658
 2019-07-08 00:02:25 +01:00
Jeff Young a3b855ac6c Massage an earlier fix so that mouse-clicks in tools update the highlighting. 2019-07-06 17:50:35 +01:00
jean-pierre charras 39c830435c Fix a bug created by commit ea0edaba. 2019-07-06 14:48:53 +02:00
Thomas Figueroa ea0edaba21 Fix cursor lag in canvases on Windows. 
Fixes: lp:1831541
* https://bugs.launchpad.net/kicad/+bug/1831541
 2019-07-06 00:04:54 +01:00
Jeff Young a9c66e15ea Common-ize EE_ACTIONS::refreshPreview and use it after cursor actions. 
Fixes: lp:1818667
* https://bugs.launchpad.net/kicad/+bug/1818667
 2019-07-05 14:45:15 +01:00
Jeff Young 9effd24f3a Allow move tool to run on top of other tools. 
Fixes: lp:1784480
* https://bugs.launchpad.net/kicad/+bug/1784480
 2019-07-01 22:15:25 +01:00
Jeff Young 2f23aa9556 Implement a more robust tool stacking architecture. 
We were running into various corner conditions where a tool's event
loop would exit while the tool was still active, or the tool would
get popped while we were still in the event loop.  (A lot of these
had to do with the POINT_EDITOR's, but not all of them.)

The new architecture:
1) tools always do a Push()/Pop()
2) everyone is responsible for their own pops; no more stack-clearing
on a cancel
3) CancelInteractive events go to all tools to facilitate (2)
 2019-06-27 17:01:31 +01:00
Jeff Young fbfcba6e4d Add action for context menu (right-mouse-click). 
Fixes: lp:1663595
* https://bugs.launchpad.net/kicad/+bug/1663595
 2019-06-25 11:34:27 +01:00
Jeff Young 485d436860 Clear ctx-menu before rebuilding; don't veto ctx-menu mousewarp for non-ctx-menu dialog. 
Fixes: lp:1833312
* https://bugs.launchpad.net/kicad/+bug/1833312
 2019-06-19 21:17:56 +01:00
Jeff Young eb95202708 Fix grid update when edited from menubar. 
Fixes: lp:1833399
* https://bugs.launchpad.net/kicad/+bug/1833399
 2019-06-19 18:35:17 +01:00
Jeff Young 7dd247f1dc Make better use of TOOL_EVENT parameters. 2019-06-18 20:24:15 +01:00
Jeff Young 1f35ec5521 Beware of copying events and losing the m_passEvent flag. 
Fixes: lp:1833031
* https://bugs.launchpad.net/kicad/+bug/1833031
 2019-06-17 14:44:39 +01:00
Jeff Young e6d5110ccf Implement I18N for ACTIONs. 
It's a bit of a hack because they're statically initialized and
so we can't make use of the _() macro.  We do still want it in the
code, however, because the string harvesting is based off of it.

Fixes: lp:1833000
* https://bugs.launchpad.net/kicad/+bug/1833000
 2019-06-17 10:45:23 +01:00
Jeff Young e4fbd003e0 Make m_passEvent event-specific rather than global. 
If a tool called something like clearSelection while processing a
MOUSE_CLICK, the SELECTION_TOOL will pass the clearSelection
COMMAND_EVENT because it handles it as a transition, not as an
event. Because m_passEvent is effectively global, the tool manager
would then interpret that as passing the MOUSE_CLICK and we'd end
up processing the click by multiple tools.
 2019-06-16 12:06:49 +01:00
Jeff Young 19aba615c2 Remove selection condition from conditional menu separators. 
We don't allow duplicate separators anyway so all they really do
is complicate the code.
 2019-06-15 20:43:51 +01:00
Jeff Young 5610261dce Immediate-action hotkeys (and context menu actions) for eeschema. 2019-06-15 20:43:51 +01:00
Jeff Young b429dbfb88 Fix bugs with ACTIONs not being "honest" singletons. 
Delete the copy ctor and assignment operator to start with, but
even then the separate apps each have their own statically allocated
copy of the common actions.  So we need to update all of them, which
also means having the kicad manager frame's set of actions on hand).

This changelist also adds a Clear Hotkey Assignment function since
the hotkeys set is now likely to be sparse with respect to the
actions.
 2019-06-14 16:54:46 +01:00
Jeff Young 41441d9ced Fix crash when fetching bounding box of empty selection. 2019-06-13 15:51:32 +01:00
Jeff Young 158e05adea Add mouse gestures to List Hotkeys. 
Fixes: lp:1778437
* https://bugs.launchpad.net/kicad/+bug/1778437
 2019-06-13 15:51:32 +01:00
Jeff Young 97d2800f16 Update hotkey maps when the hotkeys are edited. 
Also removes some legacy code dealing with conflicts.
Also disambiguates zoom in/out commands for hotkey list.
 2019-06-12 12:43:12 +01:00
Jeff Young 7726b039b2 Re-jigger standard submenus so they both link AND work. 2019-06-11 18:03:16 +01:00
Jeff Young a91934c7b3 Don't update toolbars on mouse-move events. 
It produces cursor-lag in some instances, and none of our state changes
currently rely on mouse position.

Fixes: lp:1831541
* https://bugs.launchpad.net/kicad/+bug/1831541
 2019-06-11 09:52:01 +01:00
Jeff Young 9f427da56f Use the ACTION_ID offset when updating the layer pair bitmap. 2019-06-11 09:13:56 +01:00
Jeff Young 620395608c Move Kicad Manager launch bar to ACTIONs. 
Also fixes a bug where hotkeys weren't getting put in menus.
 2019-06-10 23:46:01 +01:00
Jeff Young 5e49517781 Move hotkeys to ACTION architecture. 2019-06-10 23:46:00 +01:00
Jeff Young c13ef839c1 Tool framework for Kicad Manager frame. 2019-06-10 23:46:00 +01:00
Jeff Young 16cb1e731d Finish moving TOOL_MANAGER down to the EDA_BASE_FRAME level. 2019-06-10 23:46:00 +01:00
Jeff Young 765606012f Convert separate-compilation of selection.cpp to polymorphism. 2019-06-10 23:46:00 +01:00
Jeff Young e606587ff6 Move remaining Symbol Tree ctx menu cmds to ACTIONS. 
Also moves the various Player instantiators down into COMMON_TOOLS
for better sharing.
 2019-06-10 23:46:00 +01:00
Jeff Young 2d40425e4d Move footprint & symbol tree context menus to tool infrastructure. 
Fixes: lp:1831692
* https://bugs.launchpad.net/kicad/+bug/1831692
 2019-06-05 20:16:48 +01:00
Jeff Young 1ea5b04e22 More ACTIONS work. Nearly done now. 2019-06-04 22:31:42 +01:00
Jeff Young 568c8c336b Move DRC control to a tool; move assorted commands to ACTIONS. 2019-06-03 21:08:30 +01:00
Jeff Young 9f1e2e34b7 Move some dupicated tools to common tools. 2019-06-03 21:08:30 +01:00
Jeff Young e517199794 Move ConfigurePaths and LibTable management to common ACTIONs. 2019-06-03 21:08:30 +01:00
Jeff Young 33773bad4d Yet more command conversions to ACTIONs. 2019-06-02 21:10:56 +01:00
Jeff Young 6ac273264d Move Show3DViewer to common action. 2019-06-02 16:21:44 +01:00
Jeff Young 45a9544726 Instantate a default menu from no selection when menu is first built. 
This might resolve some of the GTK menu anomalies.
 2019-06-02 12:58:08 +01:00
Jeff Young 7f1ed30ff5 Move DeMorgan handling to ACTIONs. 2019-06-01 23:03:24 +01:00
Jeff Young 0260b32125 Push resetLocalCoords down into COMMON_TOOLS. 
Fixes: lp:1830693
* https://bugs.launchpad.net/kicad/+bug/1830693
 2019-05-29 00:26:29 +01:00
Jeff Young a27e4246e0 Move some more menu commands to ACTIONs. 2019-05-29 00:26:29 +01:00
Jeff Young 6936effaa7 Implement undo for Page Settings in PlEditor, Eeschema and PCBNew. 
Fixes: lp:1820059
* https://bugs.launchpad.net/kicad/+bug/1820059
 2019-05-27 11:58:55 +01:00
Jeff Young a3dfce5adb Implement common file menu actions and move Eeschema over. 2019-05-25 01:14:21 +01:00
Jeff Young 85f984ccd9 Add point-editor activation for immediate-mode drawing. 2019-05-24 19:49:09 +01:00
Jeff Young 09424db68f Restore selection around undo/redo. 2019-05-24 19:49:09 +01:00
Jeff Young 323bb0f8e1 Moving PageLayout editor to GAL canvas and modern toolset. 2019-05-24 19:49:09 +01:00
Jeff Young 0047f88f82 Mark unfold bus menu as clean so it doesn't get generated a second time. 
Fixes: lp:1829878
* https://bugs.launchpad.net/kicad/+bug/1829878
 2019-05-23 00:27:53 +01:00
Jeff Young 67cc2aac2e Rework Eeschema find/replace for modern toolset. 
Fixes: lp:1827274
* https://bugs.launchpad.net/kicad/+bug/1827274

Fixes: lp:1827240
* https://bugs.launchpad.net/kicad/+bug/1827240
 2019-05-22 21:48:04 +01:00
jean-pierre charras aee1fe45f4 Fix a few issues related to Bitmaps in menus. 
- fix missing icons.
- remove duplicate (and incorrect) code to set these icons in wxMenuItems
 2019-05-21 17:50:05 +02:00
Jeff Young f21faceb74 A hack to work around wxWidgets failure to capture WX_MENU_OPEN events 
See the comments.  It's not pretty, but it works.

Fixes: lp:1829640
* https://bugs.launchpad.net/kicad/+bug/1829640

Fixes: lp:1829307
* https://bugs.launchpad.net/kicad/+bug/1829307

Fixes: lp:1594029
* https://bugs.launchpad.net/kicad/+bug/1594029
 2019-05-19 22:04:28 +01:00
Jeff Young 7d9a0b06e0 Push help menu down into EDA_BASE_FRAME. 2019-05-18 13:14:08 +01:00
Jeff Young 13aa503614 Hack for wxWidgets failure to open menu on MSW. 2019-05-18 00:21:49 +01:00
Jeff Young 1a3d0492f5 Push polar coords down into COMMON_TOOLS. 2019-05-18 00:21:49 +01:00
Jeff Young fbb807f3bb Move some more menu & toolbar items to modern toolset. 2019-05-16 19:57:06 +01:00
Jeff Young 69afa27a5f Implement ACTION_TOOLBAR and update some of the menus to ACTION_MENU. 
This gives us better separation of MVC in line with the design of
the modern toolset.  It also reduces a whole bunch of duplicated
data.
 2019-05-15 17:50:52 +01:00
Jeff Young f9e4ee1fc9 CONTEXT_MENU -> ACTION_MENU. (Now used for menu-bar menus too.) 2019-05-15 17:50:52 +01:00
Jeff Young e850592587 Cleanup. 2019-05-15 17:50:52 +01:00
Jeff Young ef5c69167a Start moving some LibEdit and SchEdit menubar menus to actions. 
Also includes a bunch of bug fixes that got intermingled.

Fixes: lp:1828826
* https://bugs.launchpad.net/kicad/+bug/1828826

Fixes: lp:1828826
* https://bugs.launchpad.net/kicad/+bug/1828826

Fixes: lp:1828793
* https://bugs.launchpad.net/kicad/+bug/1828793
 2019-05-13 21:44:29 +01:00
Jeff Young ea0941cab3 Implement modern tools for LibEdit. 2019-05-10 16:11:57 +01:00
Jeff Young cd2bd23c37 Fix a bunch of issues with hotkeys, IDs and event processing. 
Fixes: lp:1827894
* https://bugs.launchpad.net/kicad/+bug/1827894
 2019-05-06 21:42:00 +01:00
Jeff Young ed0e6af66d Move to direct tool registration. 
It was confusing that the primary frames registered their tools
differently than the other frames.  In addition, since the other
frames also added their own tools, foo_actions::RegisterAllTools()
didn't really register all tool but rather those used by the
principal frame (PCB_EDIT_FRAME, SCH_EDIT_FRAME, etc.)
 2019-05-05 17:14:30 +01:00
Jeff Young 20b63174dc Support wire & bus drawing from selection tool. 2019-05-05 17:14:30 +01:00
Jeff Young 29f1787af2 Logic improvements and fixes for wire segment selection states. 2019-05-05 17:14:30 +01:00
Jeff Young 423d430b58 Replace deleteNode and deleteConnection with selectNode and selectConnection. 2019-05-05 17:14:29 +01:00
Jeff Young 2244dcd567 Move show datasheet to SCH_INSPECTOR_TOOL and add show marker info. 2019-05-05 17:12:59 +01:00
Jeff Young 902be18a04 More modern toolset context menu work. 
Text/label type changes and bus entry shape changes.  And some
context menu bug fixing.
 2019-05-05 17:12:59 +01:00
Jeff Young 42383ae871 Build out some of the modern toolkit context menus. 2019-05-05 17:12:59 +01:00
Jeff Young 1a007c3e4b Implement SCH_SELECTION_TOOL (but still with legacy semantics). 2019-04-22 22:08:18 +01:00
Jeff Young c88fd514a0 Implement drawing tools in modern toolset. 
Fixes: lp:1825192
* https://bugs.launchpad.net/kicad/+bug/1825192
 2019-04-17 21:49:50 +01:00
Jeff Young 94a948fdd1 Move grid selection for both Eeschema and Pcbnew to COMMON_TOOLS. 2019-04-13 18:43:35 +01:00
Jon Evans dec5d80180 Veto mouse warping from DRC dialog 
Fixes: lp:1824630
* https://bugs.launchpad.net/kicad/+bug/1824630
 2019-04-13 11:23:57 -04:00
Jeff Young 3c11b89e4c Hook up refresh buttons to library tree synchronisation. 
Fixes: lp:1820057
* https://bugs.launchpad.net/kicad/+bug/1820057
 2019-04-11 19:45:10 +01:00
Jeff Young adf3637476 Allow dialogs to veto mouse-warping when called from context menu. 
Fixes: lp:1745731
* https://bugs.launchpad.net/kicad/+bug/1745731
 2019-04-08 20:07:40 +01:00
Seth Hillbrand d15876595f Fix init order to quiet warnings 2019-02-16 12:53:45 -08:00
Seth Hillbrand 813578eba6 Fix a few coverity errors 2019-02-15 20:15:04 -08:00
John Beard 267e17d539 QA: Add a generic utility tool executable. 
The intention here is to make it possible to wrap up many of the
KiCad utility tools into a single executable. This reduces link times
as well as the duplication of CMake files needed to build very
similar tools.

This particular tool should be suitable for any code in common,
code in pcbnew and other end-executables probalby will need an
analagous version linked to the relevant kiface.

The first tool is the coroutine_example.cpp test case, which
can be useful when learning, debugging or porting the coroutine
infrastructure.
 2019-01-22 09:04:38 -05:00
Seth Hillbrand 0f1a11ef38 pcbnew: Cut only copied objects 
Fixes a bug where objects where accessed after being freed by the cut

Fixes: lp:1811456
* https://bugs.launchpad.net/kicad/+bug/1811456
 2019-01-11 17:27:29 -08:00
Seth Hillbrand 8f11a2133e Revert "QA: Add a generic utility tool executable." 
This reverts commit 502306314e.
 2019-01-06 16:17:44 -08:00
John Beard 502306314e QA: Add a generic utility tool executable. 
The intention here is to make it possible to wrap up many of the
KiCad utility tools into a single executable. This reduces link times
as well as the duplication of CMake files needed to build very
similar tools.

This particular tool should be suitable for any code in common,
code in pcbnew and other end-executables probalby will need an
analagous version linked to the relevant kiface.

The first tool is the coroutine_example.cpp test case, which
can be useful when learning, debugging or porting the coroutine
infrastructure.
 2019-01-06 07:51:23 -08:00
jean-pierre charras 256f1a26e6 Fix a compil issue with gcc 4.8.4 compiler 
On Ubuntu 14.04 the compiler does not like using const iterators instead of iterators.
 2018-10-25 20:24:33 +02:00
Seth Hillbrand 1dd22f5035 SELECTION: Utilize sorted deque 
Many operations on the selection involved getting an item by index or
dereference.  The std::set needed to iterate from the beginning of the
set to find the item in its red-black tree.  Using a deque that we keep
sorted, we get index access in O(1) and item search in O(lg N).
 2018-10-24 16:32:34 -07:00
John Beard b64c6dbf35 Use wxCHECKs to protect non-position TOOL_EVENTS 
Getting the position of a non-position TOOL_EVENT will
now result in a wxCHECK, and a null-position (0,0) will
be returned. The new interface HasPosition() can be used
to determine if a call to a position function is safe to
make from the caller.

Fixes the underlying danger behind lp:1796045, which has
already been neutralised by a4966adb6, which avoids calling
the Position() functions when the TOOL_EVENT is not known
to be a position.

Fixes: lp:1796045
* https://bugs.launchpad.net/kicad/+bug/1796045
 2018-10-12 09:08:07 -07:00
John Beard 445a9fa963 Put cursor and pan control in libcommon/tool, enable in Gerbview 
Put the cursor and pan control TOOL_ACTIONs in ACTION,
and refer to them in that way.

The handlers are currently identical in Pcbnew and Cvpcb,
and Gerbview (and all canvases) can benefit from them as well
if they are in libcommon. Also saves duplicated code.

Fixes: lp:1795855
* https://bugs.launchpad.net/kicad/+bug/1795855
 2018-10-04 11:41:06 +02:00
Jeff Young cbb3492d98 Standardize Footprint Viewer and Footprint Browser. 
Add Display Settings to Footprint Browser.
Make each of them OpenGL on OSX and Cairo on other platforms.
Allow auto-zoom to be turned off and save last zoom setting.
Make ordering of tools in htoolbar consistent.
Standardize grid and zoom drop-downs.

Fixes: lp:1791667
* https://bugs.launchpad.net/kicad/+bug/1791667
 2018-09-12 14:01:35 +01:00
Jeff Young 5f3ee1e7ce More g_UserUnit erradication. 
(cherry picked from commit 3f08780)
 2018-07-17 15:12:31 +01:00
Jeff Young 05ef6f05d1 Move SanitizePads to CLIENT_SELECTION_FILTER architecture. 
This not only reduces the number of different mechanisms, but
will also reduce (yet again) the number of Clarify Selection
pop-ups (because the CLIENT_SELECTION_FILTER runs before the
pop-up, while SanitizePads ran after it).

Fixes: lp:1710451
* https://bugs.launchpad.net/kicad/+bug/1710451

(cherry picked from commit e50a993)
 2018-07-17 15:10:18 +01:00
Carsten Schoenert 9f7109826d fix misspelled 'allows to' -> 'allows one to' 
Fixup small grammar issues around used 'allows to ...' almost in
code comments.
 2018-07-11 10:35:03 -04:00
Jeff Young 79e0bb08d0 Architecturally-simpler fix for grid context menu unit changes. 
Fixes: lp:1777519
* https://bugs.launchpad.net/kicad/+bug/1777519
 2018-06-20 16:54:24 +01:00
Jeff Young 3c7b91b96a Always create grid menu so units are up-to-date. 
Fixes: lp:1777519
* https://bugs.launchpad.net/kicad/+bug/1777519
 2018-06-19 10:52:36 +01:00
Jeff Young cd5f727880 Fix off-by-1 errors in zoom menus & use zoom steps in GAL canvas. 
Also bumps the maximums a bit (at user request).

Fixes: lp:1773215
* https://bugs.launchpad.net/kicad/+bug/1773215
 2018-05-25 13:01:58 +01:00
jean-pierre charras 319908b7f4 fix a compil issue. 2018-04-24 15:20:35 +02:00
Maciej Suminski 143d580596 Fixed relative coordinates reset when a tool forces the cursor position 
Fixes: lp:1759044
* https://bugs.launchpad.net/kicad/+bug/1759044
 2018-04-24 12:56:19 +02:00
Jeff Young 99e659ff54 Coverity fixes. 2018-03-21 23:11:55 +00:00
Tomasz Włostowski af7064ef89 pcbnew: synchronize zone visibility view menu entries with the toolbar buttons 2018-03-03 17:38:28 +01:00
Carsten Schoenert 6256feb9db fix misspelled 'occured' -> 'occurred' 2018-02-25 17:10:10 -05:00