haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
15,777 Commits 9 Branches 105 Tags 1.3 GiB
Commit Graph

4475 Commits

Author SHA1 Message Date
Jeff Young 25209516a6 Adjust net highlighting after edits. 
Fixes: lp:1800291
* https://bugs.launchpad.net/kicad/+bug/1800291
 2019-05-12 18:20:41 +01:00
Jeff Young f602ccd814 Insert EE_TOOL_BASE under SchEdit and LibEdit tools, and fix errant rename scope which clobbered PCBNew's PICKER_TOOL. 2019-05-12 13:47:08 +01:00
Jeff Young 5c39521149 Move Symbol Properties and Pin Table to actions. 
Fixes: lp:1804273
* https://bugs.launchpad.net/kicad/+bug/1804273
 2019-05-11 15:38:49 +01:00
Jeff Young 7995b5cc3c Restore selection on abort and undo/redo. 
Also includes a related bug fix to not create an undo record for
the initial schematic cleanup.

Fixes: lp:1825975
* https://bugs.launchpad.net/kicad/+bug/1825975
 2019-05-11 15:38:49 +01:00
Jeff Young 76a915d472 Fix highlighting when initiated via ctrl-click. 
Fixes: lp:1796755
* https://bugs.launchpad.net/kicad/+bug/1796755
 2019-05-11 15:38:49 +01:00
jean-pierre charras 0a308c4584 Fix minor compil warnings 2019-05-11 11:12:39 +02:00
jean-pierre charras 17ac5b6d13 DIALOG_EDIT_COMPONENT_IN_LIBRARY: fix a dialog resize issue (grid not resized). 2019-05-11 10:07:30 +02:00
jean-pierre charras e19141bdc8 LIB_CIRCLE: fix missing transform of m_EndPos in mirror and rotate. 
Fixes: lp:1828655
https://bugs.launchpad.net/kicad/+bug/1828655
 2019-05-11 08:46:27 +02:00
Jeff Young 9cc3d6764f fixup! Fix some legacy set-to-idle statements. 2019-05-10 23:25:54 +01:00
Jeff Young b83dac68d0 Fix drag-select hit-testing of LibEdit items. 2019-05-10 23:24:27 +01:00
Jeff Young 5e08be7018 Fix some legacy set-to-idle statements. 2019-05-10 23:24:02 +01:00
Jeff Young 792c4328aa Cleanup. 2019-05-10 21:40:08 +01:00
Jeff Young a9f663d5ef Soften hit-testing in SchEdit and LibEdit a bit. 
Old threshold was 0; new is 5 pixels.
 2019-05-10 20:46:28 +01:00
Jeff Young 0c2ba94b16 More sharing between SchEdit and LibEdit. 2019-05-10 20:22:26 +01:00
Jeff Young 86d1592777 Fix bug with re-enting selection main loop. 2019-05-10 19:56:20 +01:00
Jeff Young c1539ae014 Naming changes to reflect sharing between SchEdit and LibEdit. 2019-05-10 19:56:20 +01:00
Jeff Young f3c95ad83c Clean up the RepeatItem architecture and finish deleting the UndoItem facility. 2019-05-10 19:56:20 +01:00
Jeff Young 7da2631b27 Check item before concluding that ConvertText has run. 
Otherwise we set item from nullptr back to the selection, and then
we think we're dragging again which causes all kinds of grief.

Fixes: lp:1828067
* https://bugs.launchpad.net/kicad/+bug/1828067
 2019-05-10 16:11:57 +01:00
Jeff Young f6e07f575a Rename for clarity. 
SetOffset() didn't set anything; it performed an action.
Move() suggests a delta, when it in fact does a SetPosition().
 2019-05-10 16:11:57 +01:00
Jeff Young ea0941cab3 Implement modern tools for LibEdit. 2019-05-10 16:11:57 +01:00
Jeff Young 40f41133b3 Move Circle, Arc, Rectangle and PolyLine tools to modern toolset. 2019-05-10 16:11:57 +01:00
Wayne Stambaugh ae54f34392 Eeschema: fix corrupted schematic and symbol library files. 
Prevent user from pasting text with carriage return and/or line feed
characters in field value edit control in the schematic symbol and symbol
library properties dialogs.

Make all objects derived from GRID_CELL_TEXT_BUTTON use validators
correctly.

Add validators to FIELDS_GRID_TABLE object for field values other than
the mandatory fields.

Create a validator to check that a string is a valid LIB_ID.

Fixes lp:1828214

https://bugs.launchpad.net/kicad/+bug/1828214
 2019-05-10 08:21:37 -04:00
Seth Hillbrand 589a37bfe8 eeschema: Don't segfault on empty drawlist 2019-05-09 15:11:36 -07:00
Seth Hillbrand 0e5f5d37d1 eeschema: Fix sign error in comparison 2019-05-09 14:10:53 -07:00
Seth Hillbrand 2f782ac7a4 eeschema: Prevent double-commit on duplicate/copy 
When activating the move from a drag extension, we need to add
additional components to the commit.  This breaks for duplicate/copy
when we have already added the correct components
 2019-05-09 13:46:35 -07:00
jean-pierre charras c716d66e53 Fix typo 2019-05-08 14:28:31 +02:00
Jon Evans 3e5005698c Add a bit of margin to line selection hit testing 2019-05-07 22:51:46 -04:00
Jon Evans c02777a721 Clean up some unnecessary header dependencies 2019-05-07 22:50:10 -04:00
Jon Evans 8341e3f972 Ensure prefixes and suffixes make it on to bus members 2019-05-07 22:48:25 -04:00
Jon Evans 1de5b83d82 Promote net names to higher in hierarchy when possible 2019-05-07 21:59:36 -04:00
Jon Evans 81993eef83 Ensure bus member links get updated in hierarchical situations 2019-05-07 21:31:53 -04:00
Jon Evans 3d3c280f22 Fix hierarchical linking if parent sheet has a weak driver 2019-05-07 21:31:53 -04:00
Jeff Young a40367ce17 Add a wire between direct-connect items when only is being dragged. 
Fixes: lp:1798968
* https://bugs.launchpad.net/kicad/+bug/1798968
 2019-05-07 20:39:46 +01:00
Jeff Young 469231ae15 Move Pin, Symbol Text and Symbol Anchor to modern toolset. 2019-05-07 20:39:46 +01:00
Jeff Young 2e4d948535 Fix some more hotkey issues. 
Also reformatted the file to make it easier to see what is there and
what is missing.  Apologies to the 100-char-width folks, but we were
just missing to many command IDs in this file.

Fixes: lp:1828006
* https://bugs.launchpad.net/kicad/+bug/1828006
 2019-05-07 20:39:46 +01:00
Jeff Young cf046e0548 Anchor a selected wire at the edge of a drag which is connected to a non-drag item. 
Fixes: lp:1827846
* https://bugs.launchpad.net/kicad/+bug/1827846
 2019-05-07 12:04:19 +01:00
Jeff Young f40408187e A couple of temp hacks for LibEdit <esc> processing while in transition. 
Fixes: lp:1828004
* https://bugs.launchpad.net/kicad/+bug/1828004
 2019-05-07 12:04:19 +01:00
Jeff Young 11ec7d4651 Invert the Y axis of SCH_PIN coords when hit-testing. 
Fixes: lp:1827849
* https://bugs.launchpad.net/kicad/+bug/1827849
 2019-05-07 12:04:19 +01:00
Jeff Young 2097411550 Refresh RequestSelection selection if all items were filtered out. 
If you have, for instance a pin selected and do a cmd-E we'll filter
out the pin and then do nothing.  We should instead treat it as a
hover selection if everything got filtered.
 2019-05-07 12:04:19 +01:00
jean-pierre charras 2c43d4d6bf Eeschema: fix incorrect display of the page number in a complex hierarchy. 
When, inside a complex hierarchy, one switch from an instance of a sheet to an other instance of this sheet,
the page number shown in the worksheet was not updated on screen, and the initial number was displayed.

Fixes: lp:1827981
https://bugs.launchpad.net/kicad/+bug/1827981
 2019-05-07 10:55:26 +02:00
Jon Evans 316be464ab Handle higher-priority connection drivers located in subsheets 
Fixes: lp:1827850
* https://bugs.launchpad.net/kicad/+bug/1827850
 2019-05-06 22:09:05 -04:00
Jeff Young f1a38a6d41 Respond to <esc> from selection tool. 
Fixes: lp:1827917
* https://bugs.launchpad.net/kicad/+bug/1827917
 2019-05-06 21:56:19 +01:00
Jeff Young cd2bd23c37 Fix a bunch of issues with hotkeys, IDs and event processing. 
Fixes: lp:1827894
* https://bugs.launchpad.net/kicad/+bug/1827894
 2019-05-06 21:42:00 +01:00
Jeff Young e5151ed639 Use parent's transform when moving SCH_FIELDs. 
Fixes: lp:1827873
* https://bugs.launchpad.net/kicad/+bug/1827873
 2019-05-06 21:41:44 +01:00
Jeff Young a76bcc204f Use parent's transform when moving SCH_FIELDs. 
Fixes: lp:1827873
* https://bugs.launchpad.net/kicad/+bug/1827873
 2019-05-06 16:59:23 +01:00
Jeff Young b97d65e791 Fix crash bug when deleting sheet pin and disappearing bug when moving them. 
Fixes: lp:1827890
* https://bugs.launchpad.net/kicad/+bug/1827890
 2019-05-06 16:31:02 +01:00
Jeff Young 13beb344ca Fix LIB_FIELD selection bug. (It wasn't checking for convert == 0.) 2019-05-06 16:01:39 +01:00
Jeff Young d12eee9c98 Process new sheets after drawing. 2019-05-06 15:31:23 +01:00
Jeff Young 207900e4f9 Move libedit message panel updating to the Inspection Tool. 2019-05-06 15:31:23 +01:00
Jeff Young a12d769074 Code clarification and commenting. 
Also renames toolbar files to reduce confusion with the modern toolset
tool files.
 2019-05-06 15:31:23 +01:00
Jeff Young 8e75824d29 Use selection tool for locateItem. 2019-05-06 15:31:23 +01:00
Jeff Young f87d371b8b Move to shared COLLECTORS for sch and lib. 2019-05-06 15:31:23 +01:00
Jeff Young cc439f9ab0 Replace accidentally deleted mouse processing for LibEdit. 2019-05-06 03:30:51 +01:00
Jeff Young 49231ac08f Fix missing event processing for Leave Sheet button in toolbar. 2019-05-06 03:30:51 +01:00
Jon Evans 09c9db472e Properly handle buses that have been linked by net wires only 
Fixes: lp:1825532
* https://bugs.launchpad.net/kicad/+bug/1825532
 2019-05-05 19:48:55 -04:00
Jon Evans e9eacbc91c Ensure subgraphs with multiple labels get sorted 2019-05-05 19:09:05 -04:00
Jon Evans 019a731e03 Back-propagate from child sheets when two parents point to one child 2019-05-05 16:05:36 -04:00
Jeff Young b7e67073ef Fix bugs in bus unfold logic. 
The worst of which left you in the bus unfold popup menu event loop
if you cancelled the menu by clicking outside it.
 2019-05-05 19:48:11 +01:00
Jeff Young 0b2e1d00ea Don't allow motion between two clicks of a dblclick to spoil forceHV. 2019-05-05 18:38:49 +01:00
Jeff Young d881f4b21f When unfolding a bus from the selection tool, stay in that tool. 2019-05-05 18:36:18 +01:00
Jeff Young c4fac81dbb Transition from bus to wire tool when unfolding bus. 2019-05-05 17:14:30 +01:00
Jeff Young a42a4b0b52 Implement immediate bus unfold and add bus unfold to selection context menu. 2019-05-05 17:14:30 +01:00
Jeff Young fd546da640 Homogenize hit testing and selection return types. 
Prep work for sharing SCH_SELECTION_TOOL with LibEdit.
 2019-05-05 17:14:30 +01:00
Jeff Young 2d28ab7dd2 More cleanup. 2019-05-05 17:14:30 +01:00
Jeff Young 32765ebffd Do some refactoring in prep for sharing some sch tools with libedit. 2019-05-05 17:14:30 +01:00
Jeff Young ed0e6af66d Move to direct tool registration. 
It was confusing that the primary frames registered their tools
differently than the other frames.  In addition, since the other
frames also added their own tools, foo_actions::RegisterAllTools()
didn't really register all tool but rather those used by the
principal frame (PCB_EDIT_FRAME, SCH_EDIT_FRAME, etc.)
 2019-05-05 17:14:30 +01:00
Jeff Young dd9c426922 Cleanup a TODO. 2019-05-05 17:14:30 +01:00
Jeff Young b5fd7b9842 Move Leave Sheet to the top of the context menu. 2019-05-05 17:14:30 +01:00
Jeff Young 7e3ad4585a Fix issues with dragging, moving and rotating wires. 2019-05-05 17:14:30 +01:00
Jeff Young 2edb09e583 Double click action should enter sheet. 2019-05-05 17:14:30 +01:00
Jeff Young 4ccfa17ff9 Fix bugs in sheet duplicate & copy/paste. 
Don't edit sheet during AddToScreenAndUndoList() call.  If it's
cancelled and we delete the item, callers will still own pointers
to the freed memory.  Do it in New and Paste instead.
 2019-05-05 17:14:30 +01:00
Jeff Young 554094ada6 Fix de-reference of freed memory issue. 2019-05-05 17:14:30 +01:00
Jeff Young a825cdfa5a Fix new image drawing issue. 2019-05-05 17:14:30 +01:00
Jeff Young bcdc3ad90a Set IS_NEW flag on new images. And a bunch of cleanup of dead code. 2019-05-05 17:14:30 +01:00
Jeff Young 21b315f2af Finish removing GetCurItem() from eeschema. 2019-05-05 17:14:30 +01:00
Jeff Young 6e695aac25 Move bus unfold and symbol unit selection to modern toolkit. 2019-05-05 17:14:30 +01:00
Jeff Young f4b92e6acf Refactor as SCH_DRAWING_TOOL was getting too big. 2019-05-05 17:14:30 +01:00
Jeff Young 2774af928a Remove extra Show Datasheet menu item. 2019-05-05 17:14:30 +01:00
Jeff Young 20b63174dc Support wire & bus drawing from selection tool. 2019-05-05 17:14:30 +01:00
Jeff Young f95f202f81 Restore Jon's change which I accidentally nuked. 2019-05-05 17:14:30 +01:00
Jeff Young f187f91f57 Seth's fixes to regex processing. 2019-05-05 17:14:30 +01:00
Jeff Young 1cc3055481 Allow rotation/mirroring of wires. 2019-05-05 17:14:30 +01:00
Jeff Young 4ca0f4da10 Fixes to the context menu logic around wire/bus drawing. 2019-05-05 17:14:30 +01:00
Jeff Young 7273748c57 Context menu cleanup for eeschema modern toolset. 2019-05-05 17:14:30 +01:00
Jeff Young 90a663facd Implement sheet cleanup in modern toolset. 2019-05-05 17:14:30 +01:00
Jeff Young 1e5334f5d4 Implement DeMorgan conversions in modern toolset. 2019-05-05 17:14:30 +01:00
Jeff Young 7c54fc9c46 Cleanup. 2019-05-05 17:14:30 +01:00
Jeff Young 29f1787af2 Logic improvements and fixes for wire segment selection states. 2019-05-05 17:14:30 +01:00
Jeff Young c09817e08c Context menus for labels. 2019-05-05 17:14:30 +01:00
Jeff Young 0ea156042b Fix over-zealous wire-grabbing for drag. 2019-05-05 17:14:30 +01:00
Jeff Young a61bbea4bd Fix issue with selection being inadvertantly cleared via ClearFlags(). 
Also fixes an undo bug when pick-component-rotate-place-undo.
 2019-05-05 17:14:30 +01:00
Jeff Young 59af079cbd Fix some hotkey collisions. 2019-05-05 17:14:30 +01:00
Jeff Young 58ba573038 Handle cascading selections in placement. 
See https://forum.kicad.info/t/call-for-testers-eemodern/16663/32
 2019-05-05 17:14:29 +01:00
Jeff Young e9dd8542d1 Allow user to change from move to drag and vice versa. 
Also fixes bugs when doing a duplicate in the middle of a move.
 2019-05-05 17:14:29 +01:00
Jeff Young 0af7c87277 Add resize sheet to context menus. Fix bugs in it. 
Also assign a bunch of icons that were missing.
 2019-05-05 17:14:29 +01:00
Jeff Young bbd8659f69 Implement explicit cross-probing (mainly for sheets which are too slow to do automatically). 
Also moves the message panel updaters to SCH_INSPECTION_TOOL.
 2019-05-05 17:14:29 +01:00
Jeff Young 588d13a912 Fix gcc issue with temp variable and move some collection specs. 
Having the collection specs localized with their code improves
encapsulation.

(Thanks to crasic for the original patch.)
 2019-05-05 17:14:29 +01:00
Jeff Young 35e8a340ca Add enter/leave sheet to modern toolset. 2019-05-05 17:14:29 +01:00
Jeff Young 423d430b58 Replace deleteNode and deleteConnection with selectNode and selectConnection. 2019-05-05 17:14:29 +01:00
Jeff Young 1ff7869ec3 Move Edit with Symbol Editor to modern toolset context menu. 2019-05-05 17:12:59 +01:00