Tomasz Włostowski
e988cd9c25
Fixed crash in footprint chooser in eeschema triggering in standalone/no-pcbnew mode
...
Fixes: lp:1797644
* https://bugs.launchpad.net/kicad/+bug/1797644
2018-10-12 23:43:08 +02:00
Jeff Young
779ef044b7
Fix wxGrid column dragging bugs.
...
Close an open editor when dragging (as wxWidgets won't move it).
Make sure native column headers aren't in use where we need dragging:
their interaction with wxWidgets' dragging is buggy.
Fixes: lp:1796398
* https://bugs.launchpad.net/kicad/+bug/1796398
Fixes: lp:1796396
* https://bugs.launchpad.net/kicad/+bug/1796396
2018-10-09 21:33:43 +01:00
Jeff Young
55c1ca1191
Handle pin sorting properly for values.
...
The pin number sorter doesn't handle units at all, and seems to
stumble on negative numbers.
Fixes: lp:1796869
* https://bugs.launchpad.net/kicad/+bug/1796869
2018-10-09 14:56:29 +01:00
jean-pierre charras
88cdce8d62
Make SYMBOL_PREVIEW_WIDGET working, and using the canvas type of the caller. Fix an issue with F3 zoom key in libedit.
2018-10-09 11:08:56 +01:00
Jeff Young
96724af2c4
Ensure junctions and no-connects are visible even on fat wires.
...
Also adds a preference for junction size.
Fixes: lp:1545422
* https://bugs.launchpad.net/kicad/+bug/1545422
2018-10-09 11:08:56 +01:00
Jeff Young
37cfa3fed9
Cleanup unused and redundant stuff.
2018-10-09 11:08:56 +01:00
Jeff Young
5fd20ee786
Implementation of ERC markers.
2018-10-09 11:08:55 +01:00
Jeff Young
47189034aa
Grid settings for LibEdit.
2018-10-09 11:08:55 +01:00
Jeff Young
afeebc8944
Grid settings for Eeschema GAL.
...
Split antialiasing options out from display options. Move
antialiasing to common. Duplicate the rest of display options
for Eeschema.
Implement OnSelectGrid and hookup GAL canvas refresh to
SetPresetGrid.
Add Grid Settings... to View menu and move Show Grid from
preferences to View Menu to match Pcbnew.
2018-10-09 11:08:55 +01:00
Jeff Young
1c52824913
Rewrite unit/convert handling so it also works for LibEdit.
2018-10-09 11:08:55 +01:00
Jeff Young
6eafb9a2fd
Convert Rescue Symbols dialog previews to GAL.
2018-10-09 11:08:55 +01:00
Jeff Young
538a5d49ee
Fix up GAL version of Symbol Viewer.
...
Also includes some preliminary work for supporting hidden pins,
pin electrical names, and other preferences.
2018-10-09 11:08:55 +01:00
Jeff Young
7cbfa08ddd
Move symbol chooser dialog preview to GAL.
2018-10-09 11:08:55 +01:00
Tomasz Wlostowski
90c7c60471
eeschema-gal: initial GALified version. Lots of stuff still to do!
2018-10-09 11:08:52 +01:00
Jeff Young
90df7a8b22
Sort references before removing duplicates.
...
std::unique only works within consecutive blocks, so the list must
be sorted first. (We need it sorted in the end anyway, so no
big deal.)
2018-10-08 00:14:07 +01:00
Jeff Young
8015334683
Don't resize hidden columns.
...
wxGrid columns are hidden by setting their width to 0. Resizing
them will "unhide" them.
Fixes: lp:1796150
* https://bugs.launchpad.net/kicad/+bug/1796150
2018-10-05 14:17:58 +01:00
Jeff Young
3c2aafd7b7
Move Edit Symbol References to standard text/button control.
2018-09-29 22:07:31 +01:00
jean-pierre charras
094f340359
Eeschema: Opening "Edit Symbol Fields" dialog crashes Eeschema
...
Fixes: lp:1795088
https://bugs.launchpad.net/kicad/+bug/1795088
2018-09-29 10:08:29 +02:00
Jeff Young
6fdfd0932e
Use newer wxWidgets calls (old ones aren't available on MSW).
2018-09-27 18:53:46 +01:00
Jeff Young
5703060d87
Turn off escaping names for now.
...
Fixes: lp:1794816
* https://bugs.launchpad.net/kicad/+bug/1794816
2018-09-27 17:21:49 +01:00
Jeff Young
e456ecd0a1
Calculate column widths based on all data, not just shown data.
...
Also caps the calculated width at 1/3 of the default dialog width.
Fixes: lp:1794625
* https://bugs.launchpad.net/kicad/+bug/1794625
2018-09-27 16:57:25 +01:00
Jeff Young
521183a587
Work in progress to allow arbitrary chars in references, etc.
2018-09-27 11:56:51 +01:00
Simon Richter
1253020a8b
Add missing header
2018-09-24 10:47:15 -04:00
jean-pierre charras
b70d0f43b6
Fix minor compil warnings.
2018-09-24 13:12:47 +02:00
Maciej Suminski
e6f2c49eae
Spice model editor: support for JFET models
2018-09-22 19:05:01 +02:00
Maciej Suminski
f2f6dffd16
Refactored logic in Spice model editor dialog
...
- Removed redundant enums
- Stored Spice model description in an array
- Made code generic by using the model description array
2018-09-22 19:04:54 +02:00
Jeff Young
5974899fa5
Clean up file locations and names.
2018-09-22 16:23:13 +01:00
Jeff Young
618182dcd6
Use pin number sorting algorithm in pin table.
...
Fixes: lp:1793180
* https://bugs.launchpad.net/kicad/+bug/1793180
2018-09-19 22:23:18 +01:00
Jeff Young
e5e1a315f1
Keep name & value in sync for library items.
...
Also fixes library reference highlighting from board footprints.
Fixes: lp:1792243
* https://bugs.launchpad.net/kicad/+bug/1792243
Fixes: lp:1792256
* https://bugs.launchpad.net/kicad/+bug/1792256
2018-09-13 16:41:23 +01:00
Jeff Young
806b1fc63d
Fix bugs to enable read-only grid cells to be copied.
...
Fixes: lp:1791129
* https://bugs.launchpad.net/kicad/+bug/1791129
2018-09-12 14:01:36 +01:00
jean-pierre charras
bfb0fac015
Minor fixes related to I18n
2018-09-05 13:59:20 +02:00
Jeff Young
95a08d0dbc
Follow file naming conventions.
2018-09-01 14:05:16 +01:00
Jeff Young
270f81f03d
Make fill colour terminology more consistent.
...
Fixes: lp:1789855
* https://bugs.launchpad.net/kicad/+bug/1789855
2018-09-01 14:05:16 +01:00
Jeff Young
c90a3efea2
Change KIDIALOG hashing algorithm to __FILE__ + __LINE__.
...
Using Title + Message wasn't working for all the dialogs which
did substitutions in the message (which was a lot of them).
Fixes: lp:1789348
* https://bugs.launchpad.net/kicad/+bug/1789348
2018-08-29 23:38:23 +01:00
Jeff Young
946f4a217d
Fix grid sizing for symbol aliases.
2018-08-29 20:08:01 +01:00
Jeff Young
00b2c21820
Missed a HIG destructive button separation.
2018-08-29 20:08:00 +01:00
Jeff Young
a9c8a7b69c
Remove unused warp mouse parameter.
2018-08-29 19:59:02 +01:00
Jeff Young
45bc1b1aff
Add single-click editing to grid cells. (Experimental.)
2018-08-29 19:59:02 +01:00
Jeff Young
b90a261d5c
More safety fixes for uncommitted grid changes.
2018-08-29 19:59:01 +01:00
Wayne Stambaugh
089f27f485
Remove more dialog control borders.
2018-08-27 15:11:27 -04:00
jean-pierre charras
c756fc318e
Fix a few wxWidgets minor alerts in DIALOG_EDIT_COMPONENTS_LIBID_BASE.
2018-08-22 17:14:30 +02:00
Jeff Young
779398891d
Follow HIG guidelines for destructive button separation.
2018-08-21 10:34:41 +01:00
Jeff Young
65f62f93ef
Fix MSW spacing issues.
2018-08-21 10:34:41 +01:00
Jeff Young
afacb6e7cb
Improve safety around un-committed grid changes.
2018-08-21 10:34:41 +01:00
jean-pierre charras
8fd686e8f4
Eeschema: Fix 2 minor compil warnings. Pcbnew, very minor fix: avoid using fixed scaling factor in code. Use internal units conversion instead.
2018-08-15 13:39:25 +02:00
Jeff Young
d72fdaed29
Rewrite Library Symbol Properties dialog.
...
Fix the user-model issues around aliases and alias selection.
Fold Library Symbol Fields into Library Symbol Properties.
Update to the new look.
Fixes: lp:1744773
* https://bugs.launchpad.net/kicad/+bug/1744773
Fixes: lp:1766205
* https://bugs.launchpad.net/kicad/+bug/1766205
Fixes: lp:1786339
* https://bugs.launchpad.net/kicad/+bug/1786339
2018-08-14 13:54:04 +01:00
Jeff Young
4b1a31ffad
Regularize save-changes dialogs.
2018-08-12 00:02:37 +01:00
Jeff Young
e932eed738
Allow TemplateFieldNames to specify URL-behaviour.
...
Fixes: lp:1785879
* https://bugs.launchpad.net/kicad/+bug/1785879
2018-08-11 17:14:27 +01:00
jean-pierre charras
d2eb9e0735
Eeschema, Dialog annotate: fix incorrect management that creates a crash when try to open it a second time.
...
Fixes: lp:1786618
https://bugs.launchpad.net/kicad/+bug/1786618
2018-08-11 17:19:24 +02:00
Jeff Young
bea98d8265
Reimplement close for Annotation dialog.
...
wxWidgets auto-dialog-handling for modeless dialogs just hides
them.
Fixes: lp:1785526
* https://bugs.launchpad.net/kicad/+bug/1785526
2018-08-07 17:01:44 +01:00
Jeff Young
9aa043ef48
Reinstate close/cancel handling for ERC dialog.
...
It needs it because it's a modeless dialog.
Fixes: lp:1785655
* https://bugs.launchpad.net/kicad/+bug/1785655
2018-08-06 21:31:53 +01:00
Jeff Young
d788c9d479
Move library table dialogs from PLAYER to KIFACE interface.
...
Spooling up a full PLAYER in the background takes too long.
This also fixes bugs around how the tables are saved, although
that was just missing code rather than anything architectural.
Fixes: lp:1785436
* https://bugs.launchpad.net/kicad/+bug/1785436
2018-08-06 21:31:53 +01:00
Jeff Young
9e84c3fc3b
Use a white background for "No symbol selected" message.
2018-08-06 13:48:17 +01:00
Jeff Young
0fbe702043
Layout adjustments to Choose Symbol and Choose Footprint.
2018-08-06 13:48:17 +01:00
jean-pierre charras
e556cb8c91
Fix a minor wxWidgets debug alert.
2018-08-03 21:28:44 +02:00
Wayne Stambaugh
8e7d6063fd
Minor dialog and frame window improvements.
...
Drop all uses of wxRAISED_BORDER and wxSUNKEN_BORDER from dialogs and
panels used in main frame windows.
Drop use of wxSP_3DSASH options on all wxSplitterWindow definitions.
Minor dialog alignment and spacing fixes.
2018-08-02 13:00:41 -04:00
jean-pierre charras
ce3760438c
Fix a few wxWidgets minor asserts. Fix also a missing bitmap button initialization.
...
Fixes: lp:1783703
https://bugs.launchpad.net/kicad/+bug/1783703
2018-08-02 13:22:11 +02:00
Jeff Young
d8d4f75fa1
Fix button order and genralize Exit dialog so it can be shared more.
...
This also fixes a bunch of bugs where an error during save would
still close the window (rather than cancelling the close action).
Fixes: lp:1785034
* https://bugs.launchpad.net/kicad/+bug/1785034
2018-08-02 11:01:03 +01:00
Maciej Suminski
53236a3838
Removed redundant 'v' in noise simulation command
...
Fixes: lp:1784282
* https://bugs.launchpad.net/kicad/+bug/1784282
2018-08-01 17:28:55 +02:00
Jeff Young
196bdc05db
Delete empty fields from Symbol Fields editor.
...
Fixes: lp:1784718
* https://bugs.launchpad.net/kicad/+bug/1784718
2018-08-01 09:35:46 +01:00
Jeff Young
97f7bd4cb9
Push component tree down into common.
...
Precondition to reusing component tree for footprints.
2018-08-01 09:35:45 +01:00
Wayne Stambaugh
61b68e2476
Eeschema: fix print dialog button sizer layout issue.
2018-07-31 10:34:30 -04:00
jean-pierre charras
e750382e75
Fix a few wxWidgets minor asserts
2018-07-29 17:27:11 +02:00
jean-pierre charras
f5e23e4f1a
Fix a few wxWidgets minor asserts
2018-07-29 12:54:36 +02:00
Jeff Young
421204ae80
Improve Reset to Defaults button lable.
...
Also updates action buttons to a sdbSizer so the order is correct
on OSX.
Fixes: lp:1783584
* https://bugs.launchpad.net/kicad/+bug/1783584
2018-07-27 14:58:19 +01:00
Jeff Young
3c2c5c38ad
Make icon buttons slightly wider for MSW.
...
Fixes: lp:1783703
* https://bugs.launchpad.net/kicad/+bug/1783703
2018-07-27 14:58:19 +01:00
Jeff Young
cd3d4b106a
Add event.Skip() call so someone else handles the focus.
...
DIALOG_EDIT_ONE_FIELD::OnSetFocusText() is only for setting the
selection correctly, not doing the actual focus.
Fixes: lp:1783615
* https://bugs.launchpad.net/kicad/+bug/1783615
2018-07-26 15:43:53 +01:00
Jeff Young
cb61525394
Handle separate parsing rules for ID_SCH and ID_PCB.
...
This removes the existing constructors so that all parsing must
be explicit and callers are made aware that they need to think
about illegal characters, malformed ids, etc.
Fixes: lp:1783474
* https://bugs.launchpad.net/kicad/+bug/1783474
2018-07-26 15:43:53 +01:00
Jeff Young
b5634b1d08
Dialog spacing cleanup.
2018-07-26 15:43:53 +01:00
jean-pierre charras
f13a546c9b
Fix a few wxWidgets asserts or alerts.
2018-07-25 20:26:55 +02:00
Jeff Young
05b2060e12
Replace missing growable-row spec.
...
Fixes: lp:1783545
* https://bugs.launchpad.net/kicad/+bug/1783545
2018-07-25 14:41:20 +01:00
Jeff Young
83a56263d0
Strip returns, tabs and linefeeds from SCH fields.
...
Fixes: lp:1783285
* https://bugs.launchpad.net/kicad/+bug/1783285
2018-07-24 16:41:19 +01:00
Jeff Young
4d3aeb3339
Make sure cur_lib_table is initialized.
...
The panel doesn't get Show() events so do it in the constructor.
2018-07-23 23:50:13 +01:00
jean-pierre charras
306729f3b7
DIALOG_ANNOTATE: fix a minor cosmetic issue, and make translation of 2 texts more easy.
2018-07-23 15:48:28 +02:00
Jeff Young
9ca9225977
Add elipsis to Page Setup button.
2018-07-22 23:39:18 +01:00
Jeff Young
2a9856ba34
Refresh eeschema print dialog.
...
Use standard button layout and remove extraneous heading.
Move to TransferDataTo/FromWindow.
Close dialog after printing.
Fixes: lp:1763319
* https://bugs.launchpad.net/kicad/+bug/1763319
2018-07-22 23:29:07 +01:00
Jeff Young
7f64f41242
Fix layout issues in Global Label dialog.
...
Fixes: lp:1782904
* https://bugs.launchpad.net/kicad/+bug/1782904
2018-07-22 16:21:51 +01:00
Jeff Young
07a665f4fd
Improve validation of symbol fields editor.
...
Don't beep when inserting character from focused grid cell (but
before editor is opened).
Handle reference validation separately from name validation and
separately from user field value validation. The old way of setting
the fieldId on the validator wasn't working because the validator
gets copied.
Run validation when leaving cell. Don't just check for empty
(particularly for fields that CAN be empty).
Fixes: lp:1782917
* https://bugs.launchpad.net/kicad/+bug/1782917
(cherry picked from commit 79e04de)
2018-07-21 21:28:13 +01:00
Jeff Young
b6934bf547
Remove duplicate labels from global label popup.
...
Fixes: lp:1782895
* https://bugs.launchpad.net/kicad/+bug/1782895
2018-07-21 14:51:35 +01:00
Jeff Young
6d2dfbb5c3
Add Select Footprint and Show Datasheet to Symbol Fields Editor.
...
Fixes: lp:1782848
* https://bugs.launchpad.net/kicad/+bug/1782848
2018-07-20 23:27:50 +01:00
Jeff Young
c1df78d531
Finish project frame library table editing.
...
Fixes: lp:1782761
* https://bugs.launchpad.net/kicad/+bug/1782761
2018-07-20 18:48:06 +01:00
Jeff Young
bd90341e91
Add Footprint & Datasheet buttons to Edit Symbol dialog.
2018-07-20 18:48:06 +01:00
Baranovskiy Konstantin
c08ef3e8f9
Fix untranslatable label.
...
Column label "Qty" of the symbol fields editor is translatable now.
(cherry picked from commit e7b9b0e)
2018-07-19 23:09:41 +01:00
Jeff Young
ba0c823673
Fix flicking issues on non-double-buffered platforms.
2018-07-19 21:46:41 +01:00
Jeff Young
3a67300001
Fix reference text smart selection for Windows and Linux.
...
Fixes: lp:1782382
* https://bugs.launchpad.net/kicad/+bug/1782382
2018-07-19 21:46:41 +01:00
Jeff Young
829ba27206
Another round of dialog spacing/font adjustments for Windows.
2018-07-18 17:59:05 +01:00
Jeff Young
879ffa4d1c
Adjust dialog spacing for Windows.
2018-07-17 22:18:27 +01:00
Jeff Young
977f27f3c4
Adjust spacing on preference panels.
...
Giving them the correct parent changed the spacing.
(cherry picked from commit 7f602f3)
(cherry picked from commit 718db46)
2018-07-17 15:14:25 +01:00
Jeff Young
68e7a49b53
Add position to Eeschema's edit text dialogs.
...
Fixes: lp:1627467
* https://bugs.launchpad.net/kicad/+bug/1627467
(cherry picked from commit 07c7828)
2018-07-17 15:13:41 +01:00
Jeff Young
1bca706115
Move search status messages to Find/Replace dialog.
...
Fixes: lp:1777699
* https://bugs.launchpad.net/kicad/+bug/1777699
(cherry picked from commit 1ae8a2b)
2018-07-17 15:13:37 +01:00
Jeff Young
7c3a67191b
Freshen the BOM dialog.
...
Layout freshened to include standard button layout.
Fall-behind Add Plugin dialog also fixed.
(cherry picked from commit 30dac89)
2018-07-17 15:13:22 +01:00
Jeff Young
420c2020fb
Overhaul Symbol Library References dialog.
...
Fixes some layout issues and standardizes the action buttons.
Also works around a wxWidgets bug in row sizing.
(cherry picked from commit 7abc922)
2018-07-17 15:12:58 +01:00
Jeff Young
f72842405a
Add existing label popup to properties dialog.
...
Fixes: lp:1639719
* https://bugs.launchpad.net/kicad/+bug/1639719
Fixes: lp:1778330
* https://bugs.launchpad.net/kicad/+bug/1778330
(cherry picked from commit 14ebff6)
2018-07-17 15:12:45 +01:00
Jeff Young
5db4a85430
Fix Update Fields to use alias values.
...
Fixes: lp:1778826
* https://bugs.launchpad.net/kicad/+bug/1778826
(cherry picked from commit 1de2a80)
2018-07-17 15:12:41 +01:00
Jeff Young
d5e88f574f
Clean up units infrastructure after g_UserUnit removal.
...
Fixes: lp:1538239
* https://bugs.launchpad.net/kicad/+bug/1538239
(cherry picked from commit 96d7178)
2018-07-17 15:12:36 +01:00
Jeff Young
5f3ee1e7ce
More g_UserUnit erradication.
...
(cherry picked from commit 3f08780)
2018-07-17 15:12:31 +01:00
Jeff Young
0358aee89e
UNIT_BINDERize print and plot dialogs.
...
Fixes: lp:1778560
* https://bugs.launchpad.net/kicad/+bug/1778560
Fixes: lp:1392991
* https://bugs.launchpad.net/kicad/+bug/1392991
Fixes: lp:1780362
* https://bugs.launchpad.net/kicad/+bug/1780362
(cherry picked from commit 9df9743)
2018-07-17 15:12:29 +01:00
Jeff Young
ef3e045a9b
Eradicate g_UserUnit from ERC/DRC.
...
(cherry picked from commit 98b8cd4)
2018-07-17 15:12:16 +01:00
Jeff Young
3e062867de
Move all the grid workarounds into our own WX_GRID class.
...
(cherry picked from commit 08b4463)
2018-07-17 15:11:38 +01:00
Jeff Young
06bf958bf1
UNIT_BINDERize eeschema's plot and text edit dialogs.
...
(cherry picked from commit 298ea70)
2018-07-17 15:11:26 +01:00
Jeff Young
e4d9366fe4
UNIT_BINDERize Pin Properties dialog.
...
(cherry picked from commit c609087)
2018-07-17 15:11:24 +01:00
Jeff Young
52271d3195
Add an Add Field button to global Field Editor.
...
Fixes: lp:1747602
* https://bugs.launchpad.net/kicad/+bug/1747602
(cherry picked from commit 1e5b1b0)
2018-07-17 15:11:22 +01:00
Jeff Young
7841f8a466
Unified preferences dialog framework.
...
(cherry picked from commit 8ee3e77)
2018-07-17 15:11:17 +01:00
Jeff Young
99fb938b8f
Add updating of visiblity, position, etc. to fields.
...
Fixes: lp:1752752
* https://bugs.launchpad.net/kicad/+bug/1752752
Fixes: lp:1643890
* https://bugs.launchpad.net/kicad/+bug/1643890
(cherry picked from commit 9f60005)
2018-07-17 15:10:50 +01:00
Jeff Young
23189f8e1b
Move annotation confirmation dialogs to KIDIALOG.
...
(cherry picked from commit 05e04e8)
2018-07-17 15:10:45 +01:00
Jeff Young
31aebe6920
UI infrastructure enhancements and bug fixes.
...
Work around wxWidgets failure to send first key through validator.
Unify treatment of INDETERMINATE values (such as for multiple
selections with mixed values).
(cherry picked from commit 7308729)
2018-07-17 15:10:15 +01:00
Jeff Young
c8b02674dc
Direct editing of LIB_FIELDs and SCH_FIELDs in dialogs.
...
Fixes: lp:1676178
* https://bugs.launchpad.net/kicad/+bug/1676178
Fixes: lp:1749220
* https://bugs.launchpad.net/kicad/+bug/1749220
Fixes: lp:1779557
* https://bugs.launchpad.net/kicad/+bug/1779557
Fixes: lp:1425134
* https://bugs.launchpad.net/kicad/+bug/1425134
Fixes: lp:1565195
* https://bugs.launchpad.net/kicad/+bug/1565195
(cherry picked from commit b6aee79)
2018-07-17 15:10:08 +01:00
Jeff Young
bcd9a7745d
Make the pin table editable.
...
Also adds generic icon + text grid renderer and grid editor.
Fixes: lp:1521055
* https://bugs.launchpad.net/kicad/+bug/1521055
Fixes: lp:1528817
* https://bugs.launchpad.net/kicad/+bug/1528817
(cherry picked from commit 067f777)
2018-07-17 15:10:06 +01:00
Jeff Young
7be85deb32
GRID_TRICKS improvements.
...
Allow copy of a single cell demarcated by the grid cursor.
Paste of lib_table s-expressions should always start at 0,0.
Let caller or specialized sub-class do auto-sizing; don’t
do it from within the base GRID_TRICKS.
Don’t start GRID_TRICKS menu IDs at -1; wxWidgets doesn’t
like it when you get to 0.
Add column visibility menu.
(cherry picked from commit e5071ed)
2018-07-17 15:10:03 +01:00
Jeff Young
0f78f97232
Get rid of 5.0 dialog focus hacks.
...
It's time to fix the focus issues. This adds a new SetInitialFocus()
routine to DIALOG_SHIM which will need to be called from a lot of
dialogs.
(cherry picked from commit 6d9647a)
2018-07-17 15:09:58 +01:00
Jeff Young
a39fb03822
Remove some references to g_UserUnit
...
(cherry picked from commit 614d832)
2018-07-17 15:09:56 +01:00
Jeff Young
74acb76e7f
Switch UNIT_BINDER and DIALOG_SHIM to local units.
...
The general idea is to support user-units inheritance. The
UNIT_BINDER allows wrapped controls to inherit units from their
parent dialog, while KEYWAY_HOLDER and DIALOG_SHIM allow child
KEYWAY_HOLDERs or DIALOG_SHIMs to inherit units from their
parent.
The GetUserUnits() method signature has to move to KEYWAY_HOLDER
rather than KEYWAY_PLAYER (where it makes more sense) as it’s the
only common ancestor of KEYWAY_PLAYER and DIALOG_SHIM.
As long as we'll be using the UNIT_BINDER more widely, it also
makes sense to move evaluation and validation into it.
This commit also provides eeschema’s DIALOG_LABEL_EDITOR and
pcbnew’s DIALOG_TRACK_VIA_PROPERTIES and DIALOG_SET_GRID as
models of how to use the new user-units inheritance, eval, and
validation.
Fixes: lp:593795
* https://bugs.launchpad.net/kicad/+bug/593795
(cherry picked from commit c8bc53e)
2018-07-17 15:09:53 +01:00
Jeff Young
e9d877914d
Dialog consistency and beautification.
...
Small icons for dialog browse, refresh, and row operations.
Icons in B&W so they don't over-emphasize with respect to other
controls in the dialog.
Layout cleanup for consistency. Removal of the blank space to
left of the fields list in the Global Fields Editor, and addition
of column-sizing-to-list-width.
More even spacing for buttons in html report panel.
Honor platform conventions for action button order and layout.
Move netlist importer to update-pcb-from-schematic algorithm
(display messages and then update instead of "dry run" checkbox)
(cherry picked from commit b21e19d)
2018-07-17 15:09:01 +01:00
Jeff Young
01c5bdfb8f
Fix bug with duplicate columns in Edit Symbol Fields.
2018-07-16 09:03:27 +01:00
Maciej Suminski
14ce518208
Speed-up Spice model library loading
...
Thanks to Jeff Wheeler for determining the slow down cause.
Fixes: lp:1779566
* https://bugs.launchpad.net/kicad/+bug/1779566
2018-07-10 20:55:37 +02:00
jean-pierre charras
3df27430c7
Fix eeschema crash when updating fields from libraries, and when a symbol in schematic is not found in libs
...
Fixes: lp:1779722
https://bugs.launchpad.net/kicad/+bug/1779722
2018-07-02 21:02:27 +02:00
Maciej Suminski
47c44b4d83
Unselect 'copy default sym-lib-table' when unavailable
...
It used to be selected as the primary choice even though the option was
disabled.
2018-06-29 09:19:41 +02:00
jean-pierre charras
f785d27498
Eeschema, label editor dialog: fix a very minor cosmetic issue when resizing the dialog.
2018-06-23 17:53:29 +02:00
Wayne Stambaugh
8394e2b71e
Fix broken LIB_ID library nickname illegal character tests.
...
During the symbol library table implementation, the legal character
tests for the footprint library table were changed and the forward
slash '/' character became illegal. This change broke editing some
users footprint library tables that already had '/' in library table
nicknames. This change split the library nickname and library item
name illegal character tests.
2018-06-20 14:36:40 -04:00
jean-pierre charras
5411b951ae
Minor compil warning (signed/unsigned compare) fix
2018-06-13 08:05:10 +02:00
Jeff Young
660aed71b4
Make sure initially loaded footprint is rendered.
...
Also sets the initial footprint to the current footprint when
doing a Choose Footprint from the Eeschema Edit Property
dialog.
Fixes: lp:1776126
* https://bugs.launchpad.net/kicad/+bug/1776126
2018-06-12 13:41:53 +01:00
Seth Hillbrand
4186626069
Fix overzealous checking in 2798035f8
...
Checking for NULL fields prevents a useful dialog from being displayed
now that the exception is handled.
2018-06-11 20:49:13 -07:00
Seth Hillbrand
2798035f85
eeschema: Catch parameter errors in SPICE sim
...
Any errors in the dialog should be handled and, at worst, allowed to
redo. SPICE_VALUE throws KI_PARAM_ERROR, so we catch that explicitly.
Fixes: lp:1776051
* https://bugs.launchpad.net/kicad/+bug/1776051
2018-06-11 18:02:20 -07:00
Jeff Young
5c65881fde
Allow Global Fields Editor to Cancel with no changes.
2018-06-11 12:10:19 +01:00
Ben Gamari
da61285a29
field editor: Save checkbox states
...
This refactors the symbol field editor's checkbox state-saving code to
deal with multiple projects with disjoint field sets more consistently.
For instance, imagine I have a two projects
* Proj1 has fields A, B, C
* Proj2 has fields A, B, D
Under the old scheme, when I switch from one project to the other the
state of fields C and D will be forgotten. With the new approach,
however, they are retained.
Not to mention, the implementation is considerably simpler. Fixes
2018-06-11 12:08:59 +01:00
Ben Gamari
3f783d2318
field editor: Find components when reference field is clicked
...
This makes it significantly easier to find a particular component when
using the field editor, as I often do for part selection.
Fixes: lp:1772169
* https://bugs.launchpad.net/kicad/+bug/1772169
2018-06-11 10:27:49 +02:00
Jeff Young
b9874da3a6
Remove background fp loading from Choose Symbol dlg.
...
There are a bunch of problems with event processing and closing
documents, etc., when enabled. See the bug report for more
info.
Fixes: lp:1774777
* https://bugs.launchpad.net/kicad/+bug/1774777
2018-06-09 00:51:39 +01:00
Seth Hillbrand
a5c213c23d
Set footprint splitter window canvas to transient
...
The splitter window can not be the parent to any additional windows.
If it acquires a child that persists past the lifetime of the splitter
window, we get a segfault.
2018-06-06 10:03:00 -07:00
Damien Espitallier
5263558eaa
Fix crash when delete button of footprint filter is clicked and no footprint is selected
...
Fixes: lp:1775296
* https://bugs.launchpad.net/kicad/+bug/1775296
2018-06-06 00:01:47 +01:00
Jeff Young
aaf47bbe71
Replace "unsaved changes" dialog to Global Fields Editor.
2018-06-06 00:01:47 +01:00
Wayne Stambaugh
7343e78347
Fix some Coverity uninitialized field warnings.
...
Fixes Coverity CIDs:
- 175824
- 169337
- 163191
- 175827
- 175440
- 175438
- 157136
2018-06-04 13:48:57 -04:00
Jeff Young
d03e92a3a2
Field Name Template (aka Default Fields) fixes.
...
Move from a "default" fields model to a "seed" fields model. See
discussion on devlist:
https://lists.launchpad.net/kicad-developers/msg35823.html .
2018-05-30 09:46:52 +01:00
Maciej Suminski
8c63dac0c3
Component Chooser: do not create FP list when the FP preview is disabled
2018-05-30 09:53:58 +02:00
Marco Ciampa
2cb65f9c19
Make the Simulator error strings translatable
2018-05-28 14:51:10 +02:00
Jeff Young
8f5cb32598
Don't write empty fields from Global Edit Fields dialog.
2018-05-23 21:35:23 +01:00
jean-pierre charras
3893c43eb0
Fix compil issues.
2018-05-23 11:31:13 +02:00
Seth Hillbrand
8c5037a48b
Optionally sort reporter messages
...
It can be useful to have similar class messages grouped together so that
error messages in a larger report don't get lost among the
warning/info/action messages.
This patch allows sorting of messages for dialogs that benefit from
organization. Default behavior of reporter messages remains
unchanged by this patch.
Fixes: lp:1772090
* https://bugs.launchpad.net/kicad/+bug/1772090
2018-05-22 13:55:02 -07:00
Jeff Young
c4b447f3f9
Initialize field visibility checkboxes in Fields Editor.
2018-05-22 19:24:37 +01:00
Jeff Young
e3c4a96f5c
Default field bug fixes.
...
1) Commit in-progress edits before closing preferences.
2) Handle default fields in Symbol Fields Editor.
3) Save state of checkboxes in Symbol Fields Editor.
2018-05-22 12:55:39 +01:00
Seth Hillbrand
d62b4f36a6
Save hotkeys to combined app-based file
...
Unifies the different sections of hotkeys so that we are not storing two
[eeschema] or [pcbnew] sections in two different files.
Previous hotkey definitions are loaded at start if they exist but are
overwritten by the new format, if it exists. Changes to hotkeys save
only in the combined format.
Hotkey editor for each application only shows the hotkeys relevant to
that application.
Fixes: lp:1741757
* https://bugs.launchpad.net/kicad/+bug/1741757
Fixes: lp:1668799
* https://bugs.launchpad.net/kicad/+bug/1668799
2018-05-18 12:57:38 -07:00
Jeff Young
df495b1d65
Fix typo in loading of preferences Reference ID Notation menu.
...
Fixes: lp:1771898
* https://bugs.launchpad.net/kicad/+bug/1771898
2018-05-17 23:46:32 +01:00
jean-pierre charras
afc28ef5db
fix a minor compil warning
2018-05-16 18:14:06 +02:00
Jeff Young
1a6e8d4713
Fix typo.
2018-05-13 21:48:13 +01:00
Jeff Young
c30dd24cc1
Fixup sorting for expanded component groups.
...
Also adds shorthand notation for groups with adjacent components.
2018-05-13 12:21:55 +01:00
jean-pierre charras
54766bac40
fix minor compil warning (signed/unsigned compar)
2018-05-13 08:56:17 +02:00
Jeff Young
9311393016
Add expand/collapse to grouped rows in Fields Editor.
...
Fixes: lp:1767746
* https://bugs.launchpad.net/kicad/+bug/1767746
2018-05-12 23:05:04 +01:00
Jeff Young
e91e88bfa1
Make sure read-only attr sticks when grid table rebuilt.
2018-05-11 12:33:53 +01:00
Jeff Young
6e83f99c72
Relax fully-annotated constraint for BOM editor.
...
Also fixes a bug where unannotated components would get references
of the form R-1 (because their reference number was -1).
Fixes: lp:1768814
* https://bugs.launchpad.net/kicad/+bug/1768814
2018-05-11 12:33:44 +01:00
Jeff Young
aa7da5dfcd
Treat ${...} and $(...) envvar references uniformly.
...
Fixes: lp:1769282
* https://bugs.launchpad.net/kicad/+bug/1769282
2018-05-05 23:40:40 +01:00
Jeff Young
c23b263e39
Fix display issues in Layers list in Keepout Zone Properties.
2018-05-04 23:55:03 +01:00