jean-pierre charras
1ca3b2c768
Eeschema: DIALOG_FIELDS_EDITOR_GLOBAL: fix missing clearing old highlight when highlighting a new symbol or exiting the dialog
2019-01-09 14:38:44 +01:00
jean-pierre charras
f7cf40f2f4
Fix a few Coverity warnings.
...
Sometimes a dynamic_cast was used without testing the returned value.
Some are replaced by static_cast, when the dynamic_cast was useless.
2018-11-11 08:28:58 +01:00
Jeff Young
8a54b1b3b7
Add view refresh calls for edit operations.
...
Note that the bug referenced in the "fixes" section is only one
of many addressed by this commit.
Fixes: lp:1798449
* https://bugs.launchpad.net/kicad/+bug/1798449
2018-10-18 12:12:48 +01:00
Jeff Young
779ef044b7
Fix wxGrid column dragging bugs.
...
Close an open editor when dragging (as wxWidgets won't move it).
Make sure native column headers aren't in use where we need dragging:
their interaction with wxWidgets' dragging is buggy.
Fixes: lp:1796398
* https://bugs.launchpad.net/kicad/+bug/1796398
Fixes: lp:1796396
* https://bugs.launchpad.net/kicad/+bug/1796396
2018-10-09 21:33:43 +01:00
Jeff Young
90df7a8b22
Sort references before removing duplicates.
...
std::unique only works within consecutive blocks, so the list must
be sorted first. (We need it sorted in the end anyway, so no
big deal.)
2018-10-08 00:14:07 +01:00
Jeff Young
8015334683
Don't resize hidden columns.
...
wxGrid columns are hidden by setting their width to 0. Resizing
them will "unhide" them.
Fixes: lp:1796150
* https://bugs.launchpad.net/kicad/+bug/1796150
2018-10-05 14:17:58 +01:00
Jeff Young
3c2aafd7b7
Move Edit Symbol References to standard text/button control.
2018-09-29 22:07:31 +01:00
jean-pierre charras
094f340359
Eeschema: Opening "Edit Symbol Fields" dialog crashes Eeschema
...
Fixes: lp:1795088
https://bugs.launchpad.net/kicad/+bug/1795088
2018-09-29 10:08:29 +02:00
Jeff Young
6fdfd0932e
Use newer wxWidgets calls (old ones aren't available on MSW).
2018-09-27 18:53:46 +01:00
Jeff Young
e456ecd0a1
Calculate column widths based on all data, not just shown data.
...
Also caps the calculated width at 1/3 of the default dialog width.
Fixes: lp:1794625
* https://bugs.launchpad.net/kicad/+bug/1794625
2018-09-27 16:57:25 +01:00
Jeff Young
a9c8a7b69c
Remove unused warp mouse parameter.
2018-08-29 19:59:02 +01:00
Jeff Young
b90a261d5c
More safety fixes for uncommitted grid changes.
2018-08-29 19:59:01 +01:00
Jeff Young
4b1a31ffad
Regularize save-changes dialogs.
2018-08-12 00:02:37 +01:00
Jeff Young
d8d4f75fa1
Fix button order and genralize Exit dialog so it can be shared more.
...
This also fixes a bunch of bugs where an error during save would
still close the window (rather than cancelling the close action).
Fixes: lp:1785034
* https://bugs.launchpad.net/kicad/+bug/1785034
2018-08-02 11:01:03 +01:00
Jeff Young
196bdc05db
Delete empty fields from Symbol Fields editor.
...
Fixes: lp:1784718
* https://bugs.launchpad.net/kicad/+bug/1784718
2018-08-01 09:35:46 +01:00
Jeff Young
83a56263d0
Strip returns, tabs and linefeeds from SCH fields.
...
Fixes: lp:1783285
* https://bugs.launchpad.net/kicad/+bug/1783285
2018-07-24 16:41:19 +01:00
Jeff Young
6d2dfbb5c3
Add Select Footprint and Show Datasheet to Symbol Fields Editor.
...
Fixes: lp:1782848
* https://bugs.launchpad.net/kicad/+bug/1782848
2018-07-20 23:27:50 +01:00
Baranovskiy Konstantin
c08ef3e8f9
Fix untranslatable label.
...
Column label "Qty" of the symbol fields editor is translatable now.
(cherry picked from commit e7b9b0e)
2018-07-19 23:09:41 +01:00
Jeff Young
52271d3195
Add an Add Field button to global Field Editor.
...
Fixes: lp:1747602
* https://bugs.launchpad.net/kicad/+bug/1747602
(cherry picked from commit 1e5b1b0)
2018-07-17 15:11:22 +01:00
Jeff Young
31aebe6920
UI infrastructure enhancements and bug fixes.
...
Work around wxWidgets failure to send first key through validator.
Unify treatment of INDETERMINATE values (such as for multiple
selections with mixed values).
(cherry picked from commit 7308729)
2018-07-17 15:10:15 +01:00
Jeff Young
7be85deb32
GRID_TRICKS improvements.
...
Allow copy of a single cell demarcated by the grid cursor.
Paste of lib_table s-expressions should always start at 0,0.
Let caller or specialized sub-class do auto-sizing; don’t
do it from within the base GRID_TRICKS.
Don’t start GRID_TRICKS menu IDs at -1; wxWidgets doesn’t
like it when you get to 0.
Add column visibility menu.
(cherry picked from commit e5071ed)
2018-07-17 15:10:03 +01:00
Jeff Young
0f78f97232
Get rid of 5.0 dialog focus hacks.
...
It's time to fix the focus issues. This adds a new SetInitialFocus()
routine to DIALOG_SHIM which will need to be called from a lot of
dialogs.
(cherry picked from commit 6d9647a)
2018-07-17 15:09:58 +01:00
Jeff Young
01c5bdfb8f
Fix bug with duplicate columns in Edit Symbol Fields.
2018-07-16 09:03:27 +01:00
jean-pierre charras
5411b951ae
Minor compil warning (signed/unsigned compare) fix
2018-06-13 08:05:10 +02:00
Jeff Young
5c65881fde
Allow Global Fields Editor to Cancel with no changes.
2018-06-11 12:10:19 +01:00
Ben Gamari
da61285a29
field editor: Save checkbox states
...
This refactors the symbol field editor's checkbox state-saving code to
deal with multiple projects with disjoint field sets more consistently.
For instance, imagine I have a two projects
* Proj1 has fields A, B, C
* Proj2 has fields A, B, D
Under the old scheme, when I switch from one project to the other the
state of fields C and D will be forgotten. With the new approach,
however, they are retained.
Not to mention, the implementation is considerably simpler. Fixes
2018-06-11 12:08:59 +01:00
Ben Gamari
3f783d2318
field editor: Find components when reference field is clicked
...
This makes it significantly easier to find a particular component when
using the field editor, as I often do for part selection.
Fixes: lp:1772169
* https://bugs.launchpad.net/kicad/+bug/1772169
2018-06-11 10:27:49 +02:00
Jeff Young
aaf47bbe71
Replace "unsaved changes" dialog to Global Fields Editor.
2018-06-06 00:01:47 +01:00
Wayne Stambaugh
7343e78347
Fix some Coverity uninitialized field warnings.
...
Fixes Coverity CIDs:
- 175824
- 169337
- 163191
- 175827
- 175440
- 175438
- 157136
2018-06-04 13:48:57 -04:00
Jeff Young
d03e92a3a2
Field Name Template (aka Default Fields) fixes.
...
Move from a "default" fields model to a "seed" fields model. See
discussion on devlist:
https://lists.launchpad.net/kicad-developers/msg35823.html .
2018-05-30 09:46:52 +01:00
Jeff Young
8f5cb32598
Don't write empty fields from Global Edit Fields dialog.
2018-05-23 21:35:23 +01:00
jean-pierre charras
3893c43eb0
Fix compil issues.
2018-05-23 11:31:13 +02:00
Jeff Young
c4b447f3f9
Initialize field visibility checkboxes in Fields Editor.
2018-05-22 19:24:37 +01:00
Jeff Young
e3c4a96f5c
Default field bug fixes.
...
1) Commit in-progress edits before closing preferences.
2) Handle default fields in Symbol Fields Editor.
3) Save state of checkboxes in Symbol Fields Editor.
2018-05-22 12:55:39 +01:00
jean-pierre charras
afc28ef5db
fix a minor compil warning
2018-05-16 18:14:06 +02:00
Jeff Young
1a6e8d4713
Fix typo.
2018-05-13 21:48:13 +01:00
Jeff Young
c30dd24cc1
Fixup sorting for expanded component groups.
...
Also adds shorthand notation for groups with adjacent components.
2018-05-13 12:21:55 +01:00
jean-pierre charras
54766bac40
fix minor compil warning (signed/unsigned compar)
2018-05-13 08:56:17 +02:00
Jeff Young
9311393016
Add expand/collapse to grouped rows in Fields Editor.
...
Fixes: lp:1767746
* https://bugs.launchpad.net/kicad/+bug/1767746
2018-05-12 23:05:04 +01:00
Jeff Young
e91e88bfa1
Make sure read-only attr sticks when grid table rebuilt.
2018-05-11 12:33:53 +01:00
Jeff Young
6e83f99c72
Relax fully-annotated constraint for BOM editor.
...
Also fixes a bug where unannotated components would get references
of the form R-1 (because their reference number was -1).
Fixes: lp:1768814
* https://bugs.launchpad.net/kicad/+bug/1768814
2018-05-11 12:33:44 +01:00
Jeff Young
c23b263e39
Fix display issues in Layers list in Keepout Zone Properties.
2018-05-04 23:55:03 +01:00
jean-pierre charras
b636aaddf6
Eeschema: fix incorrect UI messages in dialogs due to using UTF8 strings instead of wxStrings (unicode) to build them.
...
(Added a explicit to build a Unicode string in UI messages to avoid mistakes)
2018-04-30 11:46:23 +02:00
Jeff Young
6ccc8577ad
Hand-code calculation of field names column width.
...
Fixes: lp:1737361
* https://bugs.launchpad.net/kicad/+bug/1737361
2018-04-26 19:13:19 +01:00
Jeff Young
888c434776
Treat Mac as special case rather than GTK.
...
(Windows also needs the padding we use for GTK.)
2018-04-26 15:51:34 +01:00
Jeff Young
dcf02f5f67
Use a single calc-column-width-impl for Fields Editor.
...
Also adds calculation of the initial splitter position based on
the widths of the fields in the list.
Fixes: lp:1737361
* https://bugs.launchpad.net/kicad/+bug/1737361
2018-04-26 11:10:58 +01:00
jean-pierre charras
528a67b27c
Fix incorrect sizing of 2 columns in dialog, on GTK (issue perhaps depending on GTK/wxWidget version)
2018-04-25 12:07:43 +02:00
Jeff Young
7e29ff0bc4
Conditional compilation for global fields editor listbox.
2018-04-24 23:45:44 +01:00
Jeff Young
aa71d41a59
Calculate column widths based on actual text & fontsize.
...
Fixes: lp:1737361
* https://bugs.launchpad.net/kicad/+bug/1737361
2018-04-23 18:24:10 +01:00
Jeff Young
5506efaee5
Add a SaveAndContinue button to the Fields Editor.
2018-04-19 23:13:19 +01:00
Jeff Young
b9239d8728
Add defensive coding for column widths in Fields Editor.
2018-04-19 21:39:25 +01:00
Jeff Young
9201417c06
Handle new fields in global field editor.
...
Fixes: lp:1765443
* https://bugs.launchpad.net/kicad/+bug/1765443
2018-04-19 20:33:03 +01:00
Jeff Young
442d1169a8
Adjust min sizes of Global Fields editor for Windows.
...
Also gets rid of a slew of unnecessary sizers in the dialog.
2018-04-18 20:37:20 +01:00
Jeff Young
db2cda7271
Fix some merge issues.
2018-04-17 20:26:50 +01:00
jean-pierre charras
854cb70052
Fix compil issue with gcc 4.8 on Ubuntu
2018-04-17 19:35:26 +02:00
jean-pierre charras
0294e41cbc
fix minor compil warnings (about signed/unsigned comparison)
2018-04-17 16:08:12 +02:00
Jeff Young
000457db7c
Move Fields Editor to wxGrid.
...
Makes in-place editing much easier and fixes some other issues
(see bug reports).
Fixed sorting bugs in References and added better sorting for
Values.
Removed Description column as it wasn't editable and caused more
confusion than value.
Removed auto-column-width after initial render.
Re-implemented undo/redo.
Fixes: lp:1749287
* https://bugs.launchpad.net/kicad/+bug/1749287
Fixes: lp:1737361
* https://bugs.launchpad.net/kicad/+bug/1737361
Fixes: lp:1759756
* https://bugs.launchpad.net/kicad/+bug/1759756
Fixes: lp:1763223
* https://bugs.launchpad.net/kicad/+bug/1763223
Fixes: lp:1761378
* https://bugs.launchpad.net/kicad/+bug/1761378
2018-04-17 11:39:44 +01:00
hauptmech
eeeed88425
Use fixed width on first Symbol Table column
...
Autosize when the reference field is a list of all components was too long.
Fixes: lp:1753330
* https://bugs.launchpad.net/kicad/+bug/1753330
2018-03-08 20:59:46 -05:00
jean-pierre charras
dba198e576
Fix code after renaming files
...
Change class names according to the new name of the main dialog
2018-02-09 17:36:54 +01:00
jean-pierre charras
35a0688bf7
rename dialog_bom_editor* files to dialog_fields_editor_global*
...
rename also associated files
2018-02-09 17:36:52 +01:00