This fixes https://gitlab.com/kicad/code/kicad/-/issues/9944 and reverts
caf406943e. The original fix caused issues
with some CMake versions because it tried to give library dependencies
to an object library, which can't have any library dependencies.
Instead, we need it as a static library, and since there is no need to
actually have it as an end-user library, it shouldn't be in the install
command.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9944
(Cherry-picked from commit fb36e1b582)
Error messsage was:
"CMake Error at utils/kicad2step/CMakeLists.txt:68 (install):
install TARGETS given no ARCHIVE DESTINATION for static library target"
Perhaps cmake version (3.10.2 on bionic) need that since on ubuntu focal (20.04) there is no error (cmake is 3.16.3 on focal). As I see cmake 3.14 add an autodetection mecanism to find the destinations.
The Boost::boost style library dependencies don't work
on some CMake versions (couldn't find library -lBoost::boost)
Use ${Boost_INCLUDE_DIRS} in the target_include_dirs() instead.
This adds a test to the recent GetLayerName function, and moves
it to the base.h file for re-use for any code that needs a
layer name.
This test covers the case that caused lp:1824750 [1].
[1]: https://bugs.launchpad.net/kicad/+bug/1824750
The SEXPR class is a useful general-purpose S-Expression library
class and can (maybe) be used else where. It also should get
test coverage, as even if noone else uses it, it's critical for the
kicad2step exporter.
Also add some test coverage for some kicad2step routines. For now,
they're not useful outside kicad2step, but they are at least a useful
reference for S-Expression parsing.
This is not technically correct (the Boost dependency is introduced through
libcommon), but less invasive as it doesn't pull in libcommon on the linker
command line.
The opencascade patch intrusively checked against libraries but broke
some build scripts. This restores the default cmake OCE behavior that was
changed by 2bab30d9a and makes the OpenCascade search truly secondary.
Ian McInerney
jean-pierre charras
Wayne Stambaugh
Jean-Samuel Reynaud
Marek Roszko
Jeff Young
Seth Hillbrand
Simon Richter
John Beard
Seth Hillbrand
Cirilo Bernardo
Simon Wells