haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
37,736 Commits 9 Branches 105 Tags 1.3 GiB
Commit Graph

326 Commits

Author SHA1 Message Date
Wayne Stambaugh 441c2b50b9 Fix potential stale pointer bug in schematic highlight connection code. 
SCH_CONNECTION objects are temporary and can become stale any time the
connectivity is updated.  Keeping them around to reference later is a
bad idea.  Even if the object pointer is still valid in an SCH_ITEM in
the undo/redo buffers, comparing the pointer against another pointer as
a test to see if they are the same connection is not valid.  Saving the
connection name is safe and ensures the connection is the same even if
the pointers differ.

(cherry picked from commit 831a6d55fc)
 2023-05-29 13:55:07 -04:00
Jeff Young c6e4f18d99 Hook up text variable auto-complete for PCBNew. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14777

(cherry picked from commit 14f004d2a5)
 2023-05-28 18:46:39 +01:00
jean-pierre charras 372e7b6312 fix 2 issues related to SCH_GLOBALLABEL items: 
- Ensure the first field in m_fields has id = 0 to be seen has hypertext
(it was not the case after reading a .kicad_sch file)
- when converting this item to another label/text, remove this special Field
from the copied field list to the converted label.
From master branch.
 2023-04-10 10:02:50 +02:00
Jeff Young cbff011e3c Don't delete default intersheetrefs field from global labels. 
Fixes https://gitlab.com/kicad/code/kicad/issues/14493

(cherry picked from commit a226f7fc14)
 2023-04-09 19:04:33 +01:00
Jeff Young a292bf7c83 Don't dirty connectivity when moving non-reference SCH_FIELD. 
(cherry picked from commit 2e9ed67e05)
 2023-02-13 10:54:49 +00:00
Seth Hillbrand 43e4797d4d Don't double-tap Connectivity Recalculate 
SCH_EDIT_FRAME::RecalculateConnections() calls SchematicCleanup and then
resets the connectivity graph and recalculates it.  OnModify() also
calls RecalculateConnections().  For long calculation schematics, this
can impact usability
 2023-01-24 10:30:52 -08:00
Jeff Young f8ef15f174 Fix over-zealous delete. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13476
 2023-01-11 12:16:28 +00:00
Mike Williams 4274bd0bb7 Schematic: handle rotations that include junctions 
Also fix lack of line cleanup on mirroring.

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13436
 2023-01-09 11:05:30 -05:00
jean-pierre charras be5810a1ce EEschema, "Change To" context menu: do not allow converting SCH_SHEET_PINs 
to something else.
SCH_SHEET_PIN are specific, handled by a SHEET, and the conversion to a label
cannot be done.
 2023-01-09 15:30:36 +01:00
Jeff Young 8dc7baad3d Cleanup actions should not activate tools. It causes all manner of side-effects. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13331
 2023-01-06 22:15:20 +00:00
Seth Hillbrand c29dfe026e Force recursing annotation when set to auto 
Automatic annotation should always annotate new elements regardless of
where in the hierarchy they are

Fixes https://gitlab.com/kicad/code/kicad/issues/13378
 2023-01-05 15:03:38 -08:00
Mike Williams f1fab140a1 Schematic: make menu bar rotation items conditional 
Also fix some items not getting a context menu rotate action.
 2022-12-27 14:18:47 -05:00
Wayne Stambaugh 78e2f0fd4d Sheet instance handling improvements. 2022-12-26 08:30:03 -05:00
Mike Williams 8b7d0d71fb Schematic: show update/change symbols for multiple symbol selection 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13231
 2022-12-22 14:00:51 -05:00
Mike Williams fc054bda8e Schematic: fix edit symbol assert 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13197
 2022-12-20 08:23:02 -05:00
Mike Williams 389f0655cd Schematic: re-enable old break wire functionality, add slice 
Also fix break/slice wires for multiple wires. The shortcut and code
always allowed it, the context menu just didn't appear.

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13163
 2022-12-19 15:55:59 -05:00
Wayne Stambaugh 6a0db3e7e2 Fix Coverity warnings. 2022-10-26 14:39:44 -04:00
Wayne Stambaugh 598b09821a Coverity fixes. 2022-10-17 15:30:20 -04:00
Jeff Young f9a791e2b0 Copy font across when changing text type. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12629
 2022-10-12 23:49:40 +01:00
Mike Williams c1da59b560 Swap: disallow swapping tracks / wires 
Also fix missed shortcut change for S -> Shift-S

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/12538
 2022-09-29 17:04:43 -04:00
Jeff Young d0ff90eb6e Support mirroring of multiple SCH_FIELDs at once. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12512
 2022-09-26 17:44:52 +01:00
Jeff Young fc10db25ba Netclass directive and label conversion improvements. 
1) Copy label fields when converting.
2) Don't assume netclass directive should be net name -- this is very
unlikely.
3) Don't show font controls in Netclass Directive Properties dialog --
there's no basic text associated witha  Directive Label.
 2022-09-22 01:22:19 +01:00
Mike Williams 9304607624 TOOL_EVENT: make command string non-optional 
We're getting segfaults in places where this isn't checked. Also, add
some asserts so we can catch bad tool push/pop.

Removes all uses of GetCommandStr() and makes it private.
 2022-09-19 10:23:09 -04:00
Jeff Young e6c8cf0f03 Don't escape spaces in bus groups and transfer hyperlinks. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12451

Fixes https://gitlab.com/kicad/code/kicad/issues/12452
 2022-09-17 20:56:50 +01:00
Marek Roszko 61e11d6896 Strip out Mils2Iu 2022-09-16 21:09:27 -04:00
Jeff Young 907cafef6d Update font size before querying properties dependent on it (like the text margin). 
Fixes https://gitlab.com/kicad/code/kicad/issues/12444
 2022-09-16 18:57:12 +01:00
lulu731 0180bcf90a ADDED: Implement Drag and Drop 
dropping files to Kicad manager :
  *.kicad_pro, *.pro -> open project;
  gerber and job files -> open in Gerbview editor;
  Eagle and Cadstar files -> open project.
dropping file to schematic editor -> append schematic;
dropping library file to Symbol editor -> add library;
dropping board file to PCB editor -> append board;
dropping library or footprint file to Footprint editor -> add library or import footprint;
dropping ZIP file or gerber files to Gerbview editor -> open files;
dropping sheet file to Drawing Sheet editor -> open sheet.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/11638
 2022-09-14 22:28:09 +00:00
Mike Williams 926f979ebc Schematic: Add swap action 2022-09-12 11:11:49 -04:00
Jeff Young b2a29e08a4 Improve repeat-last-item to handle unfold-from-bus. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12018
 2022-09-09 18:09:09 +01:00
Jeff Young c337c12410 Don't double-flip justification. (The transform already flips it.) 
Fixes https://gitlab.com/kicad/code/kicad/issues/11673
 2022-09-06 13:59:52 +01:00
Jeff Young c30a557810 ADDED netclass assignment from PCB canvas. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5975
 2022-09-03 19:29:59 +01:00
Wayne Stambaugh 4c096fee15 Eeschema: fix crash when attempting to edit missing library symbol. 
Disable the edit symbol buttons in the symbol properties dialog when
there is no library symbol to edit.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/11318

(cherry picked from commit 5afeb45a84)
 2022-09-02 16:25:34 -04:00
Jeff Young 0c8787cbb9 Some more wxPoint/EDA_RECT yeeting. 2022-08-31 00:44:33 +01:00
Seth Hillbrand b736460e71 Move optional access from value() to *operator 
`value()` throws.  Where we check for existence, we don't need to use
the throwing version and should just use the unprotected variant
 2022-08-30 13:59:39 -07:00
Seth Hillbrand f1261e71d4 Replace boost::optional with std::optional 2022-08-25 15:50:47 -07:00
Jeff Young 4f0136db3b Attempt to fix std::initializer_list lifetime issue. 2022-08-21 20:54:41 +01:00
Jeff Young b2a2d66005 Move Bus Definitions to common GUI paradigm in Schematic Setup. 
Also includes a change to the std::initializer_list stuff to try and
fix a crash.
 2022-08-21 12:29:51 +01:00
Jeff Young aa2ad3b44c Move KICAD_T[] to std::initializer_list<KICAD_T>. 2022-08-20 10:28:11 +01:00
jean-pierre charras 0604d7b813 Fix minor compil and Coverity warnings. 2022-07-24 09:33:43 +02:00
Jeff Young 9652dcf96d ADDED conversion between textbox and other text types. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12031
 2022-07-22 09:31:07 +01:00
Mike Williams d44e34d513 Images: Add full properties editor 
Converts dialog_image_editor to panel_image_editor. Embeds this panel in
a new properties dialog for the schematic and PCB editors that allows
editing position, layer, locked status, etc. like other items.
 2022-07-14 11:23:23 +00:00
Seth Hillbrand b5bf1da251 Keep track of blocking windows 
Allows the calling KiWAY player to send messages to the blocking window
before signaling a separate call

Fixes https://gitlab.com/kicad/code/kicad/issues/11891

Fixes https://gitlab.com/kicad/code/kicad/issues/11772
 2022-07-13 19:25:24 -07:00
Jeff Young e122dc38bd Add context menu item for clearing net highlighting. 
In selection tools, drawing tools, router tool, line_wire_bus tool.

Fixes https://gitlab.com/kicad/code/kicad/issues/11920
 2022-07-10 17:15:20 -06:00
Jeff Young 70aec5d576 Don't drag both ends after Break Wire. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11915
 2022-07-08 23:03:41 -06:00
jean-pierre charras 1140fd0fb0 Eeschema, context menus: move edit value, ref and footprint to a submenu. 
remove also Select All menuitem from the move context menu.
 2022-06-13 11:35:17 +02:00
jean-pierre charras e0f0bb2edd Eeschema: Fix issues when converting a label/text to another label text type. 
- make convert to/from SCH_DIRECTIVE_LABEL working.
- Autoplace fields of new labels
Fixes #11779
https://gitlab.com/kicad/code/kicad/issues/11779
 2022-06-10 14:13:22 +02:00
jean-pierre charras 35bde4710c Eeschema, context menu selection: move convert to ... menuitems to a submenu. 
Add also missing icons in a few menuitems.
Fixes #11776
https://gitlab.com/kicad/code/kicad/issues/11776
 2022-06-09 16:46:21 +02:00
Jeff Young abba1b04bd Add "Enter Sheet" to Sheet tool (context menu & double-click). 
Fixes https://gitlab.com/kicad/code/kicad/issues/11531
 2022-05-30 14:08:26 +01:00
Mike Williams efa23a5cbe Schematic: better automatic/recursive annotate 2022-05-27 15:54:00 +00:00
Mike Williams dabd42bbc4 Schematic: Automatic Symbol Annotation 2022-05-27 15:54:00 +00:00