9311393016
Add expand/collapse to grouped rows in Fields Editor.
...
Fixes: lp:1767746
* https://bugs.launchpad.net/kicad/+bug/1767746
2018-05-12 23:05:04 +01:00
108dc20fba
Keep first segment of wire attached to sheet pin horizontal.
...
If allowed to go vertical it's very hard to see on top of the
sheet boundary and liable to short out other pins.
Fixes: lp:1685508
* https://bugs.launchpad.net/kicad/+bug/1685508
2018-05-11 21:50:43 +01:00
62d6750ced
Use default for attribute "display" if not found.
...
Fixes: lp:1767447
* https://bugs.launchpad.net/kicad/+bug/1767447
2018-05-11 16:11:38 +01:00
e91e88bfa1
Make sure read-only attr sticks when grid table rebuilt.
2018-05-11 12:33:53 +01:00
6e83f99c72
Relax fully-annotated constraint for BOM editor.
...
Also fixes a bug where unannotated components would get references
of the form R-1 (because their reference number was -1).
Fixes: lp:1768814
* https://bugs.launchpad.net/kicad/+bug/1768814
2018-05-11 12:33:44 +01:00
194c57133c
SCH_LEGACY_PLUGIN::loadHierarchy() uses a stack to maintain sheet paths
...
Path keeping stack copes well with paths pointing outside the project
directory (e.g. "../path"). The so far used wxFileName::GetDirCount() and
wxFileName::RemoveLastDir() remove too many directories, as ".." is also
counted as a directory.
Fixes: lp:1769746
* https://bugs.launchpad.net/kicad/+bug/1769746
2018-05-09 11:30:23 +02:00
c8f4e1051b
Eagle SCH import: keep multi-unit parts not interchangeable
...
Eagle supports more sophisticated unit swapping information,
so the safest choice is to prevent any unit manipulation.
2018-05-08 12:17:46 +02:00
44bf92ae64
Annotate schematic: fix annotation bug with multi-unit parts when these parts have a duplicate reference.
...
It happens only with option "Reset, but keep order of multi-unit parts, because the algo tried
to propagate the new reference to parts having the same old reference,
without testing if this old reference was duplicated.
Fixes: lp:1769250
https://bugs.launchpad.net/kicad/+bug/1769250
2018-05-08 09:46:25 +02:00
5a90858a46
Convert unit indicies to reference letters for annotation messages.
...
Fixes: lp:1769244
* https://bugs.launchpad.net/kicad/+bug/1769244
2018-05-06 00:23:04 +01:00
aa7da5dfcd
Treat ${...} and $(...) envvar references uniformly.
...
Fixes: lp:1769282
* https://bugs.launchpad.net/kicad/+bug/1769282
2018-05-05 23:40:40 +01:00
c23b263e39
Fix display issues in Layers list in Keepout Zone Properties.
2018-05-04 23:55:03 +01:00
0f5eb421b3
Fix duplicate menu shortcuts in Eeschema View menu.
...
Both "Leave Sheet" and "Library Browser" menu entries were mapped to the
'L' key. Mapped the "Library Browser" entry to the 'B' key.
Fix "Show hidden pins" menu entry capitalization.
Map "Show Hidden Pins" to 'P' key and "Full Window Crosshair" to 'W' key.
Fixes lp:1768671
https://bugs.launchpad.net/kicad/+bug/1768671
2018-05-03 10:49:44 -04:00
d0d9bb25c0
Menu consistence (add Config Paths to LibEdit).
2018-05-03 15:07:24 +01:00
8411ef04d0
Size fields list correctly in symbol properties editor
...
This patch prevents fields with long text values from unreasonable
dialog resizing. It is basically commit f4eb63f8
2018-05-03 12:20:40 +02:00
70cd27314b
Autocompletion for Spice model selector
2018-05-03 11:58:13 +02:00
72a70d61d8
Fixed the default value generated for Spice_Node_Sequence field
...
Values generated by NETLIST_EXPORTER_PSPICE::GetSpiceFieldDefVal()
and the actual value that was stored in a netlist differed when a
component has multiple units.
Due to that, the Spice model editor dialog incorrectly recognized
"alternate node sequence" value as the default one and cleared it
when the dialog was closed.
2018-05-03 11:29:34 +02:00
bf135b0690
Change Libedit save icon from Save Library to Save All Libraries.
...
Also changes Save Library and Save Library As to work off the
visible selection if there is one.
Also implements enablement for Save All Libraries.
Fixes: lp:1764081
* https://bugs.launchpad.net/kicad/+bug/1764081
2018-05-02 23:41:00 +01:00
af739f5b00
Check for duplicates when adding libraries.
...
This is particularly important when bulk adding (by director, etc.)
as otherwise the user might end up having to click OK to many
many error dialogs.
Fixes: lp:1764057
* https://bugs.launchpad.net/kicad/+bug/1764057
2018-05-02 21:49:57 +01:00
7395949ae0
LIB_ID: fix incorrect detection of illegal chars, when values are not ASCII values.
...
Fixes: lp:1764055
https://bugs.launchpad.net/kicad/+bug/1764055
2018-04-30 11:46:24 +02:00
b636aaddf6
Eeschema: fix incorrect UI messages in dialogs due to using UTF8 strings instead of wxStrings (unicode) to build them.
...
(Added a explicit to build a Unicode string in UI messages to avoid mistakes)
2018-04-30 11:46:23 +02:00
7b734551d3
Make sure pin-caches are up-to-date before testing dangling ends.
...
Fixes: lp:1767745
* https://bugs.launchpad.net/kicad/+bug/1767745
2018-04-29 16:55:24 +01:00
21ceb786ac
Clear annotations *after* rebuilding symbol links.
...
We need to symbol links to determine whether or not units are
locked (ie: non-interchangeable).
Fixes: lp:1767744
* https://bugs.launchpad.net/kicad/+bug/1767744
2018-04-29 15:09:28 +01:00
91cfecaa12
Don't allow wxDataViewCtrl updates during model update.
...
Also checks to make sure libraries are activated before adding
them to the component tree.
Fixes: lp:1765286
* https://bugs.launchpad.net/kicad/+bug/1765286
2018-04-28 10:45:32 +01:00
5a051358b7
Removed an obsolete comment
2018-04-28 01:19:42 +02:00
9960416e32
Spice simulator: plot currents in DC sweep simulation
...
Fixes: lp:1767457
* https://bugs.launchpad.net/kicad/+bug/1767457
2018-04-28 01:14:00 +02:00
4d6947b56a
Spice simulator: do not display V(0) in the signals list
2018-04-28 01:14:00 +02:00
539d12b08f
Spice simulator: more elegant approach to generating Spice device names
...
Code fixing Spice device names (prefixing reference with a character
corresponding to the assigned device model type) that was duplicated in
a few places has been moved to a function (NETLIST_EXPORTER_PSPICE::GetSpiceDevice()).
2018-04-28 01:14:00 +02:00
095112a902
Spice simulator: add device prefix only when necessary for DC sweep (missing in bc67d1ad)
2018-04-27 23:09:58 +02:00
502bed083d
Fix a minimal size for the spice simulator frame.
...
For an obscure reason, the minimal frame size fixed in EDA_BASE_FRAME was not working.
2018-04-27 20:35:23 +02:00
a9dd5b5335
Sim spice fix: the frame size was not the last stored size (like for other frames) but a default fixed value.
...
The frame size (and its subframes) is now the last used.
2018-04-27 18:33:13 +02:00
942d4e7658
Check footprint history list for validity.
...
Fixes: lp:1767108
* https://bugs.launchpad.net/kicad/+bug/1767108
2018-04-27 15:26:00 +01:00
bc67d1ad8c
Spice simulator: prefix reference with device type only when necesary
...
Fixes: lp:1767271
* https://bugs.launchpad.net/kicad/+bug/1767271
Fixes: lp:1700853
* https://bugs.launchpad.net/kicad/+bug/1700853
2018-04-27 14:18:53 +02:00
5e5e80d392
Don't allow panel to overwrite values set in Spice Model editor.
...
Fixes: lp:1766920
* https://bugs.launchpad.net/kicad/+bug/1766920
2018-04-26 19:13:19 +01:00
6ccc8577ad
Hand-code calculation of field names column width.
...
Fixes: lp:1737361
* https://bugs.launchpad.net/kicad/+bug/1737361
2018-04-26 19:13:19 +01:00
888c434776
Treat Mac as special case rather than GTK.
...
(Windows also needs the padding we use for GTK.)
2018-04-26 15:51:34 +01:00
dcf02f5f67
Use a single calc-column-width-impl for Fields Editor.
...
Also adds calculation of the initial splitter position based on
the widths of the fields in the list.
Fixes: lp:1737361
* https://bugs.launchpad.net/kicad/+bug/1737361
2018-04-26 11:10:58 +01:00
ac778bc5b4
Only draw hidden pins if requested or in LibEdit.
...
Fixes: lp:1742485
* https://bugs.launchpad.net/kicad/+bug/1742485
2018-04-25 20:07:22 +01:00
68e69fe95d
eeschema: context menu pops up on 2nd click after ESC key was pressed twice
...
other very minor fixes
Fixes: lp:1766830
https://bugs.launchpad.net/kicad/+bug/1766830
2018-04-25 14:28:41 +02:00
528a67b27c
Fix incorrect sizing of 2 columns in dialog, on GTK (issue perhaps depending on GTK/wxWidget version)
2018-04-25 12:07:43 +02:00
26ee673a6b
Validate symbol alias names read from .dcm files
...
Fixes: lp:1766551
* https://bugs.launchpad.net/kicad/+bug/1766551
2018-04-25 10:15:44 +02:00
4b3772cf07
Update value field when changing power symbol reference.
...
Fixes: lp:1765932
* https://bugs.launchpad.net/kicad/+bug/1765932
2018-04-25 00:36:08 +01:00
7e29ff0bc4
Conditional compilation for global fields editor listbox.
2018-04-24 23:45:44 +01:00
2694a76785
Standardize colons in symbol library dialog
2018-04-23 12:33:21 -07:00
3e652f2d40
Standardize colons and units in spice model dialog
2018-04-23 12:31:23 -07:00
2baca1d650
Standardize colons and units in spice sim settings dialog
2018-04-23 12:31:17 -07:00
445c0e66fb
Align search field
2018-04-23 11:55:28 -07:00
722886c9c7
Standardize colons in schematic plot dialog
2018-04-23 11:53:18 -07:00
805c38ffc5
Standardize colons in new component dialog
2018-04-23 11:53:18 -07:00
60abff1c02
Standardize colons in library text dialog
2018-04-23 11:53:18 -07:00
424fe8acd4
Standardize colons in libedit pin dialog
2018-04-23 11:53:18 -07:00
2c1f14fce5
Standardize colons in draw item dialog
2018-04-23 11:53:18 -07:00
c55cb8c557
Standardize colons in ERC dialog
2018-04-23 11:53:18 -07:00
f451ffb877
Standardize colons in schematic editor options dialog
2018-04-23 11:53:18 -07:00
83319f74c3
Standardize colons in line style dialog
2018-04-23 11:53:18 -07:00
2da575d539
Standardize wording and colons in libentry fields dialog
2018-04-23 11:53:18 -07:00
617d9288ab
Standardize colons in edit label dialog
2018-04-23 11:53:18 -07:00
32bb6064d7
Standardize colons in edit schematic component dialog
2018-04-23 11:53:18 -07:00
07281d78ad
Standardize colons in edit component dialog
2018-04-23 11:53:18 -07:00
8c2a7138d1
Standardize colons in BOM dialog
2018-04-23 11:53:18 -07:00
4640a656a2
Standardize colons in annotate dialog
2018-04-23 11:53:18 -07:00
aa71d41a59
Calculate column widths based on actual text & fontsize.
...
Fixes: lp:1737361
* https://bugs.launchpad.net/kicad/+bug/1737361
2018-04-23 18:24:10 +01:00
50588dcd1e
Fix disabled 'save library' button in the symbol editor
...
With uninitialized COMPONENT_TREE::m_menuActive there were cases when
application logic erroneously decided to fetch the current library name
from the right click menu selection, even though there was no menu
opened, so an empty string was returned. Empty library name is
equivalent to no library loaded, therefore the save button appeared
disabled.
Fixes: lp:1765937
* https://bugs.launchpad.net/kicad/+bug/1765937
2018-04-23 15:29:26 +02:00
cfa9916836
Prevent issuing a print command before the previous one is finished
...
Fixes: lp:1765965
* https://bugs.launchpad.net/kicad/+bug/1765965
2018-04-23 11:25:28 +02:00
648803dcf7
Eeschema: fix missing part in part list bug in netlist exporter.
...
Use LIB_ID for LIB_PART_LESS_THAN comparison. This prevents parts with
library name clashes from being dropped from the part list.
2018-04-22 16:33:34 -04:00
41c1657eb6
Eeschema: fix bug in sheet path loading logic.
...
When a relative sheet path was not in the project path or a subfolder
within the project path, the schematic path would be empty. Set the
base path to the project path when the schematic path is no within
the project path hierarchy.
2018-04-22 09:47:54 -04:00
4202bb6af6
DIALOG_EDIT_COMPONENTS_LIBID: fix the minimal size (previous code to fix this size was not working)
2018-04-21 17:53:54 +02:00
d776eaca83
Fix button sizer padding on symbol field edit dialog.
2018-04-20 19:19:13 -04:00
4302394990
Consistency between dialog titles and menu items.
...
... and between eeschema and pcbnew.
Also moved the Symbol & Footprint library table tabs to the top
so it's more clear what "by Scope" means.
Fixes: lp:1765359
* https://bugs.launchpad.net/kicad/+bug/1765359
Fixes: lp:1765516
* https://bugs.launchpad.net/kicad/+bug/1765516
2018-04-20 15:33:46 +01:00
554cb54a4f
Eagle SCH import: save project file after the full path is set
...
Fixes: lp:1765297
* https://bugs.launchpad.net/kicad/+bug/1765297
2018-04-20 10:04:41 +02:00
5506efaee5
Add a SaveAndContinue button to the Fields Editor.
2018-04-19 23:13:19 +01:00
b9239d8728
Add defensive coding for column widths in Fields Editor.
2018-04-19 21:39:25 +01:00
9201417c06
Handle new fields in global field editor.
...
Fixes: lp:1765443
* https://bugs.launchpad.net/kicad/+bug/1765443
2018-04-19 20:33:03 +01:00
1a5139b91f
eeschema: renamed 'Symbol Table' to 'Fields Editor'
...
Fixes: lp:1765360
* https://bugs.launchpad.net/kicad/+bug/1765360
2018-04-19 16:26:17 +02:00
e3a06dca70
Fallback to system ngspice library when libngspice is not found in other paths on macOS
2018-04-19 14:48:31 +02:00
2865084ce8
Library Field editor: validate alias name before changing it
...
When LIB_ALIAS is renamed, it validates the new name. In case the name
typed in the field edit dialog is invalid, there was a discrepancy
between the name used further in the code and the actual alias name.
Fixes: lp:1765375
* https://bugs.launchpad.net/kicad/+bug/1765375
2018-04-19 14:47:34 +02:00
4526f40fe1
ngspice: add extra paths to search for libngspice
...
The main purpose of the patch is to load libngspice from macOS bundle.
There are also some additional paths that could make Windows developers
easier.
Fixes: lp:1630675
* https://bugs.launchpad.net/kicad/+bug/1630675
2018-04-19 11:43:29 +02:00
a8ef222517
ngspice: keep the ngspice DLL handle as an automatic variable
2018-04-19 11:44:48 +02:00
d3f23a62ec
Bundle libngspice, code models and init scripts for macOS
2018-04-19 11:44:48 +02:00
442d1169a8
Adjust min sizes of Global Fields editor for Windows.
...
Also gets rid of a slew of unnecessary sizers in the dialog.
2018-04-18 20:37:20 +01:00
7e47ef7471
Fix warnings for unreferenced local variables
2018-04-18 15:08:37 -04:00
3179e40b57
Fix compil warning (perhaps 32 bit build specific)
2018-04-18 20:41:18 +02:00
7b3dc9c28d
Fix tabs->spaces
2018-04-18 08:22:52 -07:00
41ac458e79
Fixed SCH_LEGACY_PLUGIN_CACHE::saveBezier()
2018-04-18 09:36:22 +02:00
794e8d8a04
Moving IsOk dialogs to correct parents
2018-04-17 17:27:15 -07:00
626c8a71f7
Reworking sheet duplication messages and annotation
...
The messages on sheet duplication are changed to reflect the action
perceived by the user when accepting/rejecting the change.
Annotation is also reset for duplicating sheets where maintaining
existing annotation would conflict with existing sheets.
2018-04-17 17:12:51 -07:00
fdd3f52e2d
Move debug msg to relevant section
2018-04-17 17:12:29 -07:00
db2cda7271
Fix some merge issues.
2018-04-17 20:26:50 +01:00
2d5da8b04f
Fix assert when removing CurPart
...
Fixes: lp:1762099
* https://bugs.launchpad.net/kicad/+bug/1762099
2018-04-17 12:20:01 -07:00
853f73e6b7
Prevent duplicate sheetnames when using mouse copy
2018-04-17 12:01:03 -07:00
854cb70052
Fix compil issue with gcc 4.8 on Ubuntu
2018-04-17 19:35:26 +02:00
3be876c388
Cleanup of trace logs from Simon Richter.
2018-04-17 17:27:18 +01:00
0294e41cbc
fix minor compil warnings (about signed/unsigned comparison)
2018-04-17 16:08:12 +02:00
000457db7c
Move Fields Editor to wxGrid.
...
Makes in-place editing much easier and fixes some other issues
(see bug reports).
Fixed sorting bugs in References and added better sorting for
Values.
Removed Description column as it wasn't editable and caused more
confusion than value.
Removed auto-column-width after initial render.
Re-implemented undo/redo.
Fixes: lp:1749287
* https://bugs.launchpad.net/kicad/+bug/1749287
Fixes: lp:1737361
* https://bugs.launchpad.net/kicad/+bug/1737361
Fixes: lp:1759756
* https://bugs.launchpad.net/kicad/+bug/1759756
Fixes: lp:1763223
* https://bugs.launchpad.net/kicad/+bug/1763223
Fixes: lp:1761378
* https://bugs.launchpad.net/kicad/+bug/1761378
2018-04-17 11:39:44 +01:00
12ec56bc15
Prevent reentrancy in footprint loading.
...
Also removes parallel implementation in favour of using the
normal one (with a new wxGauge-backed PROGRESS_REPORTER).
Fixes: lp:1764196
* https://bugs.launchpad.net/kicad/+bug/1764196
2018-04-16 23:19:08 +01:00
2974a2c10a
Eeschema: fix broken generation of the project library cache.
...
Because the cache is broken, the rescue library was never created after missing library or change in lib.
This was due to the fact the symbol name inside the cache is broken, since commit a5844c9https://bugs.launchpad.net/kicad/+bug/1764166
2018-04-16 10:58:28 +02:00
d2cf2fe61c
Eeschema, fix issue when rotating a hierarchical sheet: depending on the sheet size, the rotation center was not always on grid.
...
Therefore, in this case, pin sheets were no longer on grid.
Fixes: lp:1764270
https://bugs.launchpad.net/kicad/+bug/1764270
2018-04-16 10:39:34 +02:00
3e64c9de38
Fix incorrect behavior of ReplaceIllegalFileNameChars( wxString& aName, int aReplaceChar ) for non ASCII8 chars.
...
(this function was using a comparison using chars to test wide chars)
Fixes: lp:1764055
https://bugs.launchpad.net/kicad/+bug/1764055
2018-04-15 10:06:53 +02:00
07dc12fdd3
Fix incorrect UI management of Zoom to Selection, created by fix 2a419156
2018-04-14 17:44:17 +02:00
4a254ee7f3
Eeschema, schematic file save issue: fix missing switch to C locale before saving files
...
The scale factor of bitmap images was incorrectly saved in countries using a comma as floating point separator
Fixes: lp:1763726
https://bugs.launchpad.net/kicad/+bug/1763726
2018-04-14 16:59:17 +02:00
a1acec5f13
Revert broken hotkey fix.
...
The hotkey fix committed in 53b1ec81
2018-04-14 08:24:25 -04:00
Jeff Young
Maciej Suminski
jean-pierre charras
Wayne Stambaugh
Seth Hillbrand
Simon Richter