8fc831cbc2
Validate arc output when editing
...
Handles checking output of the arc to ensure we don't end up generating
an invalid arc. Also keeps the limit of the arc angle to be (360,360)
excluding 0.
Fixes https://gitlab.com/kicad/code/kicad/issues/10070
2022-02-06 17:18:04 -08:00
3af606a020
Wide string decls for gerbview.
2022-02-05 19:59:29 +00:00
f412d8d461
CADSTAR: Fix potential nullptr dereferencing bug
...
Don't assume the footprint will have the pad index that the file references.
2022-02-05 19:22:05 +00:00
71bcc9883a
Fix typoed test condition for TH no hole pads PVS V501
...
(cherry picked from commit b9f1aaf029
2022-02-05 18:32:08 +00:00
be958e3fdb
Avoid potential divide by zero in footprint spreading PVS V609
...
(cherry picked from commit 8588bea4b2
2022-02-05 18:31:00 +00:00
b2c99dd953
Fix some leaking objects identified by PVS Studio V773
...
(cherry picked from commit a7ebfc31f9
2022-02-05 18:30:24 +00:00
471c0c4c1d
More wide-string declarations.
2022-02-05 13:29:00 +00:00
9e5e46514d
More wide-string declarations.
2022-02-05 13:29:00 +00:00
ba70f202ce
Fix a compil issue.
2022-02-05 11:16:56 +01:00
4657614e4f
More wxString wide literals.
2022-02-04 23:12:09 +00:00
2365c1e96f
Add duplicated items to parent group.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10155
(cherry picked from commit 42917874dd
2022-02-04 18:14:25 +00:00
430c4862b6
Log an undo item when filling zones.
...
If we wanted to put it into the parent's undo item, then the *parent*
would need to not start a new undo record. Not starting one in the
zone filler tries to add it to the *previous* change, not to the parent
change.
Fixes https://gitlab.com/kicad/code/kicad/issues/10091
(cherry picked from commit 4cc1ced2f3
2022-02-04 18:14:25 +00:00
4c81307391
Allow dialogs to force evaluation of UNIT_BINDER
...
When setting previous values, we don't get the "OnFocus" event, so the
evaluation would not get triggered by simply repeating (using the
keyboard)
Fixes https://gitlab.com/kicad/code/kicad/issues/10752
2022-02-04 10:03:23 -08:00
50d3a507d0
Mark some limits as constexpr
...
gcc doesn't need it and computes during compile regardless, but experimenting in godbolt, both clang and MSVC actually do need it or else it's partially computed at runtime
(cherry picked from commit ca7840334c
2022-02-04 12:50:54 +00:00
69b69aa431
Update text variables when they change.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10734
2022-02-04 00:34:20 +00:00
0a13f15a9d
Ensure we can version scripting properly
...
Adds Version() and FullVersion() calls to support reporting version to
scripts and scripting window
Fixes https://gitlab.com/kicad/code/kicad/issues/10079
2022-02-03 15:54:07 -08:00
ef94f31204
Update error message to match new arc dialog
...
We now provide arc end points and interior angle, so we cannot check for
null radius in the same fashion. Instead, the starpoint==endpoint
indicates a zero radius
Fixes https://gitlab.com/kicad/code/kicad/issues/10714
2022-02-03 14:31:58 -08:00
7601a3385f
Convert strings to wide when using wxString routines
...
WxString does not allocate space for wide strings needed during
conversion unless the string is explicitly wide. This can cause buffer
over/underflow
Fixes https://gitlab.com/kicad/code/kicad/issues/10605
2022-02-03 13:08:07 -08:00
901685f01b
Don't convert KIID on the fly
...
Converting to string on save prevent unneeded ops
2022-02-03 10:34:14 -08:00
b883eee911
Use superclass's copy c'tor from within subclass copy c'tor.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10481
(cherry picked from commit 8c758aeeb5
2022-02-03 15:00:39 +00:00
2425444947
Map zone layers before checking their visibility.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10509
(cherry picked from commit 09d0f6e17c
2022-02-03 15:00:39 +00:00
66e12af548
Expand text vars in titleblock before exporting.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10197
(cherry picked from commit 407660201e
2022-02-03 15:00:39 +00:00
ea38056e33
Resolve textvars in plot directory.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10405
(cherry picked from commit e5d5ee07f0
2022-02-03 15:00:39 +00:00
c805144c08
Support (and save/recall) zoom in/out in Custom Rules editor.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5796
(cherry picked from commit 0036f44e37
2022-02-03 15:00:39 +00:00
6d84acfacd
Handle invalid pads more gracefully
...
Pads generated outside of KiCad may have self-intersecting polygons that
simplify to multiple sets. We handle this by adding multiple primitives
for such polygons and limiting our fracture calls to only polygons that
have holes
Fixes https://gitlab.com/kicad/code/kicad/issues/10712
2022-02-02 13:36:24 -08:00
169881dcf1
EAGLE plugin: use specified RATIO value for text size calculation
...
(cherry picked from commit 61b2b0ff0c
2022-02-02 08:48:25 -08:00
3d11ce5139
export D356 netlist: fix incorrect id for pads type connectors.
...
these pads are similar to SMD pads and should have the same id.
Fixes #10694
https://gitlab.com/kicad/code/kicad/issues/10694
2022-02-01 08:45:02 +01:00
833ce19221
Be more diligent in preventing drag line errors
...
They can happen even when there are no collisions, so we need to reset
the 'ok' flag before using the line again.
Fixes https://gitlab.com/kicad/code/kicad/issues/9555
2022-01-31 16:09:14 -08:00
42dfdf8c38
PCB_CONTROL::unfilledZoneCheck(): skip rule areas: they are not filled by definition.
...
Fixes #10691
https://gitlab.com/kicad/code/kicad/issues/10691
2022-01-31 17:04:05 +01:00
26dfc4477f
PCB_TARGET: add missing TransformShapeWithClearanceToPolygon() method.
...
From Master branch.
2022-01-29 20:07:14 +01:00
38a4894d92
Prevent multiple single-point line solutions
...
Suggested by @rivimey, we test the case where both lines return singular
point lines and prevent them leaking into our drag solution
Fixes https://gitlab.com/kicad/code/kicad/issues/9555
2022-01-29 07:07:03 -08:00
c2707f3cc0
Fix large memory leak in DRC
...
All elements get effective shapes, many of which get triangulated. This
memory needs to be freed when destroying the tree
2022-01-28 17:07:11 -08:00
8753051db6
Don't count zero-length as duplicate
...
We were checking for duplicate tracks by looking to see if the two
tracks had two shared points. A null track always matched this case,
which removed the valid track. We solve this by avoiding null tracks in
the duplicate checker. They are removed separately in the null track
stage.
This also fixes a GTK-specific tree issue where we require the
BeforeReset()/AfterReset() calls instead of Cleared() to prevent GTK
from dereferencing a parent after freeing
Fixes https://gitlab.com/kicad/code/kicad/issues/10624
2022-01-28 16:34:00 -08:00
8ae304dcca
Don't allow degenerate lines in dragger
...
If walkaround returns an invalid line, don't consider it for a track
Fixes https://gitlab.com/kicad/code/kicad/issues/9555
2022-01-28 15:18:42 -08:00
796893de56
Fix negative arc angles in PCAD import
2022-01-28 10:18:17 -08:00
3f6a4296d9
Pcbnew, export svg: Fix incorrect saving of layer set.
...
From Master branch
2022-01-27 13:07:40 +01:00
60ae18893e
PCB_POINT_EDITOR: fix missing init of PAD pos0 after changing
...
(From Master branch)
2022-01-22 10:43:23 +01:00
d6c4215a1f
pcbnew: EAGLE importer does map value to wrong layer if nothing is defined in original EAGLE footprint
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10311
(cherry picked from commit 55b782d66e
2022-01-21 13:16:41 -08:00
c02cadec2a
Exclude rules which match no enabled layers.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10227
(cherry picked from commit 0967cc82e2
2022-01-21 15:06:18 +00:00
b608ebd058
Don't findnext on an empty string; show the dialog.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10313
(cherry picked from commit 60fc75e239
2022-01-21 15:05:27 +00:00
6d7659fb20
Flip arc endpoints when mirroring in FPEditor.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10550
(cherry picked from commit 7f6bc28f87
2022-01-21 15:02:15 +00:00
dd7029ea07
Always use the project directory for default save
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10478
2022-01-20 11:51:16 -08:00
da28ade004
Footprint editor: use most recently used path on footprint import.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/10418
(cherry picked from commit c154e85ebd
2022-01-16 09:48:21 -05:00
2306d00c89
Do not check key states for non-key events in TryBefore
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/10127
2022-01-13 22:28:45 -05:00
20bbf9b179
PNS: Do not clear layer pairs when importing new sizes
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/10225
2022-01-13 20:37:37 -05:00
cf4d46b24d
PNS: Do not allow smart pads when in 90-degree mode
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/10386
2022-01-13 20:21:19 -05:00
739c14eaa2
FOOTPRINT::GetProperty() swig extension
...
(cherry picked from commit 33a4c9b08e
2022-01-13 13:10:44 -08:00
adfbfc27af
Footprint editor: fix Eagle plugin footprint library layer mapping bug.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/10354
(cherry picked from commit a77b5649cc
2022-01-12 20:52:55 -05:00
57d58fe335
Handle Unicode clipboard data in pcbnew and symbol editor
...
Fixes #10323
(cherry picked from commit 8373180cbb
2022-01-12 09:23:24 -08:00
b2ecf097ed
Include Footprints within Groups when re annotating duplicates
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/10329
(cherry picked from commit de7158b80e
2022-01-11 20:52:01 +00:00
Seth Hillbrand
Jeff Young
Roberto Fernandez Bautista
Marek Roszko
jean-pierre charras
Steffen Mauch
Wayne Stambaugh
Jon Evans
qu1ck
dana