jean-pierre charras
b482deb8b0
Fix a incorrect code after a old other code change.
2020-06-18 12:53:06 +02:00
jean-pierre charras
567ce48cc1
panel lib tables: avoid crash when deleting the last entry in list.
...
From master branch
2020-06-14 17:51:27 +02:00
jean-pierre charras
c027e72439
Solder mask clearance default value: set default to 0, taking advice from
...
both Ucamco and Eurocircuits.
Update message in plot dialog about best solder mask clearance value.
Show a warning message in plot dialog if these values are no 0.
From master branch.
2020-06-07 15:52:12 +02:00
Jeff Young
a844c3043c
Fix offset issue when pad edited from board instead of modEdit.
...
(cherry picked from commit 7db4a3f702
)
2020-06-03 14:42:13 +01:00
Jeff Young
78d66a9ac3
Don't allow the pad preview canvas to become too large.
...
Also offset canvas with pad so that hole stays in centre.
Fixes https://gitlab.com/kicad/code/kicad/issues/4185
(cherry picked from commit 3bd4c0c5dc
)
2020-06-02 22:57:05 +01:00
Jeff Young
a02ee3719c
Update membership grid when a netclass name changes.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4596
2020-06-01 21:57:16 +01:00
jean-pierre charras
601633347c
Pcbnew: fix a crash when trying to edit a pad in the board editor
2020-05-28 09:51:06 +02:00
Michael Kavanagh
182973c0ee
NPTH pads can have the hole offset from centre
...
Fixes https://gitlab.com/kicad/code/kicad/issues/3671
(cherry picked from commit e800c47406
)
2020-05-26 13:35:38 -04:00
jean-pierre charras
fde7ae4d19
Pcbnew: fix a crash due to use of invalid pointers after a list modification
...
from master branch, fix bug #4409
2020-05-13 14:04:20 +02:00
Jeff Young
e37e13e700
If more than one text matches by text try layer and then position.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4187
(cherry picked from commit 8df5f70c4a
)
2020-05-13 00:14:40 +01:00
Jeff Young
d22003578e
Use standard OK/Cancel paradigm rather than Apply/Cancel.
...
Apply/Cancel puts the buttons in a different order on some platforms.
Fixes https://gitlab.com/kicad/code/kicad/issues/4332
(cherry picked from commit 52d1c93777
)
2020-05-13 00:04:51 +01:00
Jeff Young
37b723d8ae
Fix pad name increment to use last edited pad.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/1882
(cherry picked from commit 56946f4db1
)
2020-05-12 22:58:15 +01:00
Jeff Young
faace3090c
Add specific selection updating when adding 3D models.
...
This keeps us from being at the receiving end of wxWidgets' vagaries.
Fixes https://gitlab.com/kicad/code/kicad/issues/3760
2020-04-19 22:43:32 +01:00
jean-pierre charras
a3e087ab51
Pcbnew: Fix crashes when delete footprint text in some cases.
...
Fixes #4221
https://gitlab.com/kicad/code/kicad/issues/4221
2020-04-18 20:00:26 +02:00
jean-pierre charras
54be07c17d
Pcbnew: Set default solder mask min size to 0.
...
When the solder mask min size is > 0, pads are no longer flashed or regions items.
Good Gerber files need pads flashed or regions items.
Non 0 solder mask min size is reserved to special cases (home made PCBs for instance)
From master branch.
2020-03-12 20:47:21 +01:00
Michael Kavanagh
ce2c5d6528
Remove empty choice in Via type dropdown
...
Fixes https://gitlab.com/kicad/code/kicad/issues/3968
(cherry picked from commit 265c1663f9
)
2020-03-03 14:21:21 -08:00
Seth Hillbrand
83c3a78e6d
pcbnew: Avoid wx scaling error
...
When drawing to a scaled DC, the window doesn't reflect the expected
size if scaled after. This causes elements drawn on the edge to reflect
back into the drawing area instead of being cut off.
We can simply scale our own values to avoid this issue.
Fixes #3849 | https://gitlab.com/kicad/code/kicad/issues/3849
(cherry picked from commit 5b6a4d794f
)
2020-02-27 09:01:18 -08:00
jean-pierre charras
be0f6a6af2
Fp editor: fix: Reference and Value default values aren't saved in Footprint Editor preferences
...
Fixes #3889
https://gitlab.com/kicad/code/kicad/issues/3889
2020-02-11 15:48:05 +01:00
jean-pierre charras
87f6f33b37
fix a minor wxWidgets alert.
2019-12-27 20:03:02 +01:00
jean-pierre charras
8c7e0bcb0a
DIALOG_DRC_CONTROL: fix a crash on wxWidgets 3.1.3
...
Happens when right clicking on an item in displayed lists.
The crash was due to a bug in wxWidgets, and the fix is only a workaround
From commit 5cd7f3fd
in master branch.
Also remove duplicate code.
2019-12-03 09:47:42 +01:00
jean-pierre charras
239f040a98
Fix minor wxWidgets alert (wxWidgets 3.1.3)
2019-11-20 18:29:11 +01:00
jean-pierre charras
36acadbd52
DIALOG_PAD_PROPERTIES: fix incorrect pad type for Aperture option.
...
The aperture option created a Connector pad only on the paste layer.
This is incorrect: the SMD type only is acceptable.
Connector is *only* for edge card connectors.
Moreover, The dialog did not even accept the setting defined by this dialog...
2019-11-17 18:28:08 +01:00
jean-pierre charras
fb1570d290
DIALOG_POSITION_RELATIVE_BASE: fix wxWidget alerts
2019-10-23 20:41:00 +02:00
Ian McInerney
61934c285c
pcbnew: Fix deletion of vias in global delete window
...
Fixes: lp:1847580
* https://bugs.launchpad.net/kicad/+bug/1847580
(cherry picked from commit 3b1817ee32
)
2019-10-23 12:25:00 -04:00
jean-pierre charras
6506f77689
Gencad export: fix an issue in hash_eda calculation,
...
that can generate the same hash for 2 different footprints.
Therefore, for some footprints, the right footprint was not associated to the component.
The hash calculation was using a XOR to combine 2 sub hash values.
This is not a reliable way to combine these hash values.
They are now added.
Looks better to identify similar and different footprints.
Fixes: lp:1847575
https://bugs.launchpad.net/kicad/+bug/1847575
2019-10-10 20:20:45 +02:00
jean-pierre charras
0210e414d2
Fp editor, DIALOG_FOOTPRINT_FP_EDITOR: fix a very annoying issue: the value field was copuled to the fp name. Unlike schematic symbols, the value field and the footprint name are 2 different fields. So coupling these fields in the DIALOG_FOOTPRINT_FP_EDITOR dialog created serious issues.
...
Fixes: lp:1846533
https://bugs.launchpad.net/kicad/+bug/1846533
2019-10-09 18:58:23 +02:00
jean-pierre charras
78af1daa2e
Fix an issue in DIALOG_NETLIST: if the netlist filename does not exist, one cannot always modify the entered name.
...
(from master branch)
2019-09-30 19:43:25 +02:00
jean-pierre charras
4db8638f7e
PANEL_SETUP_NETCLASSES: fix not working (immediately closed) wxChoice widgets to select a filter This happens with wxWidgets 3.0.4 on Windows and is a side effect of a call to Layout(). The fix just calls Layout() only when needed.
...
Fixes: lp:1843594
https://bugs.launchpad.net/kicad/+bug/1843594
2019-09-13 11:53:03 +02:00
Jeff Young
cec885daf9
Partial cherry-pick of f1790c24e5
.
...
Fixes: lp:1842199
* https://bugs.launchpad.net/kicad/+bug/1842199
2019-09-12 22:15:36 +01:00
jean-pierre charras
95265c765b
Pcbnew, DIALOG_TEXT_PROPERTIES: make lines thickness editable when editing a dimension.
...
From Master branch (commit 762dabd7
)
Fixes: lp:1841797
https://bugs.launchpad.net/kicad/+bug/1841797
2019-09-02 10:03:39 +02:00
Jeff Young
5b24ea9dd9
Clearance should be in mils, not inches.
...
Fixes: lp:1841360
* https://bugs.launchpad.net/kicad/+bug/1841360
(cherry picked from commit 7c85dc6cd7
)
2019-08-27 21:15:54 +01:00
Jeff Young
86691dabbf
Partial cherry-pick of 03da721030
.
...
Fixes: lp:1841361
* https://bugs.launchpad.net/kicad/+bug/1841361
2019-08-27 18:16:25 +01:00
Seth Hillbrand
fe71a66bb9
pcbnew: Force resize event when changing pad type
...
The local settings panel needs to have its children sized when shown.
Triggering a resize event on changing the pad shape accomplishes this.
This is not triggered in master due to refactor of the custom pad
connection options.
Fixes: lp:1837789
* https://bugs.launchpad.net/kicad/+bug/1837789
2019-08-27 05:55:04 -07:00
Seth Hillbrand
8b3a2984bf
pcbnew: Two layer boards need both masks
...
Adds the missing default layer to the default board setups for two
layers with parts on single side (either top or bottom)
Fixes: lp:1841294
* https://bugs.launchpad.net/kicad/+bug/1841294
2019-08-26 17:14:13 -07:00
Jeff Young
e404fb772b
Invoke move by ACTION; the EDIT_TOOL does lots of other stuff too.
...
Fixes: lp:1839877
* https://bugs.launchpad.net/kicad/+bug/1839877
(cherry picked from commit f3f0a6899f
)
2019-08-12 23:00:55 +01:00
jean-pierre charras
090073cc3b
Pcbnew, exchange footprints: fix a bug that prevent the new footprint to be at the right place.
...
Fixes: lp:1838446
https://bugs.launchpad.net/kicad/+bug/1838446
2019-07-31 12:07:49 +02:00
Jeff Young
4b01f80e8d
Fix typo in cherry-pick.
...
Fixes: lp:1838006
* https://bugs.launchpad.net/kicad/+bug/1838006
2019-07-30 11:49:06 -06:00
jean-pierre charras
c8f40e1d26
PANEL_SETUP_NETCLASSES_BASE: fix minor wxAlert.
2019-07-28 13:26:58 +02:00
jean-pierre charras
185a8d7582
Try to fix UI issues in select layer pair dialog and slect layer dialog.
...
Fixes: lp:1838173
https://bugs.launchpad.net/kicad/+bug/1838173
2019-07-28 12:55:47 +02:00
Jeff Young
6aeedfb70c
Partial cherry-pick of 3904d7ccfc
.
...
Fixes: lp:1838006
* https://bugs.launchpad.net/kicad/+bug/1838006
2019-07-26 20:46:12 -06:00
Jeff Young
ca0d4511a9
Copy ratsnest flags when exchanging modules.
...
Fixes: lp:1834214
* https://bugs.launchpad.net/kicad/+bug/1834214
(cherry picked from commit 2ca379b281
)
2019-07-21 20:27:12 -06:00
Jeff Young
72e8eb3b94
Initialize plot with aux origin checkbox.
...
Fixes: lp:1836923
* https://bugs.launchpad.net/kicad/+bug/1836923
(cherry picked from commit b5e01ea163
)
2019-07-20 07:58:43 -06:00
Jeff Young
281a1cdc2c
Update DXF units drop-down.
...
Fixes: lp:1836927
* https://bugs.launchpad.net/kicad/+bug/1836927
(cherry picked from commit 4a1edf581e
)
2019-07-20 07:58:38 -06:00
Ian McInerney
02d43be93c
pcbnew: Make the netlist class panel usable with a lot of classes
...
Fixes: lp:1826154
* https://bugs.launchpad.net/kicad/+bug/1826154
(cherry picked from commit 39954b20fe
)
2019-07-15 06:12:13 -07:00
Jeff Young
f11d950448
Don't let visibility bit get nuked when updating effects.
...
Fixes: lp:1836183
* https://bugs.launchpad.net/kicad/+bug/1836183
(cherry picked from commit 6c9e34e799
)
2019-07-11 23:01:54 +01:00
Ian McInerney
40ba502853
pcbnew: Clean up warnings with unit handling in the DXF export
...
(cherry picked from commit ff9d899ae0
)
2019-07-10 12:42:54 -04:00
Jeff Young
26c92eaf0f
Give up on KillFocus validation.
...
wxWidgets sends the KillFocus event before the Cancel button event,
and it sets the receiving-focus window pointer to NULL (so you can't
even check for it being the Cancel button. Last time around (with
the UNIT_BINDER) I also tried a bunch of hacks for whether the window
pointer is NULL, etc., but they aren't discriminatory either.
Fixes: lp:1834975
* https://bugs.launchpad.net/kicad/+bug/1834975
Fixes: lp:1834966
* https://bugs.launchpad.net/kicad/+bug/1834966
(cherry picked from commit 1c30f3d9a9
)
2019-07-02 18:13:27 +01:00
Jeff Young
3b98b00d6f
Only warn once in KillFocus for each error value in footprint name.
...
More than that just gets annoying, and there is at least one edge case
which throws us into an infinite loop if we don't have something to
break us out.
Fixes: lp:1834966
* https://bugs.launchpad.net/kicad/+bug/1834966
(cherry picked from commit 29db6152b3
)
2019-07-02 00:48:57 +01:00
Seth Hillbrand
3974c6fd89
Enforcing rational limits on length tuner
...
The length tuning dialog needed validators on close to prevent negative
and percentages >100%
Fixes: lp:1834734
* https://bugs.launchpad.net/kicad/+bug/1834734
2019-06-29 09:37:47 -07:00
Jeff Young
b8fff99e68
Hook up zone-connection controls in Edit Footprint dialog.
...
Fixes: lp:1834629
* https://bugs.launchpad.net/kicad/+bug/1834629
2019-06-28 12:26:28 +01:00